You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Carlos Rovira <ca...@apache.org> on 2014/02/28 00:25:48 UTC
FlexJS build broken
Hi,
after clean and build falcon and then asks with the last updates I had
build broken due to spaces in js comments...very strange isn't it?
removing spaces, I get build broken:
compile:
[echo] running gjslint
[exec] 134 files checked, no errors found.
[echo] running jshint
[exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js: line
161, col 24, ['flexjs_wrapper'] is better written in dot notation.
[exec]
[exec] FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
line 72, col 17, ['clickHandler'] is better written in dot notation.
[exec]
[exec] 2 errors
BUILD FAILED
/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following
error occurred while executing this line:
/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
exec returned: 2
I see this is a change of Erik, and seems exactly the point he want to fix,
but in my case I can't build
Maybe I need to make something special in this scenario?
Thanks
--
Carlos Rovira
http://about.me/carlosrovira
Re: FlexJS build broken
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Thanks Erik, just tested the fix I compilation was successful :)
C.
2014-02-28 8:54 GMT+01:00 Erik de Bruin <er...@ixsoftware.nl>:
> Ah, as to why I didn't get the error in the first place: I ran ant on a
> specific example, not the ant in root. I guess the example ants don't lint.
>
> EdB
>
>
>
>
> On Fri, Feb 28, 2014 at 8:53 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>
> > Ok, I've made the error go away ;-)
> >
> > EdB
> >
> >
> >
> >
> > On Fri, Feb 28, 2014 at 8:35 AM, Erik de Bruin <er...@ixsoftware.nl>
> wrote:
> >
> >> Hi Carlos,
> >>
> >> Thank you for your patience. You were right to hold off on that 'fix'. I
> >> specifically didn't use dot notation for these properties because that
> >> would allow the Closure Compiler to rename them. Since these properties
> are
> >> called from outside code, we don't want that to happen. I could've used
> >> externs or exportSymbol, but that would have involved more code and/or
> >> extra files.
> >>
> >> I don't know why I didn't get that JSHint warning/error. Looking into
> >> that now.
> >>
> >> EdB
> >>
> >>
> >>
> >>
> >> On Fri, Feb 28, 2014 at 8:17 AM, Carlos Rovira <
> >> carlos.rovira@codeoscopic.com> wrote:
> >>
> >>> Hi Alex, Erik change from dot notation so I prefer wait since I don't
> >>> know
> >>> the motivations behind
> >>>
> >>> Thanks
> >>>
> >>> El viernes, 28 de febrero de 2014, Alex Harui <ah...@adobe.com>
> >>> escribió:
> >>>
> >>> > Might want to wait for Erik, but why not just use dot notation there?
> >>> >
> >>> > It is puzzling if he didn't get these same errors.
> >>> >
> >>> > -Alex
> >>> >
> >>> > On 2/27/14 3:25 PM, "Carlos Rovira" <carlosrovira@apache.org
> >>> <javascript:;>>
> >>> > wrote:
> >>> >
> >>> > >Hi,
> >>> > >
> >>> > >after clean and build falcon and then asks with the last updates I
> had
> >>> > >build broken due to spaces in js comments...very strange isn't it?
> >>> > >
> >>> > >removing spaces, I get build broken:
> >>> > >
> >>> > >compile:
> >>> > >
> >>> > > [echo] running gjslint
> >>> > >
> >>> > > [exec] 134 files checked, no errors found.
> >>> > >
> >>> > > [echo] running jshint
> >>> > >
> >>> > > [exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js:
> >>> line
> >>> > >161, col 24, ['flexjs_wrapper'] is better written in dot notation.
> >>> > >
> >>> > > [exec]
> >>> > >
> >>> > > [exec]
> >>> FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
> >>> > >line 72, col 17, ['clickHandler'] is better written in dot notation.
> >>> > >
> >>> > > [exec]
> >>> > >
> >>> > > [exec] 2 errors
> >>> > >
> >>> > >
> >>> > >BUILD FAILED
> >>> > >
> >>> > >/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The
> >>> following
> >>> > >error occurred while executing this line:
> >>> > >
> >>> >
> >>>
> >/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
> >>> > >exec returned: 2
> >>> > >
> >>> > >
> >>> > >I see this is a change of Erik, and seems exactly the point he want
> to
> >>> > >fix,
> >>> > >but in my case I can't build
> >>> > >
> >>> > >
> >>> > >Maybe I need to make something special in this scenario?
> >>> > >
> >>> > >
> >>> > >Thanks
> >>> > >
> >>> > >--
> >>> > >Carlos Rovira
> >>> > >http://about.me/carlosrovira
> >>> >
> >>> >
> >>>
> >>> --
> >>> Carlos Rovira
> >>> Director de Tecnología
> >>> M: +34 607 22 60 05
> >>> F: +34 912 94 80 80
> >>> http://www.codeoscopic.com
> >>> http://www.directwriter.es
> >>> http://www.avant2.es
> >>>
> >>
> >>
> >>
> >> --
> >> Ix Multimedia Software
> >>
> >> Jan Luykenstraat 27
> >> 3521 VB Utrecht
> >>
> >> T. 06-51952295
> >> I. www.ixsoftware.nl
> >>
> >
> >
> >
> > --
> > Ix Multimedia Software
> >
> > Jan Luykenstraat 27
> > 3521 VB Utrecht
> >
> > T. 06-51952295
> > I. www.ixsoftware.nl
> >
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F: +34 912 94 80 80
http://www.codeoscopic.com
http://www.directwriter.es
http://www.avant2.es
Re: FlexJS build broken
Posted by Erik de Bruin <er...@ixsoftware.nl>.
No, technically you are correct. I was working on the SDK using the
example, changing both and then running the ant for the example. Anyway,
next time I'll remember to run the uber-ant before committing.
EdB
On Fri, Feb 28, 2014 at 3:37 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
> On 2/27/14 11:54 PM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>
> >Ah, as to why I didn't get the error in the first place: I ran ant on a
> >specific example, not the ant in root. I guess the example ants don't
> >lint.
> In theory, there is no JS to lint in the examples folder because all of it
> is generated? Or should our generated code also lint cleanly?
>
> -Alex
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: FlexJS build broken
Posted by Alex Harui <ah...@adobe.com>.
On 2/27/14 11:54 PM, "Erik de Bruin" <er...@ixsoftware.nl> wrote:
>Ah, as to why I didn't get the error in the first place: I ran ant on a
>specific example, not the ant in root. I guess the example ants don't
>lint.
In theory, there is no JS to lint in the examples folder because all of it
is generated? Or should our generated code also lint cleanly?
-Alex
Re: FlexJS build broken
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Ah, as to why I didn't get the error in the first place: I ran ant on a
specific example, not the ant in root. I guess the example ants don't lint.
EdB
On Fri, Feb 28, 2014 at 8:53 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Ok, I've made the error go away ;-)
>
> EdB
>
>
>
>
> On Fri, Feb 28, 2014 at 8:35 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>
>> Hi Carlos,
>>
>> Thank you for your patience. You were right to hold off on that 'fix'. I
>> specifically didn't use dot notation for these properties because that
>> would allow the Closure Compiler to rename them. Since these properties are
>> called from outside code, we don't want that to happen. I could've used
>> externs or exportSymbol, but that would have involved more code and/or
>> extra files.
>>
>> I don't know why I didn't get that JSHint warning/error. Looking into
>> that now.
>>
>> EdB
>>
>>
>>
>>
>> On Fri, Feb 28, 2014 at 8:17 AM, Carlos Rovira <
>> carlos.rovira@codeoscopic.com> wrote:
>>
>>> Hi Alex, Erik change from dot notation so I prefer wait since I don't
>>> know
>>> the motivations behind
>>>
>>> Thanks
>>>
>>> El viernes, 28 de febrero de 2014, Alex Harui <ah...@adobe.com>
>>> escribió:
>>>
>>> > Might want to wait for Erik, but why not just use dot notation there?
>>> >
>>> > It is puzzling if he didn't get these same errors.
>>> >
>>> > -Alex
>>> >
>>> > On 2/27/14 3:25 PM, "Carlos Rovira" <carlosrovira@apache.org
>>> <javascript:;>>
>>> > wrote:
>>> >
>>> > >Hi,
>>> > >
>>> > >after clean and build falcon and then asks with the last updates I had
>>> > >build broken due to spaces in js comments...very strange isn't it?
>>> > >
>>> > >removing spaces, I get build broken:
>>> > >
>>> > >compile:
>>> > >
>>> > > [echo] running gjslint
>>> > >
>>> > > [exec] 134 files checked, no errors found.
>>> > >
>>> > > [echo] running jshint
>>> > >
>>> > > [exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js:
>>> line
>>> > >161, col 24, ['flexjs_wrapper'] is better written in dot notation.
>>> > >
>>> > > [exec]
>>> > >
>>> > > [exec]
>>> FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
>>> > >line 72, col 17, ['clickHandler'] is better written in dot notation.
>>> > >
>>> > > [exec]
>>> > >
>>> > > [exec] 2 errors
>>> > >
>>> > >
>>> > >BUILD FAILED
>>> > >
>>> > >/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The
>>> following
>>> > >error occurred while executing this line:
>>> > >
>>> >
>>> >/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
>>> > >exec returned: 2
>>> > >
>>> > >
>>> > >I see this is a change of Erik, and seems exactly the point he want to
>>> > >fix,
>>> > >but in my case I can't build
>>> > >
>>> > >
>>> > >Maybe I need to make something special in this scenario?
>>> > >
>>> > >
>>> > >Thanks
>>> > >
>>> > >--
>>> > >Carlos Rovira
>>> > >http://about.me/carlosrovira
>>> >
>>> >
>>>
>>> --
>>> Carlos Rovira
>>> Director de Tecnología
>>> M: +34 607 22 60 05
>>> F: +34 912 94 80 80
>>> http://www.codeoscopic.com
>>> http://www.directwriter.es
>>> http://www.avant2.es
>>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: FlexJS build broken
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Ok, I've made the error go away ;-)
EdB
On Fri, Feb 28, 2014 at 8:35 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Hi Carlos,
>
> Thank you for your patience. You were right to hold off on that 'fix'. I
> specifically didn't use dot notation for these properties because that
> would allow the Closure Compiler to rename them. Since these properties are
> called from outside code, we don't want that to happen. I could've used
> externs or exportSymbol, but that would have involved more code and/or
> extra files.
>
> I don't know why I didn't get that JSHint warning/error. Looking into that
> now.
>
> EdB
>
>
>
>
> On Fri, Feb 28, 2014 at 8:17 AM, Carlos Rovira <
> carlos.rovira@codeoscopic.com> wrote:
>
>> Hi Alex, Erik change from dot notation so I prefer wait since I don't know
>> the motivations behind
>>
>> Thanks
>>
>> El viernes, 28 de febrero de 2014, Alex Harui <ah...@adobe.com>
>> escribió:
>>
>> > Might want to wait for Erik, but why not just use dot notation there?
>> >
>> > It is puzzling if he didn't get these same errors.
>> >
>> > -Alex
>> >
>> > On 2/27/14 3:25 PM, "Carlos Rovira" <carlosrovira@apache.org
>> <javascript:;>>
>> > wrote:
>> >
>> > >Hi,
>> > >
>> > >after clean and build falcon and then asks with the last updates I had
>> > >build broken due to spaces in js comments...very strange isn't it?
>> > >
>> > >removing spaces, I get build broken:
>> > >
>> > >compile:
>> > >
>> > > [echo] running gjslint
>> > >
>> > > [exec] 134 files checked, no errors found.
>> > >
>> > > [echo] running jshint
>> > >
>> > > [exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js: line
>> > >161, col 24, ['flexjs_wrapper'] is better written in dot notation.
>> > >
>> > > [exec]
>> > >
>> > > [exec]
>> FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
>> > >line 72, col 17, ['clickHandler'] is better written in dot notation.
>> > >
>> > > [exec]
>> > >
>> > > [exec] 2 errors
>> > >
>> > >
>> > >BUILD FAILED
>> > >
>> > >/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The
>> following
>> > >error occurred while executing this line:
>> > >
>> >
>> >/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
>> > >exec returned: 2
>> > >
>> > >
>> > >I see this is a change of Erik, and seems exactly the point he want to
>> > >fix,
>> > >but in my case I can't build
>> > >
>> > >
>> > >Maybe I need to make something special in this scenario?
>> > >
>> > >
>> > >Thanks
>> > >
>> > >--
>> > >Carlos Rovira
>> > >http://about.me/carlosrovira
>> >
>> >
>>
>> --
>> Carlos Rovira
>> Director de Tecnología
>> M: +34 607 22 60 05
>> F: +34 912 94 80 80
>> http://www.codeoscopic.com
>> http://www.directwriter.es
>> http://www.avant2.es
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: FlexJS build broken
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Hi Carlos,
Thank you for your patience. You were right to hold off on that 'fix'. I
specifically didn't use dot notation for these properties because that
would allow the Closure Compiler to rename them. Since these properties are
called from outside code, we don't want that to happen. I could've used
externs or exportSymbol, but that would have involved more code and/or
extra files.
I don't know why I didn't get that JSHint warning/error. Looking into that
now.
EdB
On Fri, Feb 28, 2014 at 8:17 AM, Carlos Rovira <
carlos.rovira@codeoscopic.com> wrote:
> Hi Alex, Erik change from dot notation so I prefer wait since I don't know
> the motivations behind
>
> Thanks
>
> El viernes, 28 de febrero de 2014, Alex Harui <ah...@adobe.com> escribió:
>
> > Might want to wait for Erik, but why not just use dot notation there?
> >
> > It is puzzling if he didn't get these same errors.
> >
> > -Alex
> >
> > On 2/27/14 3:25 PM, "Carlos Rovira" <carlosrovira@apache.org
> <javascript:;>>
> > wrote:
> >
> > >Hi,
> > >
> > >after clean and build falcon and then asks with the last updates I had
> > >build broken due to spaces in js comments...very strange isn't it?
> > >
> > >removing spaces, I get build broken:
> > >
> > >compile:
> > >
> > > [echo] running gjslint
> > >
> > > [exec] 134 files checked, no errors found.
> > >
> > > [echo] running jshint
> > >
> > > [exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js: line
> > >161, col 24, ['flexjs_wrapper'] is better written in dot notation.
> > >
> > > [exec]
> > >
> > > [exec] FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
> > >line 72, col 17, ['clickHandler'] is better written in dot notation.
> > >
> > > [exec]
> > >
> > > [exec] 2 errors
> > >
> > >
> > >BUILD FAILED
> > >
> > >/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The
> following
> > >error occurred while executing this line:
> > >
> > >/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
> > >exec returned: 2
> > >
> > >
> > >I see this is a change of Erik, and seems exactly the point he want to
> > >fix,
> > >but in my case I can't build
> > >
> > >
> > >Maybe I need to make something special in this scenario?
> > >
> > >
> > >Thanks
> > >
> > >--
> > >Carlos Rovira
> > >http://about.me/carlosrovira
> >
> >
>
> --
> Carlos Rovira
> Director de Tecnología
> M: +34 607 22 60 05
> F: +34 912 94 80 80
> http://www.codeoscopic.com
> http://www.directwriter.es
> http://www.avant2.es
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: FlexJS build broken
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi Alex, Erik change from dot notation so I prefer wait since I don't know
the motivations behind
Thanks
El viernes, 28 de febrero de 2014, Alex Harui <ah...@adobe.com> escribió:
> Might want to wait for Erik, but why not just use dot notation there?
>
> It is puzzling if he didn't get these same errors.
>
> -Alex
>
> On 2/27/14 3:25 PM, "Carlos Rovira" <carlosrovira@apache.org<javascript:;>>
> wrote:
>
> >Hi,
> >
> >after clean and build falcon and then asks with the last updates I had
> >build broken due to spaces in js comments...very strange isn't it?
> >
> >removing spaces, I get build broken:
> >
> >compile:
> >
> > [echo] running gjslint
> >
> > [exec] 134 files checked, no errors found.
> >
> > [echo] running jshint
> >
> > [exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js: line
> >161, col 24, ['flexjs_wrapper'] is better written in dot notation.
> >
> > [exec]
> >
> > [exec] FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
> >line 72, col 17, ['clickHandler'] is better written in dot notation.
> >
> > [exec]
> >
> > [exec] 2 errors
> >
> >
> >BUILD FAILED
> >
> >/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following
> >error occurred while executing this line:
> >
> >/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
> >exec returned: 2
> >
> >
> >I see this is a change of Erik, and seems exactly the point he want to
> >fix,
> >but in my case I can't build
> >
> >
> >Maybe I need to make something special in this scenario?
> >
> >
> >Thanks
> >
> >--
> >Carlos Rovira
> >http://about.me/carlosrovira
>
>
--
Carlos Rovira
Director de Tecnología
M: +34 607 22 60 05
F: +34 912 94 80 80
http://www.codeoscopic.com
http://www.directwriter.es
http://www.avant2.es
Re: FlexJS build broken
Posted by Alex Harui <ah...@adobe.com>.
Might want to wait for Erik, but why not just use dot notation there?
It is puzzling if he didn't get these same errors.
-Alex
On 2/27/14 3:25 PM, "Carlos Rovira" <ca...@apache.org> wrote:
>Hi,
>
>after clean and build falcon and then asks with the last updates I had
>build broken due to spaces in js comments...very strange isn't it?
>
>removing spaces, I get build broken:
>
>compile:
>
> [echo] running gjslint
>
> [exec] 134 files checked, no errors found.
>
> [echo] running jshint
>
> [exec] FlexJS/src/org/apache/flex/core/HTMLElementWrapper.js: line
>161, col 24, ['flexjs_wrapper'] is better written in dot notation.
>
> [exec]
>
> [exec] FlexJS/src/org/apache/flex/svg/staticControls/TextButton.js:
>line 72, col 17, ['clickHandler'] is better written in dot notation.
>
> [exec]
>
> [exec] 2 errors
>
>
>BUILD FAILED
>
>/Users/carlosrovira/dev/apacheflex/flex-asjs/build.xml:399: The following
>error occurred while executing this line:
>
>/Users/carlosrovira/dev/apacheflex/flex-asjs/frameworks/js/build.xml:96:
>exec returned: 2
>
>
>I see this is a change of Erik, and seems exactly the point he want to
>fix,
>but in my case I can't build
>
>
>Maybe I need to make something special in this scenario?
>
>
>Thanks
>
>--
>Carlos Rovira
>http://about.me/carlosrovira