Re: [PR] HIVE-27370: support 4 bytes characters [hive]

["deniskuzZ (via GitHub)" <gi...@apache.org>]

deniskuzZ commented on code in PR #5624:
URL: https://github.com/apache/hive/pull/5624#discussion_r2009123344


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java:
##########
@@ -96,53 +96,131 @@ private Text evaluateInternal(Text t, int pos, int len) {
       return r;
     }
 
-    String s = t.toString();
-    int[] index = makeIndex(pos, len, s.length());
-    if (index == null) {
+    byte[] utf8String = t.toString().getBytes();
+    populateSubstrOffsets(utf8String, pos, len);
+    if (index[0] == -1) {
       return r;
     }
 
-    r.set(s.substring(index[0], index[1]));
+    r.set(new String(utf8String, index[0], index[1]));
     return r;
   }
 
-  private int[] makeIndex(int pos, int len, int inputLen) {
-    if ((Math.abs(pos) > inputLen)) {
-      return null;
+  private Text evaluateInternal(Text t, int pos) {
+    r.clear();
+
+    byte[] utf8String = t.toString().getBytes();
+    int offset = getSubstrStartOffset(utf8String, pos);
+    if (offset == -1) {
+      return r;
     }
 
-    int start, end;
+    r.set(new String(utf8String, offset, utf8String.length - offset));
+    return r;
+  }
+
+  private void populateSubstrOffsets(byte[] utf8String, int start, int len) {

Review Comment:
   try to reuse methods instead of copy&paste



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org