You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/06/07 23:16:36 UTC
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13565
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
[java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
It turns out that scan tokens in the Java client behave nicely with
respect to dropping range partitions- one can drop a range partition
anytime after creating the tokens and the tokens can still be used.
There is a case where some tablets in the dropped partition will still
return rows, while others don't, but that can be looked at as a
manifestation of the fact that tablet alters aren't linearizable in Kudu
(yet?).
Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
1 file changed, 41 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/13565/1
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13565
to look at the new patch set (#3).
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
[java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
It turns out that scan tokens in the Java client behave nicely with
respect to dropping range partitions- one can drop a range partition
anytime after creating the tokens and the tokens can still be used.
There is a case where some tablets in the dropped partition will still
return rows, while others don't, but that can be looked at as a
manifestation of the fact that tablet alters aren't linearizable in Kudu
(yet?).
Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
1 file changed, 67 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/13565/3
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13565
to look at the new patch set (#2).
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
[java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
It turns out that scan tokens in the Java client behave nicely with
respect to dropping range partitions- one can drop a range partition
anytime after creating the tokens and the tokens can still be used.
There is a case where some tablets in the dropped partition will still
return rows, while others don't, but that can be looked at as a
manifestation of the fact that tablet alters aren't linearizable in Kudu
(yet?).
Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
1 file changed, 67 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/13565/2
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13565 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
[java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
It turns out that scan tokens in the Java client behave nicely with
respect to dropping range partitions- one can drop a range partition
anytime after creating the tokens and the tokens can still be used.
There is a case where some tablets in the dropped partition will still
return rows, while others don't, but that can be looked at as a
manifestation of the fact that tablet alters aren't linearizable in Kudu
(yet?).
Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Reviewed-on: http://gerrit.cloudera.org:8080/13565
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
1 file changed, 67 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:06:30 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java:
http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java@340
PS2, Line 340: Dehydrate
Technically you're hydrating them.
http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java@351
PS2, Line 351: // Check the scanners work. The scanners for the tablets in the range [10, 20) definitely won't
: // see any rows. The scanners for the tablets in the range [20, 30) might see rows.
Have you looked into why this is? I would have expected a TABLET_NOT_FOUND error somewhere under the hood, surfaced as a NonRecoverableException.
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:31:37 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java:
http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java@340
PS2, Line 340: Dehydrate
> Technically you're hydrating them.
Oops.
http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java@351
PS2, Line 351: // Check the scanners work. The scanners for the tablets in the range [10, 20) definitely won't
: // see any rows. The scanners for the tablets in the range [20, 30) might see rows.
> Have you looked into why this is? I would have expected a TABLET_NOT_FOUND
That's recoverable- it'll check for another replica. Once it checks for all replicas, it refreshes the cache from the master, and then realizes there's no tablet for that part of partition key space, and apparently returns 0 results for the scan.
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 08 Jun 2019 02:06:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13565
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13565
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 17:13:53 +0000
Gerrit-HasComments: No