You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Matt Benson <gu...@gmail.com> on 2024/03/20 21:06:17 UTC
Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]
I just opted to solve potentially several feature requests with a single
code change rather than addressing each one separately with similar code
repeated in e.g. every profile activator implementation.
On Wed, Mar 20, 2024 at 3:57 PM gnodet (via GitHub) <gi...@apache.org> wrote:
>
> gnodet commented on PR #1446:
> URL: https://github.com/apache/maven/pull/1446#issuecomment-2010621686
>
> > That was what I originally considered, but I quickly came to the
> opinion that as soon as we did it that way, someone would want to use some
> such property to match a Java version, etc., and that this would be a
> generally applicable way to solve a broad cross section of similar use
> cases.
>
> How could that be considered a bad thing ?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
Re: [PR] [MNG-8081] interpolate available properties during default profile selection (Maven 4.x) [maven]
Posted by Guillaume Nodet <gn...@apache.org>.
I thought you were referring to having a small language in the
property activation...
Le mer. 20 mars 2024 à 22:06, Matt Benson <gu...@gmail.com> a écrit :
>
> I just opted to solve potentially several feature requests with a single
> code change rather than addressing each one separately with similar code
> repeated in e.g. every profile activator implementation.
>
> On Wed, Mar 20, 2024 at 3:57 PM gnodet (via GitHub) <gi...@apache.org> wrote:
>
> >
> > gnodet commented on PR #1446:
> > URL: https://github.com/apache/maven/pull/1446#issuecomment-2010621686
> >
> > > That was what I originally considered, but I quickly came to the
> > opinion that as soon as we did it that way, someone would want to use some
> > such property to match a Java version, etc., and that this would be a
> > generally applicable way to solve a broad cross section of similar use
> > cases.
> >
> > How could that be considered a bad thing ?
> >
> >
> > --
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
> >
> > For queries about this service, please contact Infrastructure at:
> > users@infra.apache.org
> >
> >
--
------------------------
Guillaume Nodet
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org