[GitHub] [doris] morningman commented on a diff in pull request #13444: [Improvement][SET-PROPERTY]Support for set query_timeout property

[GitBox <gi...@apache.org>]

morningman commented on code in PR #13444:
URL: https://github.com/apache/doris/pull/13444#discussion_r998042360


##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -146,6 +146,12 @@ public class ConnectContext {
 
     private SessionContext sessionContext;
 
+    private long userQueryTimeout;
+
+    public void setUserQueryTimeoutMap(long queryTimeout) {

Review Comment:
   ```suggestion
       public void setUserQueryTimeout(long queryTimeout) {
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -557,6 +563,11 @@ public void checkTimeout(long now) {
 
                 // Only kill
                 killFlag = true;
+            } else if (delta > userQueryTimeout * 1000) {

Review Comment:
   If querytimeout is set in property, it should override the querytimeou in session variable



##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserProperty.java:
##########
@@ -452,6 +469,9 @@ public List<List<String>> fetchProperty() {
         // exec mem limit
         result.add(Lists.newArrayList(PROP_EXEC_MEM_LIMIT, String.valueOf(commonProperties.getExecMemLimit())));
 
+        // timeout limit

Review Comment:
   ```suggestion
           // query timeout
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org