You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pekko.apache.org by Matthew de Detrich <ma...@aiven.io.INVALID> on 2023/09/20 09:45:54 UTC
[DISCUSS] Pekko CONNECTORS 1.0.1 release
Hi everyone,
This is a thread to discuss a release of Pekko Connectors 1.0.1. Ordinarily
I
wouldn't initiate a discussion for a new release so early, but PJ Fanning
uncovered an issue[1] whereby the apiURL for pekko-connectors is
incorrect[2].
Since the apiURL is a feature of autoAPIMappings[3], this means that the
currently
incorrect apiURL is part of the pekko connectors 1.0.0 release (the
information is
encoded in the pom[4]). Hence any project (even outside of Pekko) that
happens to
reference any of the artifacts in pekko-connectors in their scaladoc will
have
incorrect links.
The release is intended to only have this fix, otherwise everything will be
the
same as Pekko Connectors 1.0.0. Getting it out sooner rather than later
would
be beneficial so that the ecosystem can update to 1.0.1 incase they happen
to
have incorrectly generated scaladocs.
[1]:
https://github.com/apache/incubator-pekko-persistence-cassandra/pull/102
[2]: https://github.com/apache/incubator-pekko-connectors/pull/252
[3]:
https://www.scala-sbt.org/1.x/docs/Howto-Scaladoc.html#Define+the+location+of+API+documentation+for+a+library
[4]:
https://repo1.maven.org/maven2/org/apache/pekko/pekko-connectors-google-common_2.13/1.0.0/pekko-connectors-google-common_2.13-1.0.0.pom
(see info.apiURL xml node)
--
Matthew de Detrich
*Aiven Deutschland GmbH*
Immanuelkirchstraße 26, 10405 Berlin
Amtsgericht Charlottenburg, HRB 209739 B
Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
*m:* +491603708037
*w:* aiven.io *e:* matthew.dedetrich@aiven.io
Re: [DISCUSS] Pekko CONNECTORS 1.0.1 release
Posted by PJ Fanning <fa...@apache.org>.
So the plan is to release a Pekko gRPC 1.0.1 first and to have Pekko Connectors 1.0.1 uptake that.
On 2023/09/21 07:49:48 Matthew de Detrich wrote:
> > The issue has had a minor impact on some links in our javadoc. I'm not
> convinced that we need to expedite a 1.0.1 release. The Pekko
> Connectors fix is definitely something that should be included in a
> 1.0.1 release but I'd be happy enough if we do the release in a few
> weeks.
>
> I would just say that it's not only our docs, it's anyone's docs that happen
> to link to pekko-connectors (otherwise I also would not care so much).
>
> > With Pekko Connectors, we are eying up a release within the next few
> weeks to add Slick Scala3 support when there is a Slick 3.5.0 release.
> I think that should be a 1.1.0 release because the dependency change
> is not a small upgrade but I guess it could still be argued that that
> change could be done in 1.0.x release.
>
> All of these changes, i.e. reactive mongo/slick and others should def
> go into 1.1.x and not be bundled with this apiURL doc fix. There is
> still an outstanding issue[1] with Slick 3.5.0 that needs to be looked into
> and the maintainer of Slick also wants to test Slick 3.5.0 with other parts
> of the ecosystem to make sure that it works (i.e. slick-pg[2])
>
> > It's sort of a pity that a
> non-trivial change in one connector means that all 40 connectors need
> a 1.1.0 release. I'm open to other suggestions but I think we could
> have a 1.0.1 and 1.1.0 release together in a few weeks.
>
> Thankfully at least with this fix, it **does** require changing every single
> artifact/pom because the apiURL is embedded in the root pom.xml of
> every artifact in pekko-connectors.
>
> > I would like to release Pekko gRPC 1.0.1 before that. There are 2
> Pekko Connectors that have Pekko gRPC dependencies.
> There are dependency upgrades for protobuf-java and guava to avoid
> having dependencies with CVEs.
>
> Sure, shall we initiate a release discussion for Pekko gRPC then or
> are there any outstanding PR's there?
>
> > Pekko Persistence JDBC 1.0.1/1.1.0 (with Slick upgrade)
>
> For slick 3.5.0 upgrade it should be 1.1.0, not 1.0.1
>
> [1]: https://github.com/slick/slick/issues/2811
> [2]: https://github.com/tminglei/slick-pg
>
> On Wed, Sep 20, 2023 at 7:43 PM PJ Fanning <fa...@apache.org> wrote:
>
> > The issue has had a minor impact on some links in our javadoc. I'm not
> > convinced that we need to expedite a 1.0.1 release. The Pekko
> > Connectors fix is definitely something that should be included in a
> > 1.0.1 release but I'd be happy enough if we do the release in a few
> > weeks.
> >
> > With Pekko Connectors, we are eying up a release within the next few
> > weeks to add Slick Scala3 support when there is a Slick 3.5.0 release.
> > I think that should be a 1.1.0 release because the dependency change
> > is not a small upgrade but I guess it could still be argued that that
> > change could be done in 1.0.x release. It's sort of a pity that a
> > non-trivial change in one connector means that all 40 connectors need
> > a 1.1.0 release. I'm open to other suggestions but I think we could
> > have a 1.0.1 and 1.1.0 release together in a few weeks.
> >
> > I would like to release Pekko gRPC 1.0.1 before that. There are 2
> > Pekko Connectors that have Pekko gRPC dependencies.
> > There are dependency upgrades for protobuf-java and guava to avoid
> > having dependencies with CVEs.
> >
> > I would suggest these patch releases.
> > * Pekko gRPC 1.0.1
> > * Pekko Connectors 1.0.1 (with the apiURL fix and possibly also gRPC
> > upgrade)
> > * Pekko Connectors 1.1.0 (with the apiURL fix and Slick and gRPC
> > upgrades - possibly also some more dependency lib upgrades too).
> > * Pekko Persistence JDBC 1.0.1/1.1.0 (with Slick upgrade)
> >
> > There is also the small matter of getting out more 1.0.0 releases
> > * Pekko Persistence Cassandra 1.0.0 (RC1 vote has reached the Incubator
> > list)
> > * Pekko Persistence Dynamodb 1.0.0
> > * Pekko Projections 1.0.0 (needs a Pekko Persistence Cassandra 1.0.0
> > release - and the Slick upgrade Pekko Persistence JDBC release would
> > be nice to have for full Scala 3 support)
> > * Pekko Persistence R2DBC 1.0.0 (needs a Pekko Projections 1.0.0
> > release - and the Slick upgrade Pekko Persistence JDBC release would
> > be nice to have for full Scala 3 support)
> >
> > On Wed, 20 Sept 2023 at 15:16, Matthew de Detrich
> > <ma...@aiven.io.invalid> wrote:
> > >
> > > Hi everyone,
> > >
> > > This is a thread to discuss a release of Pekko Connectors 1.0.1.
> > Ordinarily
> > > I
> > > wouldn't initiate a discussion for a new release so early, but PJ Fanning
> > > uncovered an issue[1] whereby the apiURL for pekko-connectors is
> > > incorrect[2].
> > >
> > > Since the apiURL is a feature of autoAPIMappings[3], this means that the
> > > currently
> > > incorrect apiURL is part of the pekko connectors 1.0.0 release (the
> > > information is
> > > encoded in the pom[4]). Hence any project (even outside of Pekko) that
> > > happens to
> > > reference any of the artifacts in pekko-connectors in their scaladoc will
> > > have
> > > incorrect links.
> > >
> > > The release is intended to only have this fix, otherwise everything will
> > be
> > > the
> > > same as Pekko Connectors 1.0.0. Getting it out sooner rather than later
> > > would
> > > be beneficial so that the ecosystem can update to 1.0.1 incase they
> > happen
> > > to
> > > have incorrectly generated scaladocs.
> > >
> > > [1]:
> > > https://github.com/apache/incubator-pekko-persistence-cassandra/pull/102
> > > [2]: https://github.com/apache/incubator-pekko-connectors/pull/252
> > > [3]:
> > >
> > https://www.scala-sbt.org/1.x/docs/Howto-Scaladoc.html#Define+the+location+of+API+documentation+for+a+library
> > > [4]:
> > >
> > https://repo1.maven.org/maven2/org/apache/pekko/pekko-connectors-google-common_2.13/1.0.0/pekko-connectors-google-common_2.13-1.0.0.pom
> > > (see info.apiURL xml node)
> > > --
> > >
> > > Matthew de Detrich
> > >
> > > *Aiven Deutschland GmbH*
> > >
> > > Immanuelkirchstraße 26, 10405 Berlin
> > >
> > > Amtsgericht Charlottenburg, HRB 209739 B
> > >
> > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> > >
> > > *m:* +491603708037
> > >
> > > *w:* aiven.io *e:* matthew.dedetrich@aiven.io
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> > For additional commands, e-mail: dev-help@pekko.apache.org
> >
> >
>
> --
>
> Matthew de Detrich
>
> *Aiven Deutschland GmbH*
>
> Immanuelkirchstraße 26, 10405 Berlin
>
> Amtsgericht Charlottenburg, HRB 209739 B
>
> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>
> *m:* +491603708037
>
> *w:* aiven.io *e:* matthew.dedetrich@aiven.io
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org
Re: [DISCUSS] Pekko CONNECTORS 1.0.1 release
Posted by Matthew de Detrich <ma...@aiven.io.INVALID>.
> The issue has had a minor impact on some links in our javadoc. I'm not
convinced that we need to expedite a 1.0.1 release. The Pekko
Connectors fix is definitely something that should be included in a
1.0.1 release but I'd be happy enough if we do the release in a few
weeks.
I would just say that it's not only our docs, it's anyone's docs that happen
to link to pekko-connectors (otherwise I also would not care so much).
> With Pekko Connectors, we are eying up a release within the next few
weeks to add Slick Scala3 support when there is a Slick 3.5.0 release.
I think that should be a 1.1.0 release because the dependency change
is not a small upgrade but I guess it could still be argued that that
change could be done in 1.0.x release.
All of these changes, i.e. reactive mongo/slick and others should def
go into 1.1.x and not be bundled with this apiURL doc fix. There is
still an outstanding issue[1] with Slick 3.5.0 that needs to be looked into
and the maintainer of Slick also wants to test Slick 3.5.0 with other parts
of the ecosystem to make sure that it works (i.e. slick-pg[2])
> It's sort of a pity that a
non-trivial change in one connector means that all 40 connectors need
a 1.1.0 release. I'm open to other suggestions but I think we could
have a 1.0.1 and 1.1.0 release together in a few weeks.
Thankfully at least with this fix, it **does** require changing every single
artifact/pom because the apiURL is embedded in the root pom.xml of
every artifact in pekko-connectors.
> I would like to release Pekko gRPC 1.0.1 before that. There are 2
Pekko Connectors that have Pekko gRPC dependencies.
There are dependency upgrades for protobuf-java and guava to avoid
having dependencies with CVEs.
Sure, shall we initiate a release discussion for Pekko gRPC then or
are there any outstanding PR's there?
> Pekko Persistence JDBC 1.0.1/1.1.0 (with Slick upgrade)
For slick 3.5.0 upgrade it should be 1.1.0, not 1.0.1
[1]: https://github.com/slick/slick/issues/2811
[2]: https://github.com/tminglei/slick-pg
On Wed, Sep 20, 2023 at 7:43 PM PJ Fanning <fa...@apache.org> wrote:
> The issue has had a minor impact on some links in our javadoc. I'm not
> convinced that we need to expedite a 1.0.1 release. The Pekko
> Connectors fix is definitely something that should be included in a
> 1.0.1 release but I'd be happy enough if we do the release in a few
> weeks.
>
> With Pekko Connectors, we are eying up a release within the next few
> weeks to add Slick Scala3 support when there is a Slick 3.5.0 release.
> I think that should be a 1.1.0 release because the dependency change
> is not a small upgrade but I guess it could still be argued that that
> change could be done in 1.0.x release. It's sort of a pity that a
> non-trivial change in one connector means that all 40 connectors need
> a 1.1.0 release. I'm open to other suggestions but I think we could
> have a 1.0.1 and 1.1.0 release together in a few weeks.
>
> I would like to release Pekko gRPC 1.0.1 before that. There are 2
> Pekko Connectors that have Pekko gRPC dependencies.
> There are dependency upgrades for protobuf-java and guava to avoid
> having dependencies with CVEs.
>
> I would suggest these patch releases.
> * Pekko gRPC 1.0.1
> * Pekko Connectors 1.0.1 (with the apiURL fix and possibly also gRPC
> upgrade)
> * Pekko Connectors 1.1.0 (with the apiURL fix and Slick and gRPC
> upgrades - possibly also some more dependency lib upgrades too).
> * Pekko Persistence JDBC 1.0.1/1.1.0 (with Slick upgrade)
>
> There is also the small matter of getting out more 1.0.0 releases
> * Pekko Persistence Cassandra 1.0.0 (RC1 vote has reached the Incubator
> list)
> * Pekko Persistence Dynamodb 1.0.0
> * Pekko Projections 1.0.0 (needs a Pekko Persistence Cassandra 1.0.0
> release - and the Slick upgrade Pekko Persistence JDBC release would
> be nice to have for full Scala 3 support)
> * Pekko Persistence R2DBC 1.0.0 (needs a Pekko Projections 1.0.0
> release - and the Slick upgrade Pekko Persistence JDBC release would
> be nice to have for full Scala 3 support)
>
> On Wed, 20 Sept 2023 at 15:16, Matthew de Detrich
> <ma...@aiven.io.invalid> wrote:
> >
> > Hi everyone,
> >
> > This is a thread to discuss a release of Pekko Connectors 1.0.1.
> Ordinarily
> > I
> > wouldn't initiate a discussion for a new release so early, but PJ Fanning
> > uncovered an issue[1] whereby the apiURL for pekko-connectors is
> > incorrect[2].
> >
> > Since the apiURL is a feature of autoAPIMappings[3], this means that the
> > currently
> > incorrect apiURL is part of the pekko connectors 1.0.0 release (the
> > information is
> > encoded in the pom[4]). Hence any project (even outside of Pekko) that
> > happens to
> > reference any of the artifacts in pekko-connectors in their scaladoc will
> > have
> > incorrect links.
> >
> > The release is intended to only have this fix, otherwise everything will
> be
> > the
> > same as Pekko Connectors 1.0.0. Getting it out sooner rather than later
> > would
> > be beneficial so that the ecosystem can update to 1.0.1 incase they
> happen
> > to
> > have incorrectly generated scaladocs.
> >
> > [1]:
> > https://github.com/apache/incubator-pekko-persistence-cassandra/pull/102
> > [2]: https://github.com/apache/incubator-pekko-connectors/pull/252
> > [3]:
> >
> https://www.scala-sbt.org/1.x/docs/Howto-Scaladoc.html#Define+the+location+of+API+documentation+for+a+library
> > [4]:
> >
> https://repo1.maven.org/maven2/org/apache/pekko/pekko-connectors-google-common_2.13/1.0.0/pekko-connectors-google-common_2.13-1.0.0.pom
> > (see info.apiURL xml node)
> > --
> >
> > Matthew de Detrich
> >
> > *Aiven Deutschland GmbH*
> >
> > Immanuelkirchstraße 26, 10405 Berlin
> >
> > Amtsgericht Charlottenburg, HRB 209739 B
> >
> > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
> >
> > *m:* +491603708037
> >
> > *w:* aiven.io *e:* matthew.dedetrich@aiven.io
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
> For additional commands, e-mail: dev-help@pekko.apache.org
>
>
--
Matthew de Detrich
*Aiven Deutschland GmbH*
Immanuelkirchstraße 26, 10405 Berlin
Amtsgericht Charlottenburg, HRB 209739 B
Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
*m:* +491603708037
*w:* aiven.io *e:* matthew.dedetrich@aiven.io
Re: [DISCUSS] Pekko CONNECTORS 1.0.1 release
Posted by PJ Fanning <fa...@apache.org>.
The issue has had a minor impact on some links in our javadoc. I'm not
convinced that we need to expedite a 1.0.1 release. The Pekko
Connectors fix is definitely something that should be included in a
1.0.1 release but I'd be happy enough if we do the release in a few
weeks.
With Pekko Connectors, we are eying up a release within the next few
weeks to add Slick Scala3 support when there is a Slick 3.5.0 release.
I think that should be a 1.1.0 release because the dependency change
is not a small upgrade but I guess it could still be argued that that
change could be done in 1.0.x release. It's sort of a pity that a
non-trivial change in one connector means that all 40 connectors need
a 1.1.0 release. I'm open to other suggestions but I think we could
have a 1.0.1 and 1.1.0 release together in a few weeks.
I would like to release Pekko gRPC 1.0.1 before that. There are 2
Pekko Connectors that have Pekko gRPC dependencies.
There are dependency upgrades for protobuf-java and guava to avoid
having dependencies with CVEs.
I would suggest these patch releases.
* Pekko gRPC 1.0.1
* Pekko Connectors 1.0.1 (with the apiURL fix and possibly also gRPC upgrade)
* Pekko Connectors 1.1.0 (with the apiURL fix and Slick and gRPC
upgrades - possibly also some more dependency lib upgrades too).
* Pekko Persistence JDBC 1.0.1/1.1.0 (with Slick upgrade)
There is also the small matter of getting out more 1.0.0 releases
* Pekko Persistence Cassandra 1.0.0 (RC1 vote has reached the Incubator list)
* Pekko Persistence Dynamodb 1.0.0
* Pekko Projections 1.0.0 (needs a Pekko Persistence Cassandra 1.0.0
release - and the Slick upgrade Pekko Persistence JDBC release would
be nice to have for full Scala 3 support)
* Pekko Persistence R2DBC 1.0.0 (needs a Pekko Projections 1.0.0
release - and the Slick upgrade Pekko Persistence JDBC release would
be nice to have for full Scala 3 support)
On Wed, 20 Sept 2023 at 15:16, Matthew de Detrich
<ma...@aiven.io.invalid> wrote:
>
> Hi everyone,
>
> This is a thread to discuss a release of Pekko Connectors 1.0.1. Ordinarily
> I
> wouldn't initiate a discussion for a new release so early, but PJ Fanning
> uncovered an issue[1] whereby the apiURL for pekko-connectors is
> incorrect[2].
>
> Since the apiURL is a feature of autoAPIMappings[3], this means that the
> currently
> incorrect apiURL is part of the pekko connectors 1.0.0 release (the
> information is
> encoded in the pom[4]). Hence any project (even outside of Pekko) that
> happens to
> reference any of the artifacts in pekko-connectors in their scaladoc will
> have
> incorrect links.
>
> The release is intended to only have this fix, otherwise everything will be
> the
> same as Pekko Connectors 1.0.0. Getting it out sooner rather than later
> would
> be beneficial so that the ecosystem can update to 1.0.1 incase they happen
> to
> have incorrectly generated scaladocs.
>
> [1]:
> https://github.com/apache/incubator-pekko-persistence-cassandra/pull/102
> [2]: https://github.com/apache/incubator-pekko-connectors/pull/252
> [3]:
> https://www.scala-sbt.org/1.x/docs/Howto-Scaladoc.html#Define+the+location+of+API+documentation+for+a+library
> [4]:
> https://repo1.maven.org/maven2/org/apache/pekko/pekko-connectors-google-common_2.13/1.0.0/pekko-connectors-google-common_2.13-1.0.0.pom
> (see info.apiURL xml node)
> --
>
> Matthew de Detrich
>
> *Aiven Deutschland GmbH*
>
> Immanuelkirchstraße 26, 10405 Berlin
>
> Amtsgericht Charlottenburg, HRB 209739 B
>
> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen
>
> *m:* +491603708037
>
> *w:* aiven.io *e:* matthew.dedetrich@aiven.io
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pekko.apache.org
For additional commands, e-mail: dev-help@pekko.apache.org