You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Koci (JIRA)" <de...@myfaces.apache.org> on 2010/02/04 22:09:29 UTC
[jira] Created: (MYFACES-2536) converterId and validatorId should
not be required
converterId and validatorId should not be required
--------------------------------------------------
Key: MYFACES-2536
URL: https://issues.apache.org/jira/browse/MYFACES-2536
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0-beta-2
Environment: myfaces core trunk
Reporter: Martin Koci
Priority: Trivial
With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2536) converterId and validatorId should
not be required
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844857#action_12844857 ]
Jakob Korherr commented on MYFACES-2536:
----------------------------------------
This was not really what I ment. Take a look at the code in ConvertDelegateHandler:
public String getConverterId(FaceletContext ctx)
{
return converterId.getValue(ctx);
}
If converterId is not required anymore, this code will throw an ugly NullPointerException.
I will take care of this now :)
> converterId and validatorId should not be required
> --------------------------------------------------
>
> Key: MYFACES-2536
> URL: https://issues.apache.org/jira/browse/MYFACES-2536
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces core trunk
> Reporter: Martin Koci
> Assignee: Jakob Korherr
> Priority: Trivial
> Attachments: MYFACES-2536.patch
>
>
> With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2536) converterId and validatorId should
not be required
Posted by "Martin Koci (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831994#action_12831994 ]
Martin Koci commented on MYFACES-2536:
--------------------------------------
Yes, ugly exceptions happen with <f:converter binding="#{aNonExistentBean}" />:
1) myfaces: NPE in ConvertDelegateHandler
2) mojarra: javax.faces.view.facelets.TagException: /test.xhtml <f:converter> Default behavior invoked of requiring a converter-id passed in the constructor, must override ConvertHandler(ConverterConfig)
Is seems that this odd behaviour comes from old facelts codebase. I try to find out how those converterId/binding attributes should cooperate.
> converterId and validatorId should not be required
> --------------------------------------------------
>
> Key: MYFACES-2536
> URL: https://issues.apache.org/jira/browse/MYFACES-2536
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces core trunk
> Reporter: Martin Koci
> Priority: Trivial
> Attachments: MYFACES-2536.patch
>
>
> With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2536) converterId and validatorId should
not be required
Posted by "Martin Koci (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Koci updated MYFACES-2536:
---------------------------------
Status: Patch Available (was: Open)
> converterId and validatorId should not be required
> --------------------------------------------------
>
> Key: MYFACES-2536
> URL: https://issues.apache.org/jira/browse/MYFACES-2536
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces core trunk
> Reporter: Martin Koci
> Priority: Trivial
> Attachments: MYFACES-2536.patch
>
>
> With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2536) converterId and validatorId should
not be required
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831947#action_12831947 ]
Jakob Korherr commented on MYFACES-2536:
----------------------------------------
Martin,
can you ensure that the code which works with validatorId or converterId checks if they are null? We don't want ugly NullPointerExceptions. Please check that and then I'll commit the patch.
> converterId and validatorId should not be required
> --------------------------------------------------
>
> Key: MYFACES-2536
> URL: https://issues.apache.org/jira/browse/MYFACES-2536
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces core trunk
> Reporter: Martin Koci
> Priority: Trivial
> Attachments: MYFACES-2536.patch
>
>
> With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2536) converterId and validatorId should
not be required
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844860#action_12844860 ]
Jakob Korherr commented on MYFACES-2536:
----------------------------------------
Furthermore we have to change this also for JSP.
> converterId and validatorId should not be required
> --------------------------------------------------
>
> Key: MYFACES-2536
> URL: https://issues.apache.org/jira/browse/MYFACES-2536
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces core trunk
> Reporter: Martin Koci
> Assignee: Jakob Korherr
> Priority: Trivial
> Attachments: MYFACES-2536.patch
>
>
> With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2536) converterId and validatorId should
not be required
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2536:
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-3
Status: Resolved (was: Patch Available)
> converterId and validatorId should not be required
> --------------------------------------------------
>
> Key: MYFACES-2536
> URL: https://issues.apache.org/jira/browse/MYFACES-2536
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta-2
> Environment: myfaces core trunk
> Reporter: Martin Koci
> Assignee: Jakob Korherr
> Priority: Trivial
> Fix For: 2.0.0-beta-3
>
> Attachments: MYFACES-2536.patch
>
>
> With JSF 2.0 attributes converterId resp. validatorId (tags f:converter resp. f:validator) aren't required. See:
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/converter.html
> https://javaserverfaces.dev.java.net/nonav/docs/2.0/pdldocs/facelets/f/validator.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.