[GitHub] [cassandra] adelapena commented on a diff in pull request #1640: CASSANDRA-17616 4.1: Add in Circle CI an option to repeat jvm dtests with vnodes

[GitBox <gi...@apache.org>]

adelapena commented on code in PR #1640:
URL: https://github.com/apache/cassandra/pull/1640#discussion_r880304036


##########
.circleci/config-2_1.yml:
##########
@@ -1140,6 +1144,7 @@ jobs:
           target: test-jvm-dtest-some
           class: ${REPEATED_JVM_UPGRADE_DTEST_CLASS}
           methods: ${REPEATED_JVM_UPGRADE_DTEST_METHODS}
+          vnodes: "false"

Review Comment:
   Yes, it is intentional. The repeated jobs try to mimic the configuration of the regular jobs, so we can reproduce failures in them. The only job for running all JVM upgrade tests (`j8_jvm_upgrade_dtests`) doesn't use virtual nodes, so the task for repeating individual upgrade tests doesn't use them either. 
   
   If at some point we added a `j8_jvm_upgrade_dtests_vnode` task, analogous to `j8_jvm_dtests_vnode`, we would need to add a new `REPEATED_JVM_UPGRADE_DTEST_VNODES` property and pass it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org