You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "pdxrunner (GitHub)" <gi...@apache.org> on 2019/09/30 15:36:00 UTC

[GitHub] [geode] pdxrunner commented on issue #4095: GEODE-7123: Add create disk-store command option, stage-configuration

Closing this PR because the precheckin test failures show that the case of {{create disk-store --group=xxxx ...}} when there are no members in group `xxxx` is not being handled. I will re-work validation of disk-store attributes and submit a new PR
{code}
    // TODO: This condition is not correctly handling case when --groups option is specified
    if (targetMembers.isEmpty()) {
      System.out.println("DEBUG: targetMembers is empty");
     . . .
    } else {

{code}

[ Full content available at: https://github.com/apache/geode/pull/4095 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org