You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/03 20:28:29 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
ephraimbuddy opened a new pull request #11261:
URL: https://github.com/apache/airflow/pull/11261
CloudwatchTaskHandler and WasbTaskHandler were moved to their respective provider packages but their references at airflow_local_settings were not updated. This PR updates it
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-703514298
The CI and PROD Docker Images for the build are prepared in a separate "Build Image" workflow,
that you will not see in the list of checks (you will see "Wait for images" jobs instead).
You can checks the status of those images in [The workflow run](https://github.com/apache/airflow/actions/runs/289108573)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-711433395
trying it on my fork and I think I know how to fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-711436993
I pushed some fixes so it should work now. But it was rather strange (see the CC:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-706997325
I restarted the build. Let's check if the problem is transistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-711432222
Hey @ephraimbuddy - can you please rebase now? I believe it should work now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-711587149
> I pushed some fixes so it should work now. But it was rather strange (see the CC:)
I got a merge conflict in a file you didn't edit which might help in understanding this issue:
```
Auto-merging scripts/ci/selective_tests.sh
CONFLICT (content): Merge conflict in scripts/ci/selective_tests.sh
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-706608125
Hi @mik-laj, any ideas why this is failing on query count? What should I do to fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-712156196
```
git reset --soft apache/master
git add -p airflow/config_templates/airflow_local_settings.py
git commit -m "Fix incorrect cloudwatch and wasb taskhandler path in config template"
git restore .
```
This should solve your problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #11261:
URL: https://github.com/apache/airflow/pull/11261#issuecomment-711607574
I want to close this and make a new pull request. I have messed up my local branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #11261:
URL: https://github.com/apache/airflow/pull/11261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org