You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2007/12/11 19:26:52 UTC

svn commit: r603321 - /jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/cookie/DateUtils.java

Author: olegk
Date: Tue Dec 11 10:26:45 2007
New Revision: 603321

URL: http://svn.apache.org/viewvc?rev=603321&view=rev
Log:
Use SimpleDateFormat instead of DateFormat to avoid cast

Modified:
    jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/cookie/DateUtils.java

Modified: jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/cookie/DateUtils.java
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/cookie/DateUtils.java?rev=603321&r1=603320&r2=603321&view=diff
==============================================================================
--- jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/cookie/DateUtils.java (original)
+++ jakarta/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/cookie/DateUtils.java Tue Dec 11 10:26:45 2007
@@ -32,7 +32,6 @@
 package org.apache.http.impl.cookie;
 
 import java.lang.ref.SoftReference;
-import java.text.DateFormat;
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
 import java.util.Calendar;
@@ -214,12 +213,12 @@
      */
     final static class DateFormatHolder {
 
-        private static final ThreadLocal<SoftReference<Map<String, DateFormat>>> 
-            THREADLOCAL_FORMATS = new ThreadLocal<SoftReference<Map<String, DateFormat>>>() {
+        private static final ThreadLocal<SoftReference<Map<String, SimpleDateFormat>>> 
+            THREADLOCAL_FORMATS = new ThreadLocal<SoftReference<Map<String, SimpleDateFormat>>>() {
 
-            protected SoftReference<Map<String, DateFormat>> initialValue() {
-                return new SoftReference<Map<String, DateFormat>>(
-                        new HashMap<String, DateFormat>());
+            protected SoftReference<Map<String, SimpleDateFormat>> initialValue() {
+                return new SoftReference<Map<String, SimpleDateFormat>>(
+                        new HashMap<String, SimpleDateFormat>());
             }
             
         };
@@ -237,14 +236,15 @@
          *         different pattern.
          */
         public static SimpleDateFormat formatFor(String pattern) {
-            SoftReference<Map<String, DateFormat>> ref = THREADLOCAL_FORMATS.get();
-            Map<String, DateFormat> formats = ref.get();
+            SoftReference<Map<String, SimpleDateFormat>> ref = THREADLOCAL_FORMATS.get();
+            Map<String, SimpleDateFormat> formats = ref.get();
             if (formats == null) {
-                formats = new HashMap<String, DateFormat>();
-                THREADLOCAL_FORMATS.set(new SoftReference<Map<String, DateFormat>>(formats));    
+                formats = new HashMap<String, SimpleDateFormat>();
+                THREADLOCAL_FORMATS.set(
+                        new SoftReference<Map<String, SimpleDateFormat>>(formats));    
             }
 
-            SimpleDateFormat format = (SimpleDateFormat) formats.get(pattern);
+            SimpleDateFormat format = formats.get(pattern);
             if (format == null) {
                 format = new SimpleDateFormat(pattern, Locale.US);
                 format.setTimeZone(TimeZone.getTimeZone("GMT"));