You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/09/29 10:06:50 UTC
[GitHub] [tinkerpop] FlorianHockmann opened a new pull request, #1817: Disable compatibility check against base version
FlorianHockmann opened a new pull request, #1817:
URL: https://github.com/apache/tinkerpop/pull/1817
I added these checks in https://github.com/apache/tinkerpop/commit/963e625219e9c5e6a144486f72d3dc0220ebe8df because I've also added condition compilation there based on the used .NET version. `SendMessageUncompressedAsync` is only included for .NET 6 and higher.
I think it still makes sense to have a basic package validation to check for compatibility between different .NET versions which is enabled by `EnablePackageValidation` in the csproj.
However, I've also added a version compatibility check there which should ensure that we don't accidentally add breaking changes. It turned out in the meantime that this check mostly adds a burden on .NET development which is especially problematic if someone wants to modify Gremlin in general which means that all GLVs have to be modified and then runs into these compatibility warnings.
So, I don't think anymore that these checks against a baseline version (which was 3.5.2) add enough value to accept this complexity in .NET development.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1817: Disable compatibility check against base version
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1817:
URL: https://github.com/apache/tinkerpop/pull/1817#issuecomment-1262538981
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] FlorianHockmann merged pull request #1817: Disable compatibility check against base version
Posted by GitBox <gi...@apache.org>.
FlorianHockmann merged PR #1817:
URL: https://github.com/apache/tinkerpop/pull/1817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org