You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jannisko (via GitHub)" <gi...@apache.org> on 2024/06/02 14:35:06 UTC

[PR] Dag test without sensor [airflow]

jannisko opened a new pull request, #40010:
URL: https://github.com/apache/airflow/pull/40010

   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   
   ---
   
   Adds a new feature to the `airflow dags test` command and the `dag.test()` function to not execute some subset of tasks, but to mark them as success directly (via a regex on the `task_id`). This is useful for local testing of dags which contain dependencies on external systems/dagruns (e.g. through sensors), or which would overwrite some data in a central system, or which would cleanup files needed for debugging.
   I implemented this via marking tasks as success instead of using "skipping", since by default skips propagate downstream, so later tasks would not be executed.
   
   @dimberman 
   Please let me know what you think 🙂 
   
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Dag test without sensor [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #40010:
URL: https://github.com/apache/airflow/pull/40010


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Dag test without sensor [airflow]

Posted by "jannisko (via GitHub)" <gi...@apache.org>.
jannisko commented on PR #40010:
URL: https://github.com/apache/airflow/pull/40010#issuecomment-2171365121

   @potiuk @dstandish should be ready now 🙂 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Dag test without sensor [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40010:
URL: https://github.com/apache/airflow/pull/40010#issuecomment-2170323514

   Need to be rebased and conflicts resolved I am afraid :( 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Dag test without sensor [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #40010:
URL: https://github.com/apache/airflow/pull/40010#issuecomment-2167323862

   @jannisko -> I think it's a very good addition. Needs static tests fix.  Also I would love if you could add a few examples and description on how to use that flag in https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/debug.html#testing-dags-with-dag-test 
   
   Also cc: @vincbeck and https://github.com/apache/airflow/pull/40205 - the same docs should be updated for the executor and we should also have the `--use-executor` flag in `airflow dags test` command. Those two - together with some discussions we had with Nielsen might make our `dag.test()` and `airflow dags test` command far more useful for a number of cases, so I think we should double down on describing well what are the use cases and how users can use both `dags.test()` and `airflow dags test` for various testing scenarios.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Dag test without sensor [airflow]

Posted by "jannisko (via GitHub)" <gi...@apache.org>.
jannisko commented on PR #40010:
URL: https://github.com/apache/airflow/pull/40010#issuecomment-2170532012

   Whoops I think I guess I messed up my rebase, sorry to all the reviewers I just pinged 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Dag test without sensor [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #40010:
URL: https://github.com/apache/airflow/pull/40010#issuecomment-2171445556

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org