You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/03/31 05:53:11 UTC

[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/17492

    [SPARK-19641][SQL] JSON schema inference in DROPMALFORMED mode produces incorrect schema for non-array/object JSONs

    ## What changes were proposed in this pull request?
    
    Currently, when we infer the types for vaild JSON strings but object or array, we are producing empty schemas regardless of parse modes as below:
    
    ```scala
    scala> spark.read.option("mode", "DROPMALFORMED").json(Seq("""{"a": 1}""", """"a"""").toDS).printSchema()
    root
    
    
    scala> spark.read.option("mode", "FAILFAST").json(Seq("""{"a": 1}""", """"a"""").toDS).printSchema()
    root
    ```
    
    This PR proposes to handle parse modes in type inference.
    
    After this PR,
    
    ```scala
    
    scala> spark.read.option("mode", "DROPMALFORMED").json(Seq("""{"a": 1}""", """"a"""").toDS).printSchema()
    root
     |-- a: long (nullable = true)
    ```
    
    ```
    scala> spark.read.option("mode", "FAILFAST").json(Seq("""{"a": 1}""", """"a"""").toDS).printSchema()
    java.lang.RuntimeException: Failed to infer a common schema. Struct types are expected but string was found.
    ```
    
    This PR is based on https://github.com/NathanHowell/spark/commit/e233fd03346a73b3b447fa4c24f3b12c8b2e53ae and I and @NathanHowell talked about this in https://issues.apache.org/jira/browse/SPARK-19641
    
    
    ## How was this patch tested?
    
    Unit tests in `JsonSuite` for both `DROPMALFORMED` and `FAILFAST` modes.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-19641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17492
    
----
commit dc24522502b3f7816d539da2c8efb09a3515bb70
Author: hyukjinkwon <gu...@gmail.com>
Date:   2017-03-31T04:52:27Z

    JSON schema inference in DROPMALFORMED mode produces incorrect schema

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    **[Test build #75421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75421/testReport)** for PR 17492 at commit [`dc24522`](https://github.com/apache/spark/commit/dc24522502b3f7816d539da2c8efb09a3515bb70).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17492#discussion_r109307548
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala ---
    @@ -1041,7 +1041,6 @@ class JsonSuite extends QueryTest with SharedSQLContext with TestJsonData {
           spark.read
             .option("mode", "FAILFAST")
             .json(corruptRecords)
    -        .collect()
    --- End diff --
    
    I intended to remove this line to make sure it happens in schrma inference. I think this is not related with the change here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    cc @NathanHowell and @cloud-fan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75421/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    thanks, merging to master!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17492#discussion_r109307156
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala ---
    @@ -202,41 +206,54 @@ private[sql] object JsonInferSchema {
     
       private def withCorruptField(
           struct: StructType,
    -      columnNameOfCorruptRecords: String): StructType = {
    -    if (!struct.fieldNames.contains(columnNameOfCorruptRecords)) {
    -      // If this given struct does not have a column used for corrupt records,
    -      // add this field.
    -      val newFields: Array[StructField] =
    -        StructField(columnNameOfCorruptRecords, StringType, nullable = true) +: struct.fields
    -      // Note: other code relies on this sorting for correctness, so don't remove it!
    -      java.util.Arrays.sort(newFields, structFieldComparator)
    -      StructType(newFields)
    -    } else {
    -      // Otherwise, just return this struct.
    +      other: DataType,
    +      columnNameOfCorruptRecords: String,
    +      parseMode: ParseMode) = parseMode match {
    +    case PermissiveMode =>
    +      // If we see any other data type at the root level, we get records that cannot be
    +      // parsed. So, we use the struct as the data type and add the corrupt field to the schema.
    +      if (!struct.fieldNames.contains(columnNameOfCorruptRecords)) {
    +        // If this given struct does not have a column used for corrupt records,
    +        // add this field.
    +        val newFields: Array[StructField] =
    +          StructField(columnNameOfCorruptRecords, StringType, nullable = true) +: struct.fields
    +        // Note: other code relies on this sorting for correctness, so don't remove it!
    +        java.util.Arrays.sort(newFields, structFieldComparator)
    +        StructType(newFields)
    +      } else {
    +        // Otherwise, just return this struct.
    +        struct
    +      }
    +
    +    case DropMalformedMode =>
    +      // If corrupt record handling is disabled we retain the valid schema and discard the other.
           struct
    -    }
    +
    +    case FailFastMode =>
    --- End diff --
    
    When will we hit this branch? Seems never?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17492#discussion_r109304123
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala ---
    @@ -217,26 +221,43 @@ private[sql] object JsonInferSchema {
         }
       }
     
    +  private def withParseMode(
    --- End diff --
    
    Sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17492#discussion_r109286081
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala ---
    @@ -217,26 +221,43 @@ private[sql] object JsonInferSchema {
         }
       }
     
    +  private def withParseMode(
    --- End diff --
    
    shall we embed this method in `withCorruptField`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75425/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17492#discussion_r109307493
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala ---
    @@ -1903,9 +1932,8 @@ class JsonSuite extends QueryTest with SharedSQLContext with TestJsonData {
               .option("wholeFile", true)
               .option("mode", "FAILFAST")
               .json(path)
    -          .collect()
           }
    -      assert(exceptionOne.getMessage.contains("Failed to parse a value"))
    +      assert(exceptionOne.getMessage.contains("Failed to infer a common schema"))
    --- End diff --
    
    Up to my knowledge, this test case throws an exception when actually parsing the data before. Now, I intended to check the exception in schema inference as it looks parsing data case is covered below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    **[Test build #75458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75458/testReport)** for PR 17492 at commit [`1c1c054`](https://github.com/apache/spark/commit/1c1c0548e90a8e12f4b51943e3fbeed57e0e57ba).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    **[Test build #75425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75425/testReport)** for PR 17492 at commit [`dc24522`](https://github.com/apache/spark/commit/dc24522502b3f7816d539da2c8efb09a3515bb70).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17492#discussion_r109307361
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala ---
    @@ -202,41 +206,54 @@ private[sql] object JsonInferSchema {
     
       private def withCorruptField(
           struct: StructType,
    -      columnNameOfCorruptRecords: String): StructType = {
    -    if (!struct.fieldNames.contains(columnNameOfCorruptRecords)) {
    -      // If this given struct does not have a column used for corrupt records,
    -      // add this field.
    -      val newFields: Array[StructField] =
    -        StructField(columnNameOfCorruptRecords, StringType, nullable = true) +: struct.fields
    -      // Note: other code relies on this sorting for correctness, so don't remove it!
    -      java.util.Arrays.sort(newFields, structFieldComparator)
    -      StructType(newFields)
    -    } else {
    -      // Otherwise, just return this struct.
    +      other: DataType,
    +      columnNameOfCorruptRecords: String,
    +      parseMode: ParseMode) = parseMode match {
    +    case PermissiveMode =>
    +      // If we see any other data type at the root level, we get records that cannot be
    +      // parsed. So, we use the struct as the data type and add the corrupt field to the schema.
    +      if (!struct.fieldNames.contains(columnNameOfCorruptRecords)) {
    +        // If this given struct does not have a column used for corrupt records,
    +        // add this field.
    +        val newFields: Array[StructField] =
    +          StructField(columnNameOfCorruptRecords, StringType, nullable = true) +: struct.fields
    +        // Note: other code relies on this sorting for correctness, so don't remove it!
    +        java.util.Arrays.sort(newFields, structFieldComparator)
    +        StructType(newFields)
    +      } else {
    +        // Otherwise, just return this struct.
    +        struct
    +      }
    +
    +    case DropMalformedMode =>
    +      // If corrupt record handling is disabled we retain the valid schema and discard the other.
           struct
    -    }
    +
    +    case FailFastMode =>
    --- End diff --
    
    It looks possible to run this line. I added a test in 1936L. In more details, if the json is a valid one but not a object of an areay of object, it will infer not `StructType` per record. If one of the types is not a struct type and failfast mode is enabled, we will hit this line.
    
    I am outside now. I will double check when I get to my computer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75458/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17492: [SPARK-19641][SQL] JSON schema inference in DROPM...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/17492


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    **[Test build #75458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75458/testReport)** for PR 17492 at commit [`1c1c054`](https://github.com/apache/spark/commit/1c1c0548e90a8e12f4b51943e3fbeed57e0e57ba).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    **[Test build #75425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75425/testReport)** for PR 17492 at commit [`dc24522`](https://github.com/apache/spark/commit/dc24522502b3f7816d539da2c8efb09a3515bb70).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17492: [SPARK-19641][SQL] JSON schema inference in DROPMALFORME...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/17492
  
    Thank you @cloud-fan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org