You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/04/23 17:24:19 UTC

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #4988: GEODE-7851: Add slf4j implementation to Pulse

pivotal-jbarrett commented on a change in pull request #4988:
URL: https://github.com/apache/geode/pull/4988#discussion_r413983675



##########
File path: geode-pulse/build.gradle
##########
@@ -95,6 +94,9 @@ dependencies {
 
   // added only to ensure common version with other geode modules
   runtimeOnly('org.slf4j:slf4j-api')
+  runtimeOnly('org.apache.logging.log4j:log4j-slf4j-impl') {
+    exclude module: 'slf4j-api'

Review comment:
       Why are we including the slf4j above and excluding it below. If impl is runtime only then all its deps will also be runtime only. We should just collapse this into a single include.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org