You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/06 09:57:58 UTC
[GitHub] [camel-k] christophd opened a new pull request, #3879: fix(#3800): Add proper kamel linux binary on MacOS
christophd opened a new pull request, #3879:
URL: https://github.com/apache/camel-k/pull/3879
Try to fix Makefile syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
gansheer commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339116328
This fix definitely works better on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] gansheer commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
gansheer commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339130850
> > @gansheer yes, but now it is not working on MacOS anymore dizzy_face I have to investigate
>
> We could also revert and find a better solution. The fix was done only for MacOS.
That seems to be a sensible approach since the main branch no longer build images on non MacOS Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339203803
Thanks for the fast fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd merged pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
oscerd merged PR #3879:
URL: https://github.com/apache/camel-k/pull/3879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339124620
@gansheer yes, but now it is not working on MacOS anymore 😵 I have to investigate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339150502
@oscerd @gansheer now I am sorted. I did not know that Makefile is so fuzzy about tabs vs. spaces
It should be fixed now (at least it is working on my MacOS again). Let's see what the CI jobs do report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339202902
I think it's fine if we merge. This stuff is only for building, so no need to wait for common/install and knative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] christophd commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339061834
@oscerd sorry, I have screwed up the Makefile. Let's see if this is better and the CI jobs are happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3879: fix(#3800): Add proper kamel linux binary on MacOS
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3879:
URL: https://github.com/apache/camel-k/pull/3879#issuecomment-1339125828
> @gansheer yes, but now it is not working on MacOS anymore dizzy_face I have to investigate
We could also revert and find a better solution. The fix was done only for MacOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org