[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #9656: Fix server request sent delay to be non-negative

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #9656:
URL: https://github.com/apache/pinot/pull/9656#discussion_r1005017993


##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java:
##########
@@ -201,7 +201,7 @@ void sendRequestWithoutLocking(String rawTableName, AsyncQueryResponse asyncQuer
         ServerRoutingInstance serverRoutingInstance, byte[] requestBytes) {
       long startTimeMs = System.currentTimeMillis();
       _channel.writeAndFlush(Unpooled.wrappedBuffer(requestBytes)).addListener(f -> {
-        long requestSentLatencyMs = System.currentTimeMillis() - startTimeMs;
+        int requestSentLatencyMs = (int) (System.currentTimeMillis() - startTimeMs);

Review Comment:
   I feel it is more readable this way (use `int` to represent delta). Don't think there will be performance difference after the code is compiled



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org