You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2017/01/19 15:01:19 UTC

[GitHub] thrift pull request #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1161#discussion_r96876704
  
    --- Diff: compiler/cpp/CMakeLists.txt ---
    @@ -101,9 +102,6 @@ THRIFT_ADD_COMPILER(xml     "Enable compiler for XML" ON)
     # we also add the current binary directory for generated files
     include_directories(${CMAKE_CURRENT_BINARY_DIR} src)
     
    -if(NOT ${WITH_PLUGIN})
    --- End diff --
    
    This will break the thrift compiler plug-in module support.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---