[GitHub] mike-tutkowski opened a new pull request #2500: Restrict the number of managed clustered file systems per compute cluster

[GitBox <gi...@apache.org>]

mike-tutkowski opened a new pull request #2500: Restrict the number of managed clustered file systems per compute cluster
URL: https://github.com/apache/cloudstack/pull/2500
 
 
   ## Description
   For managed storage, each time a virtual disk is created, a new SR is created (when on XenServer) or a new datastore is created (when on VMware).
   
   XenServer 6.5 can support around 500 - 600 SRs per compute cluster while VMware can support 256 datastores per compute cluster.
   
   CloudStack has never had the ability to limit the number of SRs or datastores it creates when using managed storage (the admin has needed to pay attention to this via some other process outside of CloudStack).
   
   This code aims to address the main use cases in CloudStack that can create SRs or datastores and fails the applicable operations if no more SRs or datastores can be created (based on a new cluster-scoped setting that specifies how many SRs or datastores the admin is OK with CloudStack creating).
   
   https://issues.apache.org/jira/browse/CLOUDSTACK-10336
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   
   This code deals with two main situations:
   
   * When creating a new VM that requires managed storage
   * When attaching a new data disk that requires managed storage to a VM
   
   In each of those situations, the code checks a new cluster-scoped setting (can be set by the admin) to see if the new SR or datastore can be created.
   
   I ran through a substantial number of manual tests to confirm that the applicable operations succeed or fail depending on if a new SR or datastore can be created.
   
   ## Checklist:
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [ ] I have added tests to cover my changes.
   - [ ] All new and existing tests passed.
   
   <!-- The following will kick a packaging job, remove it as applicable -->
   @blueorangutan package
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services