You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 18:11:58 UTC
[GitHub] [phoenix] gokceni opened a new pull request #993: Phoenix 6219
gokceni opened a new pull request #993:
URL: https://github.com/apache/phoenix/pull/993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535456399
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##########
@@ -67,19 +68,32 @@
private final boolean localIndex;
private final boolean useViewIndex;
private final String tableDDLOptions;
+ private final String indexDDLOptions;
private final boolean mutable;
private final boolean useSnapshot;
+
+ private static final Logger LOGGER = LoggerFactory.getLogger(IndexExtendedIT.class);
public IndexExtendedIT( boolean mutable, boolean localIndex, boolean useViewIndex, boolean useSnapshot) {
Review comment:
extend this function to take a new argument useSingleCellIndex ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535461995
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##########
@@ -195,7 +207,7 @@ public static void serializeServerMaintainedIndexes(PTable dataTable, ImmutableB
if (onlyLocalIndexes) {
if (!dataTable.isTransactional()
|| !dataTable.getTransactionProvider().getTransactionProvider().isUnsupported(Feature.MAINTAIN_LOCAL_INDEX_ON_SERVER)) {
- indexesItr = maintainedLocalIndexes(indexes.iterator());
+ indexesItr = maintainedLocalOrGlobalIndexesWithoutMatchingStorageScheme(dataTable, indexes.iterator());
Review comment:
Shouldn't this still be maintainedLocalIndexes since it is called inside if (onlyLocalIndexex)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535456399
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##########
@@ -67,19 +68,32 @@
private final boolean localIndex;
private final boolean useViewIndex;
private final String tableDDLOptions;
+ private final String indexDDLOptions;
private final boolean mutable;
private final boolean useSnapshot;
+
+ private static final Logger LOGGER = LoggerFactory.getLogger(IndexExtendedIT.class);
public IndexExtendedIT( boolean mutable, boolean localIndex, boolean useViewIndex, boolean useSnapshot) {
Review comment:
extend this function to take a new argument
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni commented on pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni commented on pull request #993:
URL: https://github.com/apache/phoenix/pull/993#issuecomment-736728342
@kadirozde @swaroopak @tkhurana @gjacoby126
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535709164
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##########
@@ -287,7 +301,7 @@ public void testBuildDisabledIndex() throws Exception {
Table hIndexTable = conn.unwrap(PhoenixConnection.class).getQueryServices().getTable(Bytes.toBytes(physicalTableNameOfIndex));
stmt.execute(
- String.format("CREATE INDEX %s ON %s (UPPER(NAME, 'en_US')) ", indexName,
+ String.format("CREATE INDEX %s ON %s (UPPER(NAME, 'en_US')) " + this.indexDDLOptions, indexName,
Review comment:
ditto, String.format vs concatenation
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/SingleCellIndexIT.java
##########
@@ -303,6 +303,37 @@ public void testTenantViewIndexes() throws Exception {
}
}
+ @Test
+ public void testUpsertSelect() throws Exception {
+ String tableName = generateUniqueName();
+ String idxName = "IDX_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl(), testProps)) {
+ conn.setAutoCommit(true);
+ createTableAndIndex(conn, tableName, idxName, null, true, 2);
+ assertMetadata(conn, ONE_CELL_PER_COLUMN, NON_ENCODED_QUALIFIERS, tableName);
+ assertMetadata(conn, SINGLE_CELL_ARRAY_WITH_OFFSETS, TWO_BYTE_QUALIFIERS, idxName);
+
+ // this delete will be issued at a timestamp later than the above timestamp of the index table
+ conn.createStatement().execute("delete from " + tableName + " where pk1 = 'PK1'");
+ conn.commit();
+ String
+ sql =
+ "UPSERT /*+ NO_INDEX */ INTO " + idxName + "(\":PK1\",\":INT_PK\",\"0:V1\",\"0:V2\",\"0:V4\") SELECT /*+ NO_INDEX */ PK1,INT_PK, V1, V2,V4 FROM "
Review comment:
Does a NO_INDEX hint in an upsert clause do anything?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##########
@@ -139,7 +153,7 @@ public void testMutableIndexWithUpdates() throws Exception {
IndexToolIT.upsertRow(stmt1, id++);
conn.commit();
- stmt.execute(String.format("CREATE " + (localIndex ? "LOCAL" : "") + " INDEX %s ON %s (UPPER(NAME, 'en_US')) ASYNC ", indexTableName,dataTableFullName));
+ stmt.execute(String.format("CREATE " + (localIndex ? "LOCAL" : "") + " INDEX %s ON %s (UPPER(NAME, 'en_US')) ASYNC " + this.indexDDLOptions, indexTableName,dataTableFullName));
Review comment:
nit: can use String.format parameter rather than concatenating indexDDLOptions
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/SingleCellIndexIT.java
##########
@@ -303,6 +303,37 @@ public void testTenantViewIndexes() throws Exception {
}
}
+ @Test
+ public void testUpsertSelect() throws Exception {
+ String tableName = generateUniqueName();
+ String idxName = "IDX_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl(), testProps)) {
+ conn.setAutoCommit(true);
+ createTableAndIndex(conn, tableName, idxName, null, true, 2);
+ assertMetadata(conn, ONE_CELL_PER_COLUMN, NON_ENCODED_QUALIFIERS, tableName);
+ assertMetadata(conn, SINGLE_CELL_ARRAY_WITH_OFFSETS, TWO_BYTE_QUALIFIERS, idxName);
+
+ // this delete will be issued at a timestamp later than the above timestamp of the index table
+ conn.createStatement().execute("delete from " + tableName + " where pk1 = 'PK1'");
+ conn.commit();
+ String
+ sql =
+ "UPSERT /*+ NO_INDEX */ INTO " + idxName + "(\":PK1\",\":INT_PK\",\"0:V1\",\"0:V2\",\"0:V4\") SELECT /*+ NO_INDEX */ PK1,INT_PK, V1, V2,V4 FROM "
Review comment:
nit: overly long line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535777422
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##########
@@ -195,7 +207,7 @@ public static void serializeServerMaintainedIndexes(PTable dataTable, ImmutableB
if (onlyLocalIndexes) {
if (!dataTable.isTransactional()
|| !dataTable.getTransactionProvider().getTransactionProvider().isUnsupported(Feature.MAINTAIN_LOCAL_INDEX_ON_SERVER)) {
- indexesItr = maintainedLocalIndexes(indexes.iterator());
+ indexesItr = maintainedLocalOrGlobalIndexesWithoutMatchingStorageScheme(dataTable, indexes.iterator());
Review comment:
Unfortunately onlyLocalIndexes variable name is misleading. So it is immutableIndexes or transactional indexes
boolean onlyLocalIndexes = dataTable.isImmutableRows() || dataTable.isTransactional();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni commented on pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni commented on pull request #993:
URL: https://github.com/apache/phoenix/pull/993#issuecomment-741132253
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535776156
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -326,10 +326,10 @@ private void repairIndexRows(byte[] indexRowKey, long ts, List<Cell> row) throws
buildIndexScan.setAttribute(BaseScannerRegionObserver.REBUILD_INDEXES, TRUE_BYTES);
buildIndexScan.setAttribute(BaseScannerRegionObserver.SKIP_REGION_BOUNDARY_CHECK, Bytes.toBytes(true));
// Scan only columns included in the index table plus the empty column
Review comment:
Yes, it is. The difference is that in getAllColumns, you get index cols. The getAllColumnsForDataTable, you get the mapping columns in data table. For example: in index there is Col1 but in hbase it is in a cell with others with column qualifier:1. But in data table it is in its own cell with col qualifier Col1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni closed pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni closed pull request #993:
URL: https://github.com/apache/phoenix/pull/993
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #993:
URL: https://github.com/apache/phoenix/pull/993#issuecomment-738577256
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x-PHOENIX-5923 Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 53s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | compile | 0m 56s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | checkstyle | 1m 7s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | javadoc | 0m 43s | 4.x-PHOENIX-5923 passed |
| +0 :ok: | spotbugs | 2m 56s | phoenix-core in 4.x-PHOENIX-5923 has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 54s | the patch passed |
| +1 :green_heart: | javac | 0m 54s | the patch passed |
| -1 :x: | checkstyle | 1m 7s | phoenix-core: The patch generated 45 new + 1488 unchanged - 26 fixed = 1533 total (was 1514) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed |
| -1 :x: | spotbugs | 3m 7s | phoenix-core generated 1 new + 944 unchanged - 2 fixed = 945 total (was 946) |
||| _ Other Tests _ |
| -1 :x: | unit | 186m 42s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 41s | The patch generated 1 ASF License warnings. |
| | | 218m 47s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | index must be non-null but is marked as nullable At IndexMaintainer.java:is marked as nullable At IndexMaintainer.java:[line 188] |
| Failed junit tests | phoenix.end2end.RebuildIndexConnectionPropsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/993 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 518799a48a85 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x-PHOENIX-5923 / a3df4dc |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 3482 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535778228
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/SingleCellIndexIT.java
##########
@@ -303,6 +303,37 @@ public void testTenantViewIndexes() throws Exception {
}
}
+ @Test
+ public void testUpsertSelect() throws Exception {
+ String tableName = generateUniqueName();
+ String idxName = "IDX_" + generateUniqueName();
+
+ try (Connection conn = DriverManager.getConnection(getUrl(), testProps)) {
+ conn.setAutoCommit(true);
+ createTableAndIndex(conn, tableName, idxName, null, true, 2);
+ assertMetadata(conn, ONE_CELL_PER_COLUMN, NON_ENCODED_QUALIFIERS, tableName);
+ assertMetadata(conn, SINGLE_CELL_ARRAY_WITH_OFFSETS, TWO_BYTE_QUALIFIERS, idxName);
+
+ // this delete will be issued at a timestamp later than the above timestamp of the index table
+ conn.createStatement().execute("delete from " + tableName + " where pk1 = 'PK1'");
+ conn.commit();
+ String
+ sql =
+ "UPSERT /*+ NO_INDEX */ INTO " + idxName + "(\":PK1\",\":INT_PK\",\"0:V1\",\"0:V2\",\"0:V4\") SELECT /*+ NO_INDEX */ PK1,INT_PK, V1, V2,V4 FROM "
Review comment:
I copy pasted this from PostIndexDDLCompilerTest. I think it is valid but not mean much since this is already the index. Let me remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535460251
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -326,10 +326,10 @@ private void repairIndexRows(byte[] indexRowKey, long ts, List<Cell> row) throws
buildIndexScan.setAttribute(BaseScannerRegionObserver.REBUILD_INDEXES, TRUE_BYTES);
buildIndexScan.setAttribute(BaseScannerRegionObserver.SKIP_REGION_BOUNDARY_CHECK, Bytes.toBytes(true));
// Scan only columns included in the index table plus the empty column
Review comment:
Is this comment still applicable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #993:
URL: https://github.com/apache/phoenix/pull/993#issuecomment-740393206
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 12s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ 4.x-PHOENIX-5923 Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 48s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | compile | 0m 56s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | checkstyle | 1m 7s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | javadoc | 0m 42s | 4.x-PHOENIX-5923 passed |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in 4.x-PHOENIX-5923 has 946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 13s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| -1 :x: | checkstyle | 1m 9s | phoenix-core: The patch generated 38 new + 1496 unchanged - 19 fixed = 1534 total (was 1515) |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed |
| -1 :x: | spotbugs | 3m 8s | phoenix-core generated 1 new + 944 unchanged - 2 fixed = 945 total (was 946) |
||| _ Other Tests _ |
| -1 :x: | unit | 192m 33s | phoenix-core in the patch failed. |
| -1 :x: | asflicense | 0m 41s | The patch generated 1 ASF License warnings. |
| | | 224m 45s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | index must be non-null but is marked as nullable At IndexMaintainer.java:is marked as nullable At IndexMaintainer.java:[line 188] |
| Failed junit tests | TEST-[RangeScanIT_0] |
| | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/993 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux cd2a74a09081 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x-PHOENIX-5923 / a3df4dc |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 6250 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-993/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] tkhurana commented on a change in pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
tkhurana commented on a change in pull request #993:
URL: https://github.com/apache/phoenix/pull/993#discussion_r535452125
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java
##########
@@ -67,19 +68,32 @@
private final boolean localIndex;
private final boolean useViewIndex;
private final String tableDDLOptions;
+ private final String indexDDLOptions;
private final boolean mutable;
private final boolean useSnapshot;
+
+ private static final Logger LOGGER = LoggerFactory.getLogger(IndexExtendedIT.class);
Review comment:
This object is not being used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gokceni commented on pull request #993: Phoenix 6219 GlobalIndexChecker doesn't work for SingleCell indexes
Posted by GitBox <gi...@apache.org>.
gokceni commented on pull request #993:
URL: https://github.com/apache/phoenix/pull/993#issuecomment-740311663
Thanks @gjacoby126 for the review! I added one more test to SingleCellIndexIT called testMultipleColumnFamilies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org