[GitHub] [hbase] Apache9 commented on a diff in pull request #4620: HBASE-27199 Clean up error-prone findings in hbase-asyncfs

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4620:
URL: https://github.com/apache/hbase/pull/4620#discussion_r921746890


##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:
##########
@@ -546,8 +549,9 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
             if (requestedQopContainsPrivacy()) {
               cipherOptions = getCipherOptions();
             }
-            sendSaslMessage(ctx, response, cipherOptions);
+            ChannelFuture sendFuture = sendSaslMessage(ctx, response, cipherOptions);
             ctx.flush();
+            sendFuture.get();

Review Comment:
   This is a no no, we should not do any blocking operations in netty handler...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org