You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by kasjain <gi...@git.apache.org> on 2016/04/13 12:32:49 UTC
[GitHub] spark pull request: [SPARK-14344][SQL] Not creating meta files whe...
GitHub user kasjain opened a pull request:
https://github.com/apache/spark/pull/12355
[SPARK-14344][SQL] Not creating meta files when summary-metadata property is false in parquet
## What changes were proposed in this pull request?
This change fixes a bug related to the property "parquet.enable.summary-metadata". Currently, the property's value is not considered before writing the metaData (_metadata and _common-metadata files) in the "saveAsParquetFile" code-flow. Hence making this property false still created the meta files.
## How was this patch tested?
Integration tests and manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kasjain/spark branch-1.3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12355
----
commit 4eb23fc05b6875463a3aab748039e3532bb6e32d
Author: Kashish Jain <ka...@guavus.com>
Date: 2016-04-13T10:04:26Z
[SPARK-14344][SQL] Not creating meta files when summary-metadata property is false in parquet
commit 085a5621bf138388efd5c29f00bd6dabd26f96d7
Author: Kashish Jain <ka...@guavus.com>
Date: 2016-04-13T10:04:26Z
[SPARK-14344][SQL] Not creating meta files when summary-metadata property is false in parquet
commit 0421f4f7ee9c65d2854d9fe5e3a5cf19f761c304
Author: Kashish Jain <ka...@guavus.com>
Date: 2016-04-13T10:28:53Z
[SPARK-14344][SQL] Minor typo fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14344][SQL] Not creating meta files whe...
Posted by kasjain <gi...@git.apache.org>.
Github user kasjain commented on the pull request:
https://github.com/apache/spark/pull/12355#issuecomment-209359864
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12355: [SPARK-14344][SQL] Not creating meta files when summary-...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/12355
It seems working fine now. Therefore, it seems not a problem.
```scala
test("SPARK-14344 - write metadata")
withSQLConf(ParquetOutputFormat.ENABLE_JOB_SUMMARY -> "true") {
withTempPath { dir =>
val path = s"${dir.getCanonicalPath}/part-r-0.parquet"
spark.range(10).write.parquet(path)
val compressedFiles = new File(path).listFiles()
assert(compressedFiles.exists(_.getName.endsWith("_common_metadata")))
}
}
withSQLConf(ParquetOutputFormat.ENABLE_JOB_SUMMARY -> "false") {
withTempPath { dir =>
val path = s"${dir.getCanonicalPath}/part-r-0.parquet"
spark.range(10).write.parquet(path)
val compressedFiles = new File(path).listFiles()
assert(!compressedFiles.exists(_.getName.endsWith("_common_metadata")))
}
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-14344][SQL] Not creating meta files whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12355#issuecomment-209360750
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #12355: [SPARK-14344][SQL] Not creating meta files when s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12355: [SPARK-14344][SQL] Not creating meta files when summary-...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/12355
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #12355: [SPARK-14344][SQL] Not creating meta files when summary-...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/12355
It seems this is fixed in https://github.com/apache/spark/pull/13455? Could you confirm this please @kasjain ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org