You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/06 21:30:51 UTC

[GitHub] [pulsar] KannarFr commented on a change in pull request #7523: [Issue 5720][authz] - add topics authz granularity

KannarFr commented on a change in pull request #7523:
URL: https://github.com/apache/pulsar/pull/7523#discussion_r627777823



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java
##########
@@ -126,14 +128,17 @@ protected void internalLookupTopicAsync(TopicName topicName, boolean authoritati
 
     private void validateAdminAndClientPermission(TopicName topic) throws RestException, Exception {
         try {
-            validateAdminAccessForTenant(topic.getTenant());
+            validateTopicOperation(topic, TopicOperation.LOOKUP);
         } catch (Exception e) {
-            checkConnect(topic);
+            // unknown error marked as internal server error
+            log.warn("Unexpected error while authorizing TopicOperation.LOOKUP. topic={}, role={}. Error: {}",

Review comment:
       Dropped in 596d85f418efe40b50114da3d4a6d126cb796882.
   
   PR rebased due to a recent conflict.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org