You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by cmccabe <gi...@git.apache.org> on 2017/06/06 21:27:37 UTC

[GitHub] kafka pull request #3250: KAFKA-5394. KafkaAdminClient#timeoutCallsInFlight ...

GitHub user cmccabe opened a pull request:

    https://github.com/apache/kafka/pull/3250

    KAFKA-5394. KafkaAdminClient#timeoutCallsInFlight does not work as ex…

    …pected
    
    * Rename KafkaClient#close to KafkaClient#forget to emphasize that it forgets the requests on a given connection.
    * Create KafkaClient#disconnect to tear down a connection and deliver disconnects to all the requests on it.
    * AdminClient.java: fix mismatched braces in JavaDoc.
    * Make the AdminClientConfig constructor visible for testing.
    * KafkaAdminClient: add TimeoutProcessorFactory to make the TimeoutProcessor swappable for testing.
    * Make TimeoutProcessor a static class rather than an inner class.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cmccabe/kafka KAFKA-5394

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3250.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3250
    
----
commit fb3905a69bad5e4c37c28c64fdfb2ab786f7b4ed
Author: Colin P. Mccabe <cm...@confluent.io>
Date:   2017-06-06T21:19:31Z

    KAFKA-5394. KafkaAdminClient#timeoutCallsInFlight does not work as expected
    
    * Rename KafkaClient#close to KafkaClient#forget to emphasize that it forgets the requests on a given connection.
    * Create KafkaClient#disconnect to tear down a connection and deliver disconnects to all the requests on it.
    * AdminClient.java: fix mismatched braces in JavaDoc.
    * Make the AdminClientConfig constructor visible for testing.
    * KafkaAdminClient: add TimeoutProcessorFactory to make the TimeoutProcessor swappable for testing.
    * Make TimeoutProcessor a static class rather than an inner class.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3250: KAFKA-5394. KafkaAdminClient#timeoutCallsInFlight ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3250


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---