You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/08/29 20:18:07 UTC
[jira] [Created] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Jonathan Ellis created CASSANDRA-4584:
-----------------------------------------
Summary: Add CQL syntax to enable request tracing
Key: CASSANDRA-4584
URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
Project: Cassandra
Issue Type: Sub-task
Affects Versions: 1.2.0 beta 1
Reporter: Jonathan Ellis
Assignee: Sylvain Lebresne
Fix For: 1.2.0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468833#comment-13468833 ]
Aleksey Yeschenko edited comment on CASSANDRA-4584 at 10/4/12 8:04 AM:
-----------------------------------------------------------------------
I'm putting this on hold for now. I won't bother with formatting tracing events output until there is reasonable data to work with.
Feel free to apply/commit the patch though, since this might help the person who will be working on fixing the tracing.
Edit: this patch depends on https://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/issues/detail?id=26 to work. It's not yet in any published cassandra-dbapi2 release. This needs to happen first - DON'T commit the patch until then.
was (Author: iamaleksey):
I'm putting this on hold for now. I won't bother with formatting tracing events output until there is reasonable data to work with.
Feel free to apply/commit the patch though, since this might help the person who will be working on fixing the tracing.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-4584:
-----------------------------------------
Assignee: Aleksey Yeschenko (was: David Alves)
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4584:
--------------------------------------
Reviewer: brandon.williams (was: slebresne)
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458806#comment-13458806 ]
David Alves commented on CASSANDRA-4584:
----------------------------------------
moving cqlsh to another issue makes this one pretty much done (before review that is)
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458458#comment-13458458 ]
David Alves commented on CASSANDRA-4584:
----------------------------------------
Note: patch needs an updated version of lib/cql-internal-only-1.2.0.zip that can be built with the patch in http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/issues/detail?id=24
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458464#comment-13458464 ]
Sylvain Lebresne commented on CASSANDRA-4584:
---------------------------------------------
Have only looked very superficially to the patch but since every statement can be traced, we should call enableTracingIfRequested in a generic place (in QueryProcessor.processStatement typically) rather that in random methods in the specific statements. In particular, it's only called in Modification, Select and Truncate statements, which doesn't cover all the statements.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4584:
----------------------------------------
Summary: Add cqlsh syntax to enable request tracing (was: Add CQL syntax to enable request tracing)
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4584:
--------------------------------------
Reviewer: slebresne (was: xedin)
Fix Version/s: (was: 1.2.0)
1.2.0 beta 2
Labels: cql3 (was: )
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-4584.
---------------------------------------
Resolution: Fixed
looks like a general problem w/ inet on windows: CASSANDRA-4801
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468833#comment-13468833 ]
Aleksey Yeschenko commented on CASSANDRA-4584:
----------------------------------------------
I'm putting this on hold for now. I won't bother with formatting tracing events output until there is reasonable data to work with.
Feel free to apply/commit the patch though, since this might help the person who will be working on fixing the tracing.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458746#comment-13458746 ]
David Alves commented on CASSANDRA-4584:
----------------------------------------
bq. But honestly I'm not sure there is a point in disallowing tracing for some query, especially since that's more work than doing it for all queries. Besides, for any query it could be interesting to know how long it took to parse it, to validate it and to execute it.
I see no reason why tracing should not be enabled for schema querying/altering statements, but since "trace" is keyword we only know wether to trace *after* we parse the query, which will make it difficult to track parse times.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4584:
-----------------------------------------
Attachment: CASSANDRA-4584-INCOMPLETE.txt
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4584:
-----------------------------------------
Attachment: cql-internal-only-1.2.4584.zip
Don't commit this.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt, cql-internal-only-1.2.4584.zip
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves reassigned CASSANDRA-4584:
--------------------------------------
Assignee: David Alves (was: Sylvain Lebresne)
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458471#comment-13458471 ]
David Alves commented on CASSANDRA-4584:
----------------------------------------
Allowing tracing only on Modification/Select and Truncate statements was deliberate as it mimics what is done in the thrift interface (cf/keyspace methods do not enable tracing), but I hadn't thought of placing it in QueryProcessor, maybe it makes more sense there.
Still you raise a point should schema altering methods be traced?
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468812#comment-13468812 ]
Aleksey Yeschenko commented on CASSANDRA-4584:
----------------------------------------------
Try tracing CREATE KEYSPACE or CREATE TABLE - there is too much information, all in inconsistent formats. No idea how to display that properly.
Or trace INSERT or SELECT - there isn't as much output, but it's pretty useless and inconsistent.
Also, unrelated to that: requesting tracing info immediately after the query doesn't show all the events. Tracing is async. Making is synchronous is probably a bad idea, so some artificial delay needs to be introduced.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468827#comment-13468827 ]
Aleksey Yeschenko commented on CASSANDRA-4584:
----------------------------------------------
Also there is no way to calculate how much time each step has taken, which makes this tracing almost useless.
This definitely won't do.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reopened CASSANDRA-4584:
---------------------------------------
I'm getting errors on a simple example. (On Windows.)
{code}
create keyspace foo with replication = {'class': 'SimpleStrategy', 'replication_factor': '1'};
use foo;
create table one (id int primary key, c int);
TRACING ON;
insert into one (id, c) values (1, 2);
value '\x7f\x00\x00\x01' (in col 'source') can't be deserialized as inet: 'module' object has no attribute 'inet_ntop'
{code}
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458476#comment-13458476 ]
Sylvain Lebresne commented on CASSANDRA-4584:
---------------------------------------------
If we don't want to allow tracing schema altering statements, we shouldn't allow the TRACE syntax and do nothing with it.
But honestly I'm not sure there is a point in disallowing tracing for some query, especially since that's more work than doing it for all queries. Besides, for any query it could be interesting to know how long it took to parse it, to validate it and to execute it.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464543#comment-13464543 ]
Sylvain Lebresne commented on CASSANDRA-4584:
---------------------------------------------
Changed the title to reflect that this will only add TRACE to cqlsh (which I agree is a good idea).
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves updated CASSANDRA-4584:
-----------------------------------
Attachment: 4584.patch
moves enabling tracing into queryprocessor, still missing uuid pretty printing in cqlsh.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4584:
-----------------------------------------
Attachment: (was: cql-internal-only-1.2.4584.zip)
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475361#comment-13475361 ]
Aleksey Yeschenko commented on CASSANDRA-4584:
----------------------------------------------
OS X:
~/Repos/ASF/cassandra ➤ bin/cqlsh
Connected to Test Cluster at localhost:9160.
[cqlsh 2.3.0 | Cassandra 1.2.0-beta1-SNAPSHOT | CQL spec 3.0.0 | Thrift protocol 19.34.0]
Use HELP for help.
cqlsh> create keyspace foo with replication = {'class': 'SimpleStrategy', 'replication_factor': '1'};
cqlsh> use foo;
cqlsh:foo> create table one (id int primary key, c int);
cqlsh:foo> TRACING ON;
Now tracing requests.
cqlsh:foo> insert into one (id, c) values (1, 2);
session_id | event_id | activity | happened_at | source | source_elapsed | thread
--------------------------------------+--------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------------+-----------+----------------+------------------
df2cfa90-14b1-11e2-0000-242d50cf1fdf | 2012-10-13 00:14:56+0300 | Mutations/ConsistencyLevel are [RowMutation(keyspace='foo', key='00000001', modifications=[ColumnFamily(one [:false:0@1350076496063000,c:false:4@1350076496063000,])])]/ONE | 2012-10-13 00:14:56+0300 | 127.0.0.1 | 1417 | Thrift:1
df2cfa90-14b1-11e2-0000-242d50cf1fdf | 2012-10-13 00:14:56+0300 | insert writing local RowMutation(keyspace='foo', key='00000001', modifications=[one]) | 2012-10-13 00:14:56+0300 | 127.0.0.1 | 5774 | Thrift:1
df2cfa90-14b1-11e2-0000-242d50cf1fdf | 2012-10-13 00:14:56+0300 | applying mutation | 2012-10-13 00:14:56+0300 | 127.0.0.1 | 6317 | MutationStage:34
df2cfa90-14b1-11e2-0000-242d50cf1fdf | 2012-10-13 00:14:56+0300 | 1 regions now allocated in org.apache.cassandra.utils.SlabAllocator@c303a60 | 2012-10-13 00:14:56+0300 | 127.0.0.1 | 6531 | MutationStage:34
df2cfa90-14b1-11e2-0000-242d50cf1fdf | 2012-10-13 00:14:56+0300 | completed executing TraceSessionWrapper{state=org.apache.cassandra.tracing.TraceState@962e703, callable=null} | 2012-10-13 00:14:56+0300 | 127.0.0.1 | 6892 | MutationStage:34
cqlsh:foo>
Same output on Ubuntu 12.04. Might be Windows specific.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458492#comment-13458492 ]
David Alves commented on CASSANDRA-4584:
----------------------------------------
the non-schema-tracing behavior is legacy from the original patch, but I can't actually think of a reason not to trace schema altering/querying statements, so I'll add it where you suggest (and also add it to thrift for that matter).
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459623#comment-13459623 ]
Sylvain Lebresne commented on CASSANDRA-4584:
---------------------------------------------
I'm playing devil's advocate here but I wonder if this isn't something that would be better done at the protocol level. Typically there is two less that ideal thing if we make it part of the language?
* it's unclear what to do when we prepare a query with a TRACE in it. The current patch chose to trace both the preparation and all following execution. But that's 1) largely random and 2) not very flexible. As a user, I want to be able to trace an execution of a prepared query without having to trace everyone. And while maybe slightly less useful, being able to trace a prepare without necessary having all execution being traced would be neat too.
* as remarked by David, it means tracing the parsing of the query become less natural (to be honest that's not really a big deal, this would still be fairly to do, but suggests imho that trace don't belong to the language).
None of this is a problem if tracing is a protocol option. Besides, the protocol is already involved in the tracing in the sense that the trace ID cannot be returned in the ResultSet, so the protocol has to be involved already (and I note that for CQL over thrift, we already have the trace_next_query for that; adding it to the binary protocol will require a bit more work because of the asynchronous nature of the protocol, but we can leave that to later).
Last minor point in favor of not putting that in the language, we won't have to torture the parser to disallow writing slightly non-sensical queries like:
{noformat}
TRACE TRACE TRACE TRACE TRACE TRACE INSERT ....;
{noformat}
or
{noformat}
BEGIN BATCH INSERT ...; TRACE INSERT ...; INSERT ...; TRACE INSERT ...; APPLY BATCH;
{noformat}
and similar variation, all of which are allowed by the current patch.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459019#comment-13459019 ]
David Alves edited comment on CASSANDRA-4584 at 9/20/12 6:48 AM:
-----------------------------------------------------------------
separated logging for prepared query submission, execution and regular query execution, this pretty much includes CASSANDRA-4560 which is now included in this patch.
was (Author: dr-alves):
separated logging for prepared query submission, execution and regular query execution, this pretty much includes CASSANDRA-4560 which is not included in this patch.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves updated CASSANDRA-4584:
-----------------------------------
Attachment: 4584.patch
reverted changes to cqlsh as those go into CASSANDRA-4585
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves updated CASSANDRA-4584:
-----------------------------------
Attachment: 4584.patch
moved the initial logging of cql queries into QueryProcessor in the cql3 case because sessions were being started before and we needed to log params.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4584:
-----------------------------------------
Attachment: CASSANDRA-4584-INCOMPLETE.txt
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472453#comment-13472453 ]
Aleksey Yeschenko commented on CASSANDRA-4584:
----------------------------------------------
Update: the required cassandra-dbapi2 version is now in trunk, so this can be committed now.
Specialized trace results output is not in the patch - tracing results are formatted just like regular queries.
Otherwise it's done. (Will specialize tracing output once we have reasonable tracing done).
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460652#comment-13460652 ]
Jonathan Ellis commented on CASSANDRA-4584:
-------------------------------------------
PostgreSQL added EXPLAIN to their SQL dialect. Their solutions are
# not allowing EXPLAINing a PREPARE, although EXPLAINing a PREPAREd query is okay
# hijacking the query's resultset for EXPLAIN's
I think Sylvain is right that moving TRACE into the protocol is a better solution.
For the purposes of beta2, let's add a TRACE cqlsh command, specific to cqlsh, similar to how COPY is cqlsh-only. We can stick with thrift for now. Created CASSANDRA-4699 to add it to the binary protocol.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459019#comment-13459019 ]
David Alves commented on CASSANDRA-4584:
----------------------------------------
separated logging for prepared query submission, execution and regular query execution, this pretty much includes CASSANDRA-4560 which is not included in this patch.
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves updated CASSANDRA-4584:
-----------------------------------
Attachment: 4584.patch
patch that adds the keyword "trace" to cql3.
tracing is forced for a query when the keyword is prepended (e.g. "trace select * from "Standard1";)
the CqlResult from the query includes the session uuid so that clients may use it to query the events/sessions tables
adds support for showing said uuid in cqlsh *but* couldn't figure out how to format it in intelligible form (only gibberish is printed, uuid is returned as bytes, tried using the formatting methods but ultimately gave up, need help).
also altered cassandra-dbapi2 so that cursor now includes the uuid from the reponse (submitted patch in http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/issues/detail?id=24)
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4584:
-----------------------------------------
Attachment: (was: CASSANDRA-4584-INCOMPLETE.txt)
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4584) Add cqlsh syntax to enable
request tracing
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468787#comment-13468787 ]
Aleksey Yeschenko commented on CASSANDRA-4584:
----------------------------------------------
I've attached an incomplete version of the patch. Please don't commit it.
This version lacks pretty trace events output, otherwise that's it.
use 'tracing on' to enable tracing and 'tracing off' to disable it. see 'help tracing'.
I really don't like the info we are gathering now - what we have isn't really useful.
> Add cqlsh syntax to enable request tracing
> ------------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Aleksey Yeschenko
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch, CASSANDRA-4584-INCOMPLETE.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4584) Add CQL syntax to enable request
tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves updated CASSANDRA-4584:
-----------------------------------
Attachment: 4584.patch
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Labels: cql3
> Fix For: 1.2.0 beta 2
>
> Attachments: 4584.patch, 4584.patch, 4584.patch, 4584.patch, 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4584) Add CQL syntax to enable
request tracing
Posted by "David Alves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458454#comment-13458454 ]
David Alves edited comment on CASSANDRA-4584 at 9/19/12 5:37 PM:
-----------------------------------------------------------------
patch that adds the keyword "trace" to cql3.
tracing is forced for a query when the keyword is prepended (e.g. "trace select * from "Standard1";")
the CqlResult from the query includes the session uuid so that clients may use it to query the events/sessions tables
adds support for showing said uuid in cqlsh *but* couldn't figure out how to format it in intelligible form (only gibberish is printed, uuid is returned as bytes, tried using the formatting methods but ultimately gave up, need help).
also altered cassandra-dbapi2 so that cursor now includes the uuid from the reponse (submitted patch in http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/issues/detail?id=24)
was (Author: dr-alves):
patch that adds the keyword "trace" to cql3.
tracing is forced for a query when the keyword is prepended (e.g. "trace select * from "Standard1";)
the CqlResult from the query includes the session uuid so that clients may use it to query the events/sessions tables
adds support for showing said uuid in cqlsh *but* couldn't figure out how to format it in intelligible form (only gibberish is printed, uuid is returned as bytes, tried using the formatting methods but ultimately gave up, need help).
also altered cassandra-dbapi2 so that cursor now includes the uuid from the reponse (submitted patch in http://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/issues/detail?id=24)
> Add CQL syntax to enable request tracing
> ----------------------------------------
>
> Key: CASSANDRA-4584
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4584
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: David Alves
> Fix For: 1.2.0
>
> Attachments: 4584.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira