You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/04/19 21:16:20 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5852: prepare NB 19 release cycle for JDK 11.
mbien opened a new pull request, #5852:
URL: https://github.com/apache/netbeans/pull/5852
- disable CV tests on JDK 8
- move some more jobs to JDK 11
this configuration would allow us to move new modules like rust/go/hcl to JDK 11 and to upgrade exiting modules, like the maven-indexer #4999.
todo: wiki link to new NB release policy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1525784912
> FWIW, there should be a PR at some point (not necessarily here) that would provide user friendly failure messages when the build or binary is used on an unsupported JDK.
Well, we've really needed that for the IDE since NetBeans 13!
Personally, I would now look to bump the bytecode level in non-API bits of the runtime container. eg. check and fail, and update the error messages, at https://github.com/apache/netbeans/blob/master/platform/o.n.bootstrap/src/org/netbeans/Main.java#L43
If as well as checking for JDK, we updated the bytecode level, it would also allow for removing some reflection in #3386 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1529123984
@mbien looks good. I don't really mind the name, as long as we have one and all know what it means! 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1516011748
> todo: wiki link to new NB release policy
Sorry for the delay with that - https://cwiki.apache.org/confluence/display/NETBEANS/Minimum+JDK+build+and+run+policy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1581710930
see #6054 regarding JDK requirements warning UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#discussion_r1179434962
##########
.github/workflows/main.yml:
##########
@@ -2391,7 +2391,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
- java: [ '8' ]
+ java: [ '11' ]
Review Comment:
@dbalek @sdedic this would move the NBVSCode ext and the LSP job to JDK 11 since those jobs load all other modules. If the VSCode Ext has different requirements we would have to change the test setup there.
But from past conversations I believe to remember that JDK 11 was no problem there, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1528042176
I got a thumbs up https://github.com/apache/netbeans/pull/5852#discussion_r1179434962 and one approval. So I interpret this as go-ahead -> merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5852:
URL: https://github.com/apache/netbeans/pull/5852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1528016203
> Once we're ready for this, we should also add a new label for PRs that update the Java requirements for any module - "non-optional modules are free to adopt the minimum JDK as they need to." should be part of the review process. min-JDK-change ??
we have `Upgrade Library`, how about just `Upgrade JDK`? We could explain it in the label tooltip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1529122983
@neilcsmith-net are you ok with the name of the new label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "jlahoda (via GitHub)" <gi...@apache.org>.
jlahoda commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1524695759
FWIW, there should be a PR at some point (not necessarily here) that would provide user friendly failure messages when the build or binary is used on an unsupported JDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1527193982
Follow up to brief comment on the Markdown PR.
Once we're ready for this, we should also add a new label for PRs that update the Java requirements for any module - "non-optional modules are free to adopt the minimum JDK _as they need to_." should be part of the review process. `min-JDK-change` ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1537332764
@vieiro @lkishalmi I remember from reviews that you both tried to use language level 11 before for rust and similar independent modules. This is now possible.
simply mark a PR with https://github.com/apache/netbeans/labels/Upgrade%20JDK so that we can track it and bump the source/target property for the module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5852: prepare NB 19 release cycle for JDK 11.
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#issuecomment-1537348589
@mbien I'm with with language level 8 at the moment. Good to know we can mark things for 11, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists