You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/29 04:58:12 UTC
[GitHub] [incubator-superset] bkyryliuk opened a new issue #9678: Superset DB API relies on the DB being online
bkyryliuk opened a new issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678
https://github.com/apache/incubator-superset/blob/980dd2fd419893ec5ed9386ca28fa87115a3753d/superset/views/database/api.py#L138
"function_names" needs a database connection, e.g.
https://github.com/apache/incubator-superset/blob/980dd2fd419893ec5ed9386ca28fa87115a3753d/superset/db_engine_specs/hive.py#L446
This leads to the problem that 1 db being down makes a superset a bit dysfunctional e.g. sqllab will not return the list of databases and will crash the api request.
Introduced: https://github.com/apache/incubator-superset/pull/9012
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #9678: Superset DB API relies on the DB being online
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678#issuecomment-621536435
I like the idea of catching the exceptions and falling back to an empty array as @bkyryliuk did in his PR. That said, i can see the need for a new endpoint for db engine specific attributes that aren't fully populatable by the database model
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9678: Superset DB API relies on the DB being online
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678#issuecomment-621658605
@bkyryliuk that would make an easy/quick fix. Yet I think `function_names` inclusion on the GET (list) endpoint should be changed to live on it's own endpoint, taking on the @villebro's idea, and since we already have a `table_metadata` EP, include this kind of info on a `database_metadata` for example. Note that this property will increase GET (list) response time (yet this can be avoided by just requesting for the exact columns)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on issue #9678: Superset DB API relies on the DB being online
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678#issuecomment-651279730
This one is actually resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on issue #9678: Superset DB API relies on the DB being online
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678#issuecomment-621259110
Another thing that could be done is to catch requests exceptions in the model functions that require external services & will be exposed in the different APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #9678: Superset DB API relies on the DB being online
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678#issuecomment-650987016
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk closed issue #9678: Superset DB API relies on the DB being online
Posted by GitBox <gi...@apache.org>.
bkyryliuk closed issue #9678:
URL: https://github.com/apache/incubator-superset/issues/9678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org