You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/30 15:13:19 UTC
[GitHub] [zookeeper] eolivelli opened a new pull request #1196:
ZOOKEEPER-3668 Clean up release package for 3.6.0
eolivelli opened a new pull request #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196
- add LICENSE files for Snappy and Metrics core
- update Copyright year
- copy airlift reference to the NOTICE file of the binary packages
- copy the Java 8 disclaimer from branch-3.5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] asf-ci commented on issue #1196: ZOOKEEPER-3668 Clean
up release package for 3.6.0
Posted by GitBox <gi...@apache.org>.
asf-ci commented on issue #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196#issuecomment-569727846
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/1769/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] anmolnar commented on a change in pull request #1196:
ZOOKEEPER-3668 Clean up release package for 3.6.0
Posted by GitBox <gi...@apache.org>.
anmolnar commented on a change in pull request #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196#discussion_r363116801
##########
File path: zookeeper-server/src/main/resources/lib/metrics-core-5.2.5.jar_LICENSE.txt
##########
@@ -0,0 +1,1835 @@
+
+
+
+
+
+
+<!DOCTYPE html>
Review comment:
Is this intentionally an HTML file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli closed pull request #1196: ZOOKEEPER-3668
Clean up release package for 3.6.0
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1196: ZOOKEEPER-3668
Clean up release package for 3.6.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196#issuecomment-569705979
Please cherry pick to branch-3.6 and ping me
This is currently a blocker for 3.6.0 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on a change in pull request #1196:
ZOOKEEPER-3668 Clean up release package for 3.6.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196#discussion_r363118637
##########
File path: zookeeper-server/src/main/resources/lib/metrics-core-5.2.5.jar_LICENSE.txt
##########
@@ -0,0 +1,1835 @@
+
+
+
+
+
+
+<!DOCTYPE html>
Review comment:
Good catch. I will check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1196: ZOOKEEPER-3668
Clean up release package for 3.6.0
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1196: ZOOKEEPER-3668 Clean up release package for 3.6.0
URL: https://github.com/apache/zookeeper/pull/1196#issuecomment-570951826
@anmolnar you are right ! I had downloaded the github page instead of the "raw" file
Now I have pushed the right file.
I have also double checked the NOTICE part of Metrics Core, it is already good
Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services