(superset) branch fix_master_once_more created (now f6c84fa85d)

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a change to branch fix_master_once_more
in repository https://gitbox.apache.org/repos/asf/superset.git


      at f6c84fa85d fix: master docker build is broken

This branch includes the following new commits:

     new f6c84fa85d fix: master docker build is broken

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(superset) 01/01: fix: master docker build is broken

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch fix_master_once_more
in repository https://gitbox.apache.org/repos/asf/superset.git

commit f6c84fa85df37367be40faa744b73ca34a163f10
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Wed Mar 13 23:41:23 2024 -0700

    fix: master docker build is broken
    
    Following up on https://github.com/apache/superset/pull/27503 while
    flying blind. I'm guessing that DOCKERHUB_USER is empty (?) No way for
    me to check. Looking for DOCKERHUB_TOKEN should be enough though.
---
 .github/supersetbot/src/docker.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/supersetbot/src/docker.js b/.github/supersetbot/src/docker.js
index 1bf9695c23..03eb1a315f 100644
--- a/.github/supersetbot/src/docker.js
+++ b/.github/supersetbot/src/docker.js
@@ -113,7 +113,7 @@ export function getDockerCommand({
   const tags = getDockerTags({
     preset, platforms, sha, buildContext, buildContextRef: ref, forceLatest,
   }).map((tag) => `-t ${tag}`).join(' \\\n        ');
-  const isAuthenticated = !!(process.env.DOCKERHUB_TOKEN && process.env.DOCKERHUB_USER);
+  const isAuthenticated = !!(process.env.DOCKERHUB_TOKEN);
 
   const dockerArgs = isAuthenticated ? '--push' : '--load';
   const targetArgument = buildTarget ? `--target ${buildTarget}` : '';