You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/08/11 23:21:18 UTC
[GitHub] [druid] clintropolis opened a new pull request, #12893: fix bug with json_object expression not fully unwrapping inputs
clintropolis opened a new pull request, #12893:
URL: https://github.com/apache/druid/pull/12893
### Description
This PR fixes a bug with `JSON_OBJECT` not unwrapping all value objects, which can result in `StructuredData` appearing in the resulting object. This is problematic if the value is used with `to_json_string`, which is currently using a default object mapper which doesn't know how to serialize `StructuredData`, causing a failure.
While it might be a good idea to determine how to use the JSON ObjectMapper we use everywhere for `to_json_string`, it was also unintentional that `json_object` wasn't "unwrapping" `StructuredData` from the inputs to its value arguments, so I've fixed that part in this PR.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #12893: fix bug with json_object expression not fully unwrapping inputs
Posted by GitBox <gi...@apache.org>.
gianm merged PR #12893:
URL: https://github.com/apache/druid/pull/12893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org