You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/23 09:17:25 UTC
Review Request 35771: Fixed post-reviews.py hanging bug.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Bugs: MESOS-757
https://issues.apache.org/jira/browse/MESOS-757
Repository: mesos
Description
-------
If you're not logged into ReviewBoard and run `post-reviews.py` the script hangs when trying to create a diff.
After pressing enter, if you're not logged in, you get the following error message:
```
...
Press enter to continue or 'Ctrl-C' to skip.
Please log in to the Review Board server at reviews.apache.org.
You can either:
(1) Run 'rbt login', or
(2) Set the default USERNAME/PASSWORD in '.reviewboardrc'
```
Diffs
-----
support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
Diff: https://reviews.apache.org/r/35771/diff/
Testing
-------
(1) `rbt logout` to log out of ReviewBoard
(2) Removed `USERNAME`/`PASSWORD` from `.reviewboardrc` so that `rbt` doesn't use it to log in automatically.
(3) Observed the error message shown in __Description__
Thanks,
Michael Park
Re: Review Request 35771: Fixed post-reviews.py hanging bug.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88956
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35771]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 7:17 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35771/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 7:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Bugs: MESOS-757
> https://issues.apache.org/jira/browse/MESOS-757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If you're not logged into ReviewBoard and run `post-reviews.py` the script hangs when trying to create a diff.
>
> After pressing enter, if you're not logged in, you get the following error message:
>
> ```
> ...
>
> Press enter to continue or 'Ctrl-C' to skip.
>
> Please log in to the Review Board server at reviews.apache.org.
>
> You can either:
> (1) Run 'rbt login', or
> (2) Set the default USERNAME/PASSWORD in '.reviewboardrc'
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35771/diff/
>
>
> Testing
> -------
>
> (1) `rbt logout` to log out of ReviewBoard
> (2) Removed `USERNAME`/`PASSWORD` from `.reviewboardrc` so that `rbt` doesn't use it to log in automatically.
> (3) Observed the error message shown in __Description__
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35771: Fixed post-reviews.py hanging bug.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88934
-----------------------------------------------------------
lgtm - thanks for the fix, much appreciated.
- Till Toenshoff
On June 23, 2015, 7:17 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35771/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 7:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Bugs: MESOS-757
> https://issues.apache.org/jira/browse/MESOS-757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If you're not logged into ReviewBoard and run `post-reviews.py` the script hangs when trying to create a diff.
>
> After pressing enter, if you're not logged in, you get the following error message:
>
> ```
> ...
>
> Press enter to continue or 'Ctrl-C' to skip.
>
> Please log in to the Review Board server at reviews.apache.org.
>
> You can either:
> (1) Run 'rbt login', or
> (2) Set the default USERNAME/PASSWORD in '.reviewboardrc'
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35771/diff/
>
>
> Testing
> -------
>
> (1) `rbt logout` to log out of ReviewBoard
> (2) Removed `USERNAME`/`PASSWORD` from `.reviewboardrc` so that `rbt` doesn't use it to log in automatically.
> (3) Observed the error message shown in __Description__
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35771: Fixed post-reviews.py hanging bug.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88972
-----------------------------------------------------------
Ship it!
Ship It!
- Kapil Arya
On June 23, 2015, 3:17 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35771/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 3:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Bugs: MESOS-757
> https://issues.apache.org/jira/browse/MESOS-757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If you're not logged into ReviewBoard and run `post-reviews.py` the script hangs when trying to create a diff.
>
> After pressing enter, if you're not logged in, you get the following error message:
>
> ```
> ...
>
> Press enter to continue or 'Ctrl-C' to skip.
>
> Please log in to the Review Board server at reviews.apache.org.
>
> You can either:
> (1) Run 'rbt login', or
> (2) Set the default USERNAME/PASSWORD in '.reviewboardrc'
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35771/diff/
>
>
> Testing
> -------
>
> (1) `rbt logout` to log out of ReviewBoard
> (2) Removed `USERNAME`/`PASSWORD` from `.reviewboardrc` so that `rbt` doesn't use it to log in automatically.
> (3) Observed the error message shown in __Description__
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35771: Fixed post-reviews.py hanging bug.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35771/#review88936
-----------------------------------------------------------
Ship it!
Tried it on an RBT installation that was never properly configured / logged in -- works perfectly fine now.
- Till Toenshoff
On June 23, 2015, 7:17 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35771/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 7:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Bugs: MESOS-757
> https://issues.apache.org/jira/browse/MESOS-757
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If you're not logged into ReviewBoard and run `post-reviews.py` the script hangs when trying to create a diff.
>
> After pressing enter, if you're not logged in, you get the following error message:
>
> ```
> ...
>
> Press enter to continue or 'Ctrl-C' to skip.
>
> Please log in to the Review Board server at reviews.apache.org.
>
> You can either:
> (1) Run 'rbt login', or
> (2) Set the default USERNAME/PASSWORD in '.reviewboardrc'
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35771/diff/
>
>
> Testing
> -------
>
> (1) `rbt logout` to log out of ReviewBoard
> (2) Removed `USERNAME`/`PASSWORD` from `.reviewboardrc` so that `rbt` doesn't use it to log in automatically.
> (3) Observed the error message shown in __Description__
>
>
> Thanks,
>
> Michael Park
>
>