You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/01/15 13:27:25 UTC
[GitHub] iilyak commented on a change in pull request #1684: Partition
feature flag
iilyak commented on a change in pull request #1684: Partition feature flag
URL: https://github.com/apache/couchdb/pull/1684#discussion_r247890511
##########
File path: src/chttpd/src/chttpd_db.erl
##########
@@ -323,7 +323,7 @@ create_db_req(#httpd{}=Req, DbName) ->
Q = chttpd:qs_value(Req, "q", config:get("cluster", "q", "8")),
P = chttpd:qs_value(Req, "placement", config:get("cluster", "placement")),
EngineOpt = parse_engine_opt(Req),
- DbProps = parse_partitioned_opt(Req),
+ DbProps = parse_partitioned_opt(Req, DbName),
Review comment:
I think we shouldn't add `DbName` argument to `parse_partitioned_opt`. The feature flags implementation is capable to work with `#httpd{}` records directly (see [here](https://github.com/apache/couchdb/blob/master/src/couch/src/couch_flags.erl#L109) ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services