You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Anshul Gangwar <an...@citrix.com> on 2014/02/07 12:22:04 UTC

Review Request 17842: fixed vmsync for hyperv

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17842/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-6054
    https://issues.apache.org/jira/browse/CLOUDSTACK-6054


Repository: cloudstack-git


Description
-------

fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport and made appropriate changes to HypervDirectConnectResource.java 


Diffs
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 9637994 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs a132606 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc 
  plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java a4dca6a 

Diff: https://reviews.apache.org/r/17842/diff/


Testing
-------

Performed basic vm operations externally and verifying their state got updated correctly in cloudstack 


Thanks,

Anshul Gangwar

Re: Review Request 17842: fixed vmsync for hyperv

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17842/#review34046
-----------------------------------------------------------



plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
<https://reviews.apache.org/r/17842/#comment64013>

    There is already a WmiCallsV2::EnabledState class defined. Please use that.



plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
<https://reviews.apache.org/r/17842/#comment64015>

    Hyperv agent should map the hyper-v state to cloudstack state and return an appropriate state in the answer. Lookat WmiCallsV2::EnabledState.ToCloudStackState


- Devdeep Singh


On Feb. 7, 2014, 11:22 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17842/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 11:22 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6054
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6054
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport and made appropriate changes to HypervDirectConnectResource.java 
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 9637994 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs a132606 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc 
>   plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java a4dca6a 
> 
> Diff: https://reviews.apache.org/r/17842/diff/
> 
> 
> Testing
> -------
> 
> Performed basic vm operations externally and verifying their state got updated correctly in cloudstack 
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 17842: fixed vmsync for hyperv

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17842/#review34047
-----------------------------------------------------------



plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs
<https://reviews.apache.org/r/17842/#comment64016>

    This will also return the root partition (computer system). Hyper-V agent should filter out the root partition entry and then return the updated vmsync state. 


- Devdeep Singh


On Feb. 7, 2014, 11:22 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17842/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 11:22 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6054
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6054
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport and made appropriate changes to HypervDirectConnectResource.java 
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 9637994 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs a132606 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc 
>   plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java a4dca6a 
> 
> Diff: https://reviews.apache.org/r/17842/diff/
> 
> 
> Testing
> -------
> 
> Performed basic vm operations externally and verifying their state got updated correctly in cloudstack 
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 17842: fixed vmsync for hyperv

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17842/#review34173
-----------------------------------------------------------

Ship it!


Committed to 4.3-forward and master in commit ids eef65ac776de171d83f9f532ac2dda6902117178 and b86d45b0036482cfc9c9fc55f62954a1b9599188 respectively.

- Devdeep Singh


On Feb. 10, 2014, 11:07 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17842/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 11:07 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6054
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6054
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport and made appropriate changes to HypervDirectConnectResource.java 
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 9637994 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs a132606 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc 
>   plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java a4dca6a 
> 
> Diff: https://reviews.apache.org/r/17842/diff/
> 
> 
> Testing
> -------
> 
> Performed basic vm operations externally and verifying their state got updated correctly in cloudstack 
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>

Re: Review Request 17842: fixed vmsync for hyperv

Posted by Anshul Gangwar <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17842/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 11:07 a.m.)


Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Changes
-------

updated the patch with the changes as suggested


Bugs: CLOUDSTACK-6054
    https://issues.apache.org/jira/browse/CLOUDSTACK-6054


Repository: cloudstack-git


Description
-------

fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport and made appropriate changes to HypervDirectConnectResource.java 


Diffs (updated)
-----

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 9637994 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs a132606 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc 
  plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java a4dca6a 

Diff: https://reviews.apache.org/r/17842/diff/


Testing
-------

Performed basic vm operations externally and verifying their state got updated correctly in cloudstack 


Thanks,

Anshul Gangwar