You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2026/06/07 07:08:35 UTC
[PR] feat(build): update Node version to v24 [superset]
hainenber opened a new pull request, #40835:
URL: https://github.com/apache/superset/pull/40835
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
feat(build): update Node version to v24
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Updating project's Node version to v24 across all sub-projects. Node v22 is far from EoL but perf improvements from Node v24 is so critical for us atm as it'd help speeding up quite a lot of processes (`dev`, `test` and `build).
According to Gemini, these are possible benefits
| Feature / Metric | Node 22 (V8 12.4) | Node 24 (V8 13.6) | Impact on Superset Development
-- | -- | -- | --
Cold Startup Time | Baseline | ~15% Faster | Speeds up initial npm run dev or HMR spin-ups for the asset server.
JIT Optimization | Maglev / Turbofan | Enhanced Pipelines | Improves execution for CPU-bound tasks like massive JSON parsing from complex slice/dashboard payload mocks.
Test Runner Throughput | Baseline | ~20% Higher | Shaves off total runtime in local or CI validation steps when running intensive frontend test suites.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Green CI and manual smoke test
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #40835:
URL: https://github.com/apache/superset/pull/40835#issuecomment-4641747445
### <span aria-hidden="true">β
</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">π¨</span> Latest commit | bf9e2fb5ff2b9946c62b3a5ef325973d7e56b047 |
|<span aria-hidden="true">π</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a2518f3d58abe0008ba24fe |
|<span aria-hidden="true">π</span> Deploy Preview | [https://deploy-preview-40835--superset-docs-preview.netlify.app](https://deploy-preview-40835--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">π±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">π€</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcoxDoAgDADAv3SWiAiG-AOfUWyJg0Jjqokx_l22G-4FOeshCjNAB-nEsm7NmVH7SwiVTanERqu5nW-FWPb6LNTShC4MMY8UIia21saEzmeG7wc) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-40835--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40835:
URL: https://github.com/apache/superset/pull/40835#issuecomment-4642207359
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40835:
URL: https://github.com/apache/superset/pull/40835#discussion_r3368916721
##########
superset-websocket/.nvmrc:
##########
@@ -1 +1 @@
-v22.22.0
+v24.16.0
Review Comment:
**π Architect Review β HIGH**
Node upgrade is incomplete for the websocket sub-project: `.nvmrc` now targets v24, but `superset-websocket/package.json` and `superset-websocket/package-lock.json` still declare `"engines": { "node": "^22.22.0", "npm": "^10.8.2" }`, creating conflicting sources of truth and causing install failures in engine-strict setups.
**Suggestion:** Update the `engines` block in `superset-websocket/package.json` (and the corresponding section in `superset-websocket/package-lock.json`) to match the new Node/npm versions used in `.nvmrc`, aligning websocket runtime metadata with the rest of the repo.
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6b53c5b857b641489fda347a03d23147&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6b53c5b857b641489fda347a03d23147&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent π€ </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings β not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
**Path:** superset-websocket/.nvmrc
**Line:** 1:1
**Comment:**
*HIGH: Node upgrade is incomplete for the websocket sub-project: `.nvmrc` now targets v24, but `superset-websocket/package.json` and `superset-websocket/package-lock.json` still declare `"engines": { "node": "^22.22.0", "npm": "^10.8.2" }`, creating conflicting sources of truth and causing install failures in engine-strict setups.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix β do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #40835:
URL: https://github.com/apache/superset/pull/40835#discussion_r3368918384
##########
superset-websocket/.nvmrc:
##########
@@ -1 +1 @@
-v22.22.0
+v24.16.0
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent Node.js version</b></div>
<div id="fix">
The `engines.node` field in package.json still specifies `^22.22.0` while .nvmrc has been updated to v24.16.0. Update package.json to maintain consistency across configuration files.
</div>
</div>
<small><i>Code Review Run #cf621e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40835:
URL: https://github.com/apache/superset/pull/40835#issuecomment-4641945835
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40835?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.14%. Comparing base ([`9da4536`](https://app.codecov.io/gh/apache/superset/commit/9da453635427afc3065f0d151a6e9eca0b56a7ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c7ba8c3`](https://app.codecov.io/gh/apache/superset/commit/c7ba8c3310717758868adfa40de0bd04dc84ed2b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40835 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 2650 2650
Lines 143455 143455
Branches 33097 33097
=======================================
Hits 92024 92024
Misses 49824 49824
Partials 1607 1607
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40835/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40835/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.86% <ΓΈ> (ΓΈ)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/40835?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #40835:
URL: https://github.com/apache/superset/pull/40835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on code in PR #40835:
URL: https://github.com/apache/superset/pull/40835#discussion_r3369130477
##########
superset-websocket/.nvmrc:
##########
@@ -1 +1 @@
-v22.22.0
+v24.16.0
Review Comment:
This has been resolved in https://github.com/apache/superset/pull/40835/commits/134fba302271b4bb41112a42ebe6c3cf3867ca2a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40835:
URL: https://github.com/apache/superset/pull/40835#issuecomment-4641750545
<!-- Bito Reply -->
The flagged issue is correct. The `.nvmrc` files for `superset-websocket` and `superset-websocket/utils/client-ws-app` have been updated to Node v24.16.0, but the corresponding `package.json` and `package-lock.json` files still reference the older Node v22.22.0 and npm v10.8.2 versions. This discrepancy can cause installation failures in environments with strict engine checks.
To resolve this, you should update the `engines` block in `superset-websocket/package.json` and `superset-websocket/utils/client-ws-app/package.json` (and their respective `package-lock.json` files) to match the new versions:
```json
"engines": {
"node": "^24.16.0",
"npm": "^11.13.0"
}
```
I have validated this against the provided PR diff. Would you like me to fetch all other comments on this PR to see if there are additional issues you would like to address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40835:
URL: https://github.com/apache/superset/pull/40835#issuecomment-4641741641
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(build): update Node version to v24 [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #40835:
URL: https://github.com/apache/superset/pull/40835#discussion_r3369130609
##########
superset-websocket/.nvmrc:
##########
@@ -1 +1 @@
-v22.22.0
+v24.16.0
Review Comment:
<!-- Bito Reply -->
The suggestion to update the Node.js version in package.json is appropriate to ensure consistency with the .nvmrc file. Since the change has already been addressed in the referenced commit, no further action is required for this specific issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org