[PR] docs(setup): the post-checkout hook stopped delivering skills; say so [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #1218:
URL: https://github.com/apache/magpie/pull/1218

   ## What
   
   The repo-local `post-checkout` hook once re-created gitignored runtime state and seeded a per-worktree agent-guard copy. Both jobs are gone — the template in [`install.md` Step 10](https://github.com/apache/magpie/blob/main/plugins/magpie-setup/skills/setup/install.md) is now one guarded call to `sandbox-add-project-root.sh`. Nine places still described the old behaviour, and the marketplace path (which writes no hook at all) was never folded into any of them.
   
   This started as one stale troubleshooting row and turned out to be a cluster of claims all tracing back to the hook's old job.
   
   ## The hook no longer delivers framework skills
   
   | File | Was |
   |---|---|
   | `setup/SKILL.md` | Failure-mode row named the wrong sub-action (`adopt` installs no hook) and the wrong mechanism (it re-runs no snapshot install) |
   | `setup/install.md` | The **adopter-facing doc template** — so the stale claim was propagating into other projects' CONTRIBUTING files |
   | `setup/verify.md` | Said `--auto-fix-symlinks` is called by the hook, contradicting check 8 *in the same file*, which rejects a hook carrying that line |
   | `setup/upgrade.md` | "The post-checkout hook covers the next checkout case" in the symlink-refresh context. It does not — which strengthens the case for Step 6c |
   | `other-install-methods.md` | Manual recipe step 5, "so worktrees re-create the gitignored runtime state" |
   
   `SKILL.md` also gains a second failure-mode row for the sandbox-allowlist symptom, which is the one that actually survives on the marketplace path.
   
   ## A hook the marketplace path never writes
   
   `secure-agent-setup.md` (lifecycle item 4 and the per-project scope row) and `isolated-setup-install` Step P all asserted the hook exists. They now name the snapshot-install-only condition and say what to do when neither a repo-local nor a global hook is present: `worktree-init`.
   
   Item 4 is restructured rather than patched — its closing sentence promised automatic inheritance and would have contradicted the new qualifier left in place.
   
   ## Same staleness in one field
   
   `collect_status.py`'s `has_verify_recipe` tested for `"magpie-setup verify" in content` — a line the current template deliberately omits. It read `False` on a correct hook and `True` on a stale one. Replaced with `has_sandbox_helper` + `has_stale_verify_line`; `collect.md`'s schema row follows. Nothing consumed the old key (grep-verified).
   
   ## Testing
   
   - `prek run --files $(git diff --name-only)` passes, except `skill-token-count`, which fails identically on a stashed clean tree — a missing tokenizer cache in my environment, unrelated to this change.
   - Both new `hook_status` fields exercised against a current and a stale hook template.
   
   No behaviour change beyond the two renamed JSON keys.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01VAJ5GbXnv4LWMfDdvDNJKE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] docs(setup): the post-checkout hook stopped delivering skills; say so [magpie]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #1218:
URL: https://github.com/apache/magpie/pull/1218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org