You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2011/08/31 15:36:09 UTC
[jira] [Created] (GIRAPH-20) Move temporary test files from the
project directory
Move temporary test files from the project directory
----------------------------------------------------
Key: GIRAPH-20
URL: https://issues.apache.org/jira/browse/GIRAPH-20
Project: Giraph
Issue Type: Improvement
Reporter: Owen O'Malley
We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272418#comment-13272418 ]
Hudson commented on GIRAPH-20:
------------------------------
Integrated in Giraph-trunk-Commit #109 (See [https://builds.apache.org/job/Giraph-trunk-Commit/109/])
GIRAPH-20 Move temporary test files from the project directory (Revision 1336743)
Result = SUCCESS
ssc : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336743
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/FileUtils.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/BspCase.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestBspBasic.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java
* /incubator/giraph/trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Fix For: 0.2.0
>
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272217#comment-13272217 ]
jiraposter@reviews.apache.org commented on GIRAPH-20:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/
-----------------------------------------------------------
(Updated 2012-05-10 09:32:10.140325)
Review request for giraph.
Changes
-------
Updated the patch to reflect Avery's comments.
The line FileUtils:87 has to be kept, we initially delete the new file (if it existed) as it will be recreated later.
Summary
-------
All temporary files that the tests generate are now written to /tmp/_giraphTests including zooKeeper files, checkpoints etc.
This behavior will be automatically configured whenever InternalVertexRunner.run() or BspCase.prepareJob() is used.
Usually I can't stop myself once I have my refactoring hat on, therefore I also tidied up a lot of minor stuff, removed code duplications etc.
This addresses bug GIRAPH-20.
https://issues.apache.org/jira/browse/GIRAPH-20
Diffs (updated)
-----
trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java 1336504
trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1336504
trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java 1336504
trunk/src/main/java/org/apache/giraph/utils/FileUtils.java PRE-CREATION
trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 1336504
trunk/src/test/java/org/apache/giraph/BspCase.java 1336504
trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1336506
trunk/src/test/java/org/apache/giraph/TestBspBasic.java 1336504
trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java 1336504
trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java 1336504
trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1336506
trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java 1336504
trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 1336504
trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1336504
trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java 1336504
Diff: https://reviews.apache.org/r/5077/diff
Testing
-------
successfully passed local and pseudo-distributed tests with Hadoop 0.20.203
Thanks,
Sebastian
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271801#comment-13271801 ]
jiraposter@reviews.apache.org commented on GIRAPH-20:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/#review7745
-----------------------------------------------------------
Hey, Sebastian, overall looks good. If no one else gets to it, I'll finish this review tonight.
- Avery
On 2012-05-09 11:37:47, Sebastian Schelter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5077/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 11:37:47)
bq.
bq.
bq. Review request for giraph.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. All temporary files that the tests generate are now written to /tmp/_giraphTests including zooKeeper files, checkpoints etc.
bq.
bq. This behavior will be automatically configured whenever InternalVertexRunner.run() or BspCase.prepareJob() is used.
bq.
bq. Usually I can't stop myself once I have my refactoring hat on, therefore I also tidied up a lot of minor stuff, removed code duplications etc.
bq.
bq.
bq. This addresses bug GIRAPH-20.
bq. https://issues.apache.org/jira/browse/GIRAPH-20
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1332106
bq. trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestBspBasic.java 1332106
bq. trunk/src/test/java/org/apache/giraph/BspCase.java 1332106
bq. trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 1332106
bq. trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java 1332106
bq. trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1332106
bq. trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java 1332106
bq. trunk/src/main/java/org/apache/giraph/utils/FileUtils.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/5077/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. successfully passed local and pseudo-distributed tests with Hadoop 0.20.203
bq.
bq.
bq. Thanks,
bq.
bq. Sebastian
bq.
bq.
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272377#comment-13272377 ]
jiraposter@reviews.apache.org commented on GIRAPH-20:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/#review7772
-----------------------------------------------------------
Ship it!
+1, thanks Sebastian! I'm assuming it also passes 'mvn verify', but please double check before you commit.
- Avery
On 2012-05-10 09:32:10, Sebastian Schelter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5077/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 09:32:10)
bq.
bq.
bq. Review request for giraph.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. All temporary files that the tests generate are now written to /tmp/_giraphTests including zooKeeper files, checkpoints etc.
bq.
bq. This behavior will be automatically configured whenever InternalVertexRunner.run() or BspCase.prepareJob() is used.
bq.
bq. Usually I can't stop myself once I have my refactoring hat on, therefore I also tidied up a lot of minor stuff, removed code duplications etc.
bq.
bq.
bq. This addresses bug GIRAPH-20.
bq. https://issues.apache.org/jira/browse/GIRAPH-20
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java 1336504
bq. trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1336504
bq. trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java 1336504
bq. trunk/src/main/java/org/apache/giraph/utils/FileUtils.java PRE-CREATION
bq. trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 1336504
bq. trunk/src/test/java/org/apache/giraph/BspCase.java 1336504
bq. trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1336506
bq. trunk/src/test/java/org/apache/giraph/TestBspBasic.java 1336504
bq. trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java 1336504
bq. trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java 1336504
bq. trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1336506
bq. trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java 1336504
bq. trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 1336504
bq. trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1336504
bq. trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java 1336504
bq.
bq. Diff: https://reviews.apache.org/r/5077/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. successfully passed local and pseudo-distributed tests with Hadoop 0.20.203
bq.
bq.
bq. Thanks,
bq.
bq. Sebastian
bq.
bq.
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter updated GIRAPH-20:
-------------------------------------
Attachment: GIRAPH-20.patch
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Schelter reassigned GIRAPH-20:
----------------------------------------
Assignee: Sebastian Schelter
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated GIRAPH-20:
--------------------------------
Component/s: test
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Reporter: Owen O'Malley
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272152#comment-13272152 ]
jiraposter@reviews.apache.org commented on GIRAPH-20:
-----------------------------------------------------
bq. On 2012-05-10 06:57:01, Avery Ching wrote:
bq. > Overall, looks great. Can you address the questions/comments and then I'll re-review?
Thanks for the quick review!
I'll address your comments, merge this with the current trunk and posted a new patch.
bq. On 2012-05-10 06:57:01, Avery Ching wrote:
bq. > trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java, lines 85-87
bq. > <https://reviews.apache.org/r/5077/diff/1/?file=108155#file108155line85>
bq. >
bq. > Just out of curiosity, why this change?
If one uses writeUTF() and then reads the resulting file with a buffered reader, each line starts with a broken char. Directly writing the bytes out solved this.
bq. On 2012-05-10 06:57:01, Avery Ching wrote:
bq. > trunk/src/main/java/org/apache/giraph/utils/FileUtils.java, line 87
bq. > <https://reviews.apache.org/r/5077/diff/1/?file=108156#file108156line87>
bq. >
bq. > Why delete it?
I'll remove this.
bq. On 2012-05-10 06:57:01, Avery Ching wrote:
bq. > trunk/src/test/java/org/apache/giraph/TestBspBasic.java, line 242
bq. > <https://reviews.apache.org/r/5077/diff/1/?file=108160#file108160line242>
bq. >
bq. > shouldn't it be 49 not 491?
its a small L not a 1 :)
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/#review7756
-----------------------------------------------------------
On 2012-05-09 11:37:47, Sebastian Schelter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5077/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 11:37:47)
bq.
bq.
bq. Review request for giraph.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. All temporary files that the tests generate are now written to /tmp/_giraphTests including zooKeeper files, checkpoints etc.
bq.
bq. This behavior will be automatically configured whenever InternalVertexRunner.run() or BspCase.prepareJob() is used.
bq.
bq. Usually I can't stop myself once I have my refactoring hat on, therefore I also tidied up a lot of minor stuff, removed code duplications etc.
bq.
bq.
bq. This addresses bug GIRAPH-20.
bq. https://issues.apache.org/jira/browse/GIRAPH-20
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1332106
bq. trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1332106
bq. trunk/src/test/java/org/apache/giraph/TestBspBasic.java 1332106
bq. trunk/src/test/java/org/apache/giraph/BspCase.java 1332106
bq. trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 1332106
bq. trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java 1332106
bq. trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1332106
bq. trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java 1332106
bq. trunk/src/main/java/org/apache/giraph/utils/FileUtils.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/5077/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. successfully passed local and pseudo-distributed tests with Hadoop 0.20.203
bq.
bq.
bq. Thanks,
bq.
bq. Sebastian
bq.
bq.
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271336#comment-13271336 ]
jiraposter@reviews.apache.org commented on GIRAPH-20:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/
-----------------------------------------------------------
Review request for giraph.
Summary
-------
All temporary files that the tests generate are now written to /tmp/_giraphTests including zooKeeper files, checkpoints etc.
This behavior will be automatically configured whenever InternalVertexRunner.run() or BspCase.prepareJob() is used.
Usually I can't stop myself once I have my refactoring hat on, therefore I also tidied up a lot of minor stuff, removed code duplications etc.
This addresses bug GIRAPH-20.
https://issues.apache.org/jira/browse/GIRAPH-20
Diffs
-----
trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1332106
trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java 1332106
trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java 1332106
trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1332106
trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java 1332106
trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 1332106
trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java 1332106
trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1332106
trunk/src/test/java/org/apache/giraph/TestBspBasic.java 1332106
trunk/src/test/java/org/apache/giraph/BspCase.java 1332106
trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 1332106
trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java 1332106
trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1332106
trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java 1332106
trunk/src/main/java/org/apache/giraph/utils/FileUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/5077/diff
Testing
-------
successfully passed local and pseudo-distributed tests with Hadoop 0.20.203
Thanks,
Sebastian
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-20) Move temporary test files from the
project directory
Posted by "Sebastian Schelter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268364#comment-13268364 ]
Sebastian Schelter commented on GIRAPH-20:
------------------------------------------
the patch still misses a single file, I'll provide an updated one soon.
> Move temporary test files from the project directory
> ----------------------------------------------------
>
> Key: GIRAPH-20
> URL: https://issues.apache.org/jira/browse/GIRAPH-20
> Project: Giraph
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.2.0
> Reporter: Owen O'Malley
> Assignee: Sebastian Schelter
> Attachments: GIRAPH-20.patch
>
>
> We shouldn't use the project directory as the location for temporary files generated by the tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira