You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/05 09:28:39 UTC
[GitHub] [flink] qinjunjerry opened a new pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
qinjunjerry opened a new pull request #13068:
URL: https://github.com/apache/flink/pull/13068
1.10 back port of #10936, see also [FLINK-18702](https://issues.apache.org/jira/browse/FLINK-18702)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-669089069
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 071311551e84a7a875a20912023b4d45a186c70e (Wed Aug 05 09:31:21 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-670354963
Thanks for the backport. Did the commit from master apply without conflicts to the release-1.10 branch? (I'm asking so that don't have to manually compare everything ;) )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-669097915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "071311551e84a7a875a20912023b4d45a186c70e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "071311551e84a7a875a20912023b4d45a186c70e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 071311551e84a7a875a20912023b4d45a186c70e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-669097915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "071311551e84a7a875a20912023b4d45a186c70e",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/178530382",
"triggerID" : "071311551e84a7a875a20912023b4d45a186c70e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 071311551e84a7a875a20912023b4d45a186c70e Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/178530382)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-669097915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "071311551e84a7a875a20912023b4d45a186c70e",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/178530382",
"triggerID" : "071311551e84a7a875a20912023b4d45a186c70e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 071311551e84a7a875a20912023b4d45a186c70e Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/178530382)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13068:
URL: https://github.com/apache/flink/pull/13068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] qinjunjerry commented on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
qinjunjerry commented on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-670356197
I did not see any conflicts to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13068: [FLINK-13689] [Connectors/ElasticSearch] Fix thread leak in Elasticsearch connector when cluster is down
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13068:
URL: https://github.com/apache/flink/pull/13068#issuecomment-670357300
Okay. In the meantime I checked the changes, everything looks fine.
I'll merge this now!
Thanks for the backport!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org