You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mime4j-dev@james.apache.org by Markus Wiederkehr <ma...@gmail.com> on 2009/06/06 23:27:15 UTC
Re: svn commit: r778453 - in /james/mime4j/trunk/core/src:
main/java/org/apache/james/mime4j/message/ test/java/org/apache/james/mime4j/message/
On Sun, May 31, 2009 at 8:12 PM, Stefano Bagnara<ap...@bago.org> wrote:
> mwiederkehr@apache.org ha scritto:
>> Author: mwiederkehr
>> Date: Mon May 25 17:02:25 2009
>> New Revision: 778453
>>
>> URL: http://svn.apache.org/viewvc?rev=778453&view=rev
>> Log:
>> MIME4J-136: Pull up getInputStream() from BinaryBody to SingleBody
>> [....]
>> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java
>> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java?rev=778453&r1=778452&r2=778453&view=diff
>> ==============================================================================
>> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java (original)
>> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java Mon May 25 17:02:25 2009
>> @@ -19,7 +19,9 @@
>>
>> package org.apache.james.mime4j.message;
>>
>> +import java.io.ByteArrayInputStream;
>> import java.io.IOException;
>> +import java.io.InputStream;
>> import java.io.OutputStream;
>> import java.io.OutputStreamWriter;
>> import java.io.Reader;
>> @@ -48,6 +50,11 @@
>> }
>>
>> @Override
>> + public InputStream getInputStream() throws IOException {
>> + return new ByteArrayInputStream(text.getBytes(charset));
>> + }
>
> String.getBytes(Charset) is a java6 only method.
>
> Hudson failed since this commit.
>
> I just replaced charset with charset.name(), please review as I don't
> know that code. Hudson now passes.
Looks good, thanks!
Could we configure Hudson to send build reports to this list?
Preferably only in case of failed builds..
I don't think I have a Hudson account. Could someone jump in?
Markus
>
> Stefano
Re: svn commit: r778453 - in /james/mime4j/trunk/core/src:
main/java/org/apache/james/mime4j/message/ test/java/org/apache/james/mime4j/message/
Posted by Markus Wiederkehr <ma...@gmail.com>.
On Mon, Jun 8, 2009 at 12:10 PM, Stefano Bagnara<ap...@bago.org> wrote:
> Markus Wiederkehr ha scritto:
>> On Sun, May 31, 2009 at 8:12 PM, Stefano Bagnara<ap...@bago.org> wrote:
>>> mwiederkehr@apache.org ha scritto:
>>>> Author: mwiederkehr
>>>> Date: Mon May 25 17:02:25 2009
>>>> New Revision: 778453
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=778453&view=rev
>>>> Log:
>>>> MIME4J-136: Pull up getInputStream() from BinaryBody to SingleBody
>>>> [....]
>>>> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java
>>>> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java?rev=778453&r1=778452&r2=778453&view=diff
>>>> ==============================================================================
>>>> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java (original)
>>>> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java Mon May 25 17:02:25 2009
>>>> @@ -19,7 +19,9 @@
>>>>
>>>> package org.apache.james.mime4j.message;
>>>>
>>>> +import java.io.ByteArrayInputStream;
>>>> import java.io.IOException;
>>>> +import java.io.InputStream;
>>>> import java.io.OutputStream;
>>>> import java.io.OutputStreamWriter;
>>>> import java.io.Reader;
>>>> @@ -48,6 +50,11 @@
>>>> }
>>>>
>>>> @Override
>>>> + public InputStream getInputStream() throws IOException {
>>>> + return new ByteArrayInputStream(text.getBytes(charset));
>>>> + }
>>> String.getBytes(Charset) is a java6 only method.
>>>
>>> Hudson failed since this commit.
>>>
>>> I just replaced charset with charset.name(), please review as I don't
>>> know that code. Hudson now passes.
>>
>> Looks good, thanks!
>>
>> Could we configure Hudson to send build reports to this list?
>> Preferably only in case of failed builds..
>
> I'm not sure how Hudson notification works. Currently it was configured
> to send notifications to me. Sometimes I got failures, sometimes
> success, sometimes multiple messages.
>
> BTW, I just reconfigured mime4j to include this list address as a
> notification address, too.
TY
> Let's see if it works (probably we'll have to
> allow the hudson users on this list on the first message).
No problem..
> I also noticed that mime4j automatically publishes snapshots to
> https://repository.apache.org/content/repositories/snapshots/org/apache/james/
> I find this really useful for letting bug reporters test snapshots once
> we fix bugs.
>
>> I don't think I have a Hudson account. Could someone jump in?
>
> I don't think I can create hudson account anymore. Sudo access has been
> limited since I had my account. Try the JIRA way as Robert proposed.
Since you included the list address I don't need an account right
away. I'll file a JIRA if I ever need one again..
Thanks,
Markus
Re: svn commit: r778453 - in /james/mime4j/trunk/core/src: main/java/org/apache/james/mime4j/message/
test/java/org/apache/james/mime4j/message/
Posted by Stefano Bagnara <ap...@bago.org>.
Markus Wiederkehr ha scritto:
> On Sun, May 31, 2009 at 8:12 PM, Stefano Bagnara<ap...@bago.org> wrote:
>> mwiederkehr@apache.org ha scritto:
>>> Author: mwiederkehr
>>> Date: Mon May 25 17:02:25 2009
>>> New Revision: 778453
>>>
>>> URL: http://svn.apache.org/viewvc?rev=778453&view=rev
>>> Log:
>>> MIME4J-136: Pull up getInputStream() from BinaryBody to SingleBody
>>> [....]
>>> Modified: james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java
>>> URL: http://svn.apache.org/viewvc/james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java?rev=778453&r1=778452&r2=778453&view=diff
>>> ==============================================================================
>>> --- james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java (original)
>>> +++ james/mime4j/trunk/core/src/main/java/org/apache/james/mime4j/message/StringTextBody.java Mon May 25 17:02:25 2009
>>> @@ -19,7 +19,9 @@
>>>
>>> package org.apache.james.mime4j.message;
>>>
>>> +import java.io.ByteArrayInputStream;
>>> import java.io.IOException;
>>> +import java.io.InputStream;
>>> import java.io.OutputStream;
>>> import java.io.OutputStreamWriter;
>>> import java.io.Reader;
>>> @@ -48,6 +50,11 @@
>>> }
>>>
>>> @Override
>>> + public InputStream getInputStream() throws IOException {
>>> + return new ByteArrayInputStream(text.getBytes(charset));
>>> + }
>> String.getBytes(Charset) is a java6 only method.
>>
>> Hudson failed since this commit.
>>
>> I just replaced charset with charset.name(), please review as I don't
>> know that code. Hudson now passes.
>
> Looks good, thanks!
>
> Could we configure Hudson to send build reports to this list?
> Preferably only in case of failed builds..
I'm not sure how Hudson notification works. Currently it was configured
to send notifications to me. Sometimes I got failures, sometimes
success, sometimes multiple messages.
BTW, I just reconfigured mime4j to include this list address as a
notification address, too. Let's see if it works (probably we'll have to
allow the hudson users on this list on the first message).
I also noticed that mime4j automatically publishes snapshots to
https://repository.apache.org/content/repositories/snapshots/org/apache/james/
I find this really useful for letting bug reporters test snapshots once
we fix bugs.
> I don't think I have a Hudson account. Could someone jump in?
I don't think I can create hudson account anymore. Sudo access has been
limited since I had my account. Try the JIRA way as Robert proposed.
Stefano
Re: svn commit: r778453 - in /james/mime4j/trunk/core/src:
main/java/org/apache/james/mime4j/message/ test/java/org/apache/james/mime4j/message/
Posted by Robert Burrell Donkin <ro...@gmail.com>.
On Sat, Jun 6, 2009 at 10:27 PM, Markus
Wiederkehr<ma...@gmail.com> wrote:
<snip>
> I don't think I have a Hudson account.
open an INFRASTRUCTURE JIRA requesting an account
- robert