You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "XuQianJin-Stars (via GitHub)" <gi...@apache.org> on 2026/05/16 03:02:33 UTC
[PR] [client] Fix inverted awaitTermination condition in LookupClient#close [fluss]
XuQianJin-Stars opened a new pull request, #3328:
URL: https://github.com/apache/fluss/pull/3328
The shutdown logic in LookupClient#close() had the awaitTermination condition inverted - it called shutdownNow() when the thread pool had already terminated gracefully, and did nothing when it timed out.
This is inconsistent with WriterClient#close() and all other shutdown patterns in the codebase which correctly negate awaitTermination() to trigger shutdownNow() on timeout.
The bug could cause the lookup sender thread pool to not be forcefully terminated when graceful shutdown times out, potentially leading to resource leaks.
## Purpose
Fix a logic bug in `LookupClient#close()` where a missing `!` operator caused inverted shutdown behavior for the lookup sender thread pool.
## Brief change log
- Fixed the inverted `awaitTermination()` condition in `LookupClient#close()` by adding the missing `!` negation operator, making it consistent with `WriterClient#close()` and the standard `ExecutorService` shutdown pattern documented in the [Java SE docs](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/concurrent/ExecutorService.html).
## Tests
- No new tests needed. This is a one-character fix (`!`) to an existing condition.
- The correct pattern is already validated by the existing shutdown behavior in `WriterClient#close()` and `RemoteLogManager#shutdownAndAwaitTermination()`.
## API and Format
- No API or format changes.
## Documentation
- No documentation changes needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [client] Fix inverted awaitTermination condition in LookupClient#close [fluss]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #3328:
URL: https://github.com/apache/fluss/pull/3328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [client] Fix inverted awaitTermination condition in LookupClient#close [fluss]
Posted by "XuQianJin-Stars (via GitHub)" <gi...@apache.org>.
XuQianJin-Stars commented on PR #3328:
URL: https://github.com/apache/fluss/pull/3328#issuecomment-4526997454
hi @wuchong @luoyuxia Please help review when you got some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org