You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/06/05 10:09:37 UTC

Review Request: CLOUDSTACK-1960: Key remapping fails to input the keys \ | ? of UK Keyboard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11650/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Fang Wang.


Description
-------

CLOUDSTACK-1960 Key remapping fails to input the keys \ | ? of UK Keyboard

This patch fixes  " ¦ " key for IE browser. 


This addresses bug CLOUDSTACK-1960.


Diffs
-----

  services/console-proxy/server/js/ajaxkeys.js 5f497bb 

Diff: https://reviews.apache.org/r/11650/diff/


Testing
-------

Verified on local CloudStack setup.


Thanks,

Sanjay Tripathi


Re: Review Request: CLOUDSTACK-1960: Key remapping fails to input the keys \ | ? of UK Keyboard

Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11650/#review21472
-----------------------------------------------------------


Can someone familiar with localization look at it?

- Devdeep Singh


On June 5, 2013, 8:09 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11650/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 8:09 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960 Key remapping fails to input the keys \ | ? of UK Keyboard
> 
> This patch fixes  " ¦ " key for IE browser. 
> 
> 
> This addresses bug CLOUDSTACK-1960.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 5f497bb 
> 
> Diff: https://reviews.apache.org/r/11650/diff/
> 
> 
> Testing
> -------
> 
> Verified on local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CLOUDSTACK-1960: Key remapping fails to input the keys \ | ? of UK Keyboard

Posted by Fang Wang <fa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11650/#review21807
-----------------------------------------------------------

Ship it!


Ship It!

- Fang Wang


On June 5, 2013, 8:09 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11650/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 8:09 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960 Key remapping fails to input the keys \ | ? of UK Keyboard
> 
> This patch fixes  " ¦ " key for IE browser. 
> 
> 
> This addresses bug CLOUDSTACK-1960.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 5f497bb 
> 
> Diff: https://reviews.apache.org/r/11650/diff/
> 
> 
> Testing
> -------
> 
> Verified on local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>


Re: Review Request: CLOUDSTACK-1960: Key remapping fails to input the keys \ | ? of UK Keyboard

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11650/#review21897
-----------------------------------------------------------


Commit 18163eaa4d3f3eac0a8de9fc6b87224e22c84914 in branch refs/heads/master from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=18163ea ]

CLOUDSTACK-1960: Key remapping fails to input the keys \ | . of UK Keyboard


- ASF Subversion and Git Services


On June 5, 2013, 8:09 a.m., Sanjay Tripathi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11650/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 8:09 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Fang Wang.
> 
> 
> Description
> -------
> 
> CLOUDSTACK-1960 Key remapping fails to input the keys \ | ? of UK Keyboard
> 
> This patch fixes  " ¦ " key for IE browser. 
> 
> 
> This addresses bug CLOUDSTACK-1960.
> 
> 
> Diffs
> -----
> 
>   services/console-proxy/server/js/ajaxkeys.js 5f497bb 
> 
> Diff: https://reviews.apache.org/r/11650/diff/
> 
> 
> Testing
> -------
> 
> Verified on local CloudStack setup.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>