[GitHub] mistercrunch closed pull request #5644: handle exception and set dtype value to JSON, when column type JSON

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5644: handle exception and set dtype value to JSON, when column type JSON
URL: https://github.com/apache/incubator-superset/pull/5644
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index 62c48771fc..13c6a8b7b9 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2252,6 +2252,8 @@ def table(self, database_id, table_name, schema):
             try:
                 dtype = '{}'.format(col['type'])
             except Exception:
+                # sqla.types.JSON __str__ has a bug, so using __class__.
+                dtype = col['type'].__class__.__name__
                 pass
             payload_columns.append({
                 'name': col['name'],


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org