[jira] [Commented] (CASSANDRA-3649) Code style changes, aka The Big Reformat

["Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215775#comment-13215775 ] 

Sylvain Lebresne commented on CASSANDRA-3649:
---------------------------------------------

Since the 1.2 branch has been created, it's probably time to do what's on that issue, i.e. before we have tons of patch to rebase.

I've started doing a number of things that I consider code cleanups. Feel free to criticize some of those (but it would be nice to get feedback quickly to avoid having to maintain/rebase this for weeks). I've put that at https://github.com/pcmanus/cassandra/commits/3649_big_reformat and it includes the following changes:
* Remove underscores on variables: remove underscores at the end of variables (and make sure to use 'this' when a field could otherwise be shadowed by a local variable).
* Remove tabulations: there was a first tabulation used for indentation. That patch remove them (but make sure to not screw up indentation).
* Capitalize DBConstants constant: the title says it all. I don't care very much about that one but I do think it's more consistent that way.
* Rewrite licenses: that one is totally to please my OCD. It bugs me that all license header are not the same so this patch fix that (and also make sure the license is always the first thing in the file, before the package declaration). I understand it doesn't accomplish anything really useful but on the other side it has little change to generate conflict (we don't modify license very often).
* Remove unused DesctructivePQIterator class: that class is dead code as far as I can tell.
* Remove unused imports: the title says it all.
* Adds final to fields: that one is a little more involved than the other in a way. It sets final all fields that can be. I do strongly think it's a good thing to use final as much as make sense.
* Strip end of line whitespace: likely the one that will introduce the more merge conflict.

                
> Code style changes, aka The Big Reformat
> ----------------------------------------
>
>                 Key: CASSANDRA-3649
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3649
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Brandon Williams
>             Fix For: 1.2
>
>
> With a new major release coming soon and not having a ton of huge pending patches that have prevented us from doing this in the past, post-freeze looks like a good time to finally do this.  Mostly this will include the removal of underscores in private variables, and no more brace-on-newline policy.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira