[jira] Commented: (BEEHIVE-625) Fixes to build.xml for PetStore

["Scott Semyan (JIRA)" <be...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/BEEHIVE-625?page=comments#action_64782 ]
     
Scott Semyan commented on BEEHIVE-625:
--------------------------------------

Sorry, we crossed paths over the weekend. I had meant to log all of this on Friday but didn't get to it until this morning. I then did a full sync and saw your changes.

As to issue #1 above, I find the derby.jar variable confusing. I've logged the following bug on it:
http://issues.apache.org/jira/browse/BEEHIVE-628

Issue #3 does not appear to be fixed. This is just the comment for the target. You have:
<!-- ========================================= -->
<!-- build - build the webapp                  -->
<!-- ========================================= -->

But it should probably be something like:
<!-- =================================================================== -->
<!-- deploy-beehive - deploy the beehive components into the webapp lib  -->
<!-- =================================================================== -->

As to #8 above, I like the idea of always building before running the test. Ant & javac are smart enough that if no files have changed it won't rebuild the classes. It's confusing when you change a test then run and you don't see your changes. But, I'll defer to your decision.

> Fixes to build.xml for PetStore
> -------------------------------
>
>          Key: BEEHIVE-625
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-625
>      Project: Beehive
>         Type: Bug
>   Components: Samples
>     Versions: V1
>     Reporter: Scott Semyan
>     Assignee: Alejandro Ramirez
>      Fix For: V1
>  Attachments: diff.txt
>
> When building with the new directory layout for PetStore, I found a few problems. The attached diff file corrects the following:
> 1) Set derby location via a variable in build.properties
> 2) Copy the derby.jar into the lib directory only during the deploy-beehive target, not in every build
> 3) Fix the comment for the deploy-beehive target
> 4) Add an ensure.derby target to make sure derby is present
> 5) Add the extra jar files from HTTPUnit to the classpath
> 6) Remove the copy of jars from petstore/lib since this task is taken care of in #2 above
> 7) Add debug=true to the javac task in the test.build target so we get line numbers when running the tests
> 8) Make test.build a dependency of test.run so you can edit a test, then automatically build when you run the test again.
> 9) Modified README to indicate item #1 above.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira