You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/18 10:09:14 UTC

[GitHub] [activemq-artemis] meierhofer08 opened a new pull request #3498: ARTEMIS-2870: Transfer connection close/failure listeners one by one …

meierhofer08 opened a new pull request #3498:
URL: https://github.com/apache/activemq-artemis/pull/3498


   …on reattachment
   
   Previously, when a session was reattached, all the close/failure listeners
   were removed from the old connection and set onto the new connection.
   This only worked when at most 1 session of the old connection was
   transferred: When the second session was transferred, the old
   connection already didn't contain any close/failure listeners anymore,
   and therefore the list of close/failure listeners was overwritten by
   an empty list for the new connection.
   
   Now, when a session is being transferred, it only transfers the
   close/failure listeners that belong to it, which are the session itself
   + the TempQueueCleanerUppers.
   
   Modified a test to check whether the sessions are failure listeners of
   the new connection after reattachment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3498: ARTEMIS-2870: Transfer connection close/failure listeners one by one …

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3498:
URL: https://github.com/apache/activemq-artemis/pull/3498#discussion_r597286698



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/ReattachTest.java
##########
@@ -133,18 +134,31 @@ public void testReattachTransferConnectionOnSession() throws Exception {
       locator.setRetryInterval(retryInterval).setRetryIntervalMultiplier(retryMultiplier).setReconnectAttempts(reconnectAttempts).setConfirmationWindowSize(1024 * 1024);
       ClientSessionFactoryInternal sf = (ClientSessionFactoryInternal) createSessionFactory(locator);
       ClientSession session = sf.createSession(false, true, true);
+      ClientSession secondSession = sf.createSession(false, true, true);

Review comment:
       no need to make this change... but I'm creating a second test on top of this one
   
   Your change is going into testReattachTransferConnectionOnSession2().
   
   
   
   I will do this as part of the merge and amending this as you.. you will still be the author of the commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3498: ARTEMIS-2870: Transfer connection close/failure listeners one by one …

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3498:
URL: https://github.com/apache/activemq-artemis/pull/3498


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] meierhofer08 commented on a change in pull request #3498: ARTEMIS-2870: Transfer connection close/failure listeners one by one …

Posted by GitBox <gi...@apache.org>.
meierhofer08 commented on a change in pull request #3498:
URL: https://github.com/apache/activemq-artemis/pull/3498#discussion_r597450847



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/ReattachTest.java
##########
@@ -133,18 +134,31 @@ public void testReattachTransferConnectionOnSession() throws Exception {
       locator.setRetryInterval(retryInterval).setRetryIntervalMultiplier(retryMultiplier).setReconnectAttempts(reconnectAttempts).setConfirmationWindowSize(1024 * 1024);
       ClientSessionFactoryInternal sf = (ClientSessionFactoryInternal) createSessionFactory(locator);
       ClientSession session = sf.createSession(false, true, true);
+      ClientSession secondSession = sf.createSession(false, true, true);

Review comment:
       Ah ok, a separate test also makes sense, I wasn't sure as they both effectively test "transferConnection" in "ServerSessionImpl".
   Thank you for checking and merging so quickly!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org