You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/11 08:23:03 UTC

[GitHub] [doris] Gabriel39 opened a new pull request, #13286: [Improvement](join) refine prefetch strategy

Gabriel39 opened a new pull request, #13286:
URL: https://github.com/apache/doris/pull/13286

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 merged pull request #13286: [Improvement](join) refine prefetch strategy

Posted by GitBox <gi...@apache.org>.
Gabriel39 merged PR #13286:
URL: https://github.com/apache/doris/pull/13286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 commented on pull request #13286: [Improvement](join) refine prefetch strategy

Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #13286:
URL: https://github.com/apache/doris/pull/13286#issuecomment-1274310804

   Impact on cache miss
   
   I observed impact of different prefetch steps on cache miss for TPCH Q14.
   
   Baseline
   ![image](https://user-images.githubusercontent.com/37700562/195040228-c4df386d-d32f-481d-aed1-7dd8d8767d9c.png)
   
   step = 32
   
   ![image](https://user-images.githubusercontent.com/37700562/195040294-5b96da60-a330-4a06-88b0-43d6ede2514b.png)
   
   step = 64
   ![image](https://user-images.githubusercontent.com/37700562/195040375-88067488-5cf5-4b93-ae1d-4ef1a2342c96.png)
   
   step = 128
   ![image](https://user-images.githubusercontent.com/37700562/195040442-272c072d-33ce-4bdc-8c90-7635c3186b1e.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 commented on pull request #13286: [Improvement](join) refine prefetch strategy

Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #13286:
URL: https://github.com/apache/doris/pull/13286#issuecomment-1274305904

   Overall performance
   
   I tested TPCH 100g on 1FE + 1BE using {DORIS_HOME}/tools/tpch-tools/bin/run-tpch-queries.sh.
   
   ![image](https://user-images.githubusercontent.com/37700562/195039642-7a469dde-fff6-4fff-9e93-faa1e288630b.png)
   ![image](https://user-images.githubusercontent.com/37700562/195039712-39ca7457-21ff-4b8b-951d-f3cc836505d0.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] Gabriel39 commented on pull request #13286: [Improvement](join) refine prefetch strategy

Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #13286:
URL: https://github.com/apache/doris/pull/13286#issuecomment-1274314179

   Based on the results, 64 is chosen to be a given prefetch step. And maybe we should also provide this as a SQL hint to allow users to tune by themselves.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org