You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/23 12:25:29 UTC
[GitHub] [doris] carlvinhust2012 opened a new pull request, #10378: [Enhancement] support different python version in build-support scripts
carlvinhust2012 opened a new pull request, #10378:
URL: https://github.com/apache/doris/pull/10378
# Proposed changes
1. support different python version in build-support scripts which is more convenient for us.
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10378: [Enhancement] support different python version in build-support scripts
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10378:
URL: https://github.com/apache/doris/pull/10378#issuecomment-1165481631
> Hi @carlvinhust2012 , please rebase the fix the BE ut. some commit has been reverted to fix that bug.
ok，I will rebase later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10378: [Enhancement] support different python version in build-support scripts
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10378:
URL: https://github.com/apache/doris/pull/10378#issuecomment-1165478542
Hi @carlvinhust2012 , please rebase the fix the BE ut. some commit has been reverted to fix that bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10378: [Enhancement] support different python version in build-support scripts
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10378:
URL: https://github.com/apache/doris/pull/10378#issuecomment-1165140986
> Python 2 is EOF. Is it necessary to support it?
>
> Furthermore, the modification looks verbose. You can use a variable to indicate python with different versions.
>
> ```shell
> PYTHON='python3'
>
> "${PYTHON}" ...
> ```
yes, this is a good idea. I have test the way like "python${VERSION} parameter-list" yestoday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #10378: [Enhancement] support different python version in build-support scripts
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #10378:
URL: https://github.com/apache/doris/pull/10378#issuecomment-1165134715
Python 2 is EOF. Is it necessary to support it?
Furthermore, the modification looks verbose. You can use a variable to indicate python with different versions.
```shell
PYTHON='python3'
"${PYTHON}" ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #10378: [Enhancement] support different python version in build-support scripts
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #10378:
URL: https://github.com/apache/doris/pull/10378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org