You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jb...@apache.org on 2004/01/16 20:59:44 UTC
cvs commit: incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx GBeanMBeanAttribute.java
jboynes 2004/01/16 11:59:44
Modified: modules/kernel/src/java/org/apache/geronimo/gbean/jmx
GBeanMBeanAttribute.java
Log:
Revision Changes Path
1.2 +6 -6 incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/GBeanMBeanAttribute.java
Index: GBeanMBeanAttribute.java
===================================================================
RCS file: /home/cvs/incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/GBeanMBeanAttribute.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- GBeanMBeanAttribute.java 14 Jan 2004 22:16:38 -0000 1.1
+++ GBeanMBeanAttribute.java 16 Jan 2004 19:59:44 -0000 1.2
@@ -160,18 +160,18 @@
constructorType != getterMethod.getReturnType()) {
throw new InvalidConfigurationException("Constructor argument and getter method do not have the same type:" +
" name=" + attributeInfo.getName() +
- " constructorType=" + constructorType +
- " geterMethod=" + getterMethod.getName() +
+ " constructorType=" + constructorType.getName() +
+ " getterMethod=" + getterMethod.getName() +
" targetClass=" + gMBean.getType().getName());
}
// setter and constructor types are consistent
if (constructorType != null && setterMethod != null &&
- constructorType != setterMethod.getReturnType()) {
+ constructorType != setterMethod.getParameterTypes()[0]) {
throw new InvalidConfigurationException("Constructor argument and setter method do not have the same type:" +
" name=" + attributeInfo.getName() +
- " constructorType=" + constructorType +
- " seterMethod=" + setterMethod.getName() +
+ " constructorType=" + constructorType.getName() +
+ " setterMethod=" + setterMethod.getName() +
" targetClass=" + gMBean.getType().getName());
}
Re: cvs commit: incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx
GBeanMBeanAttribute.java
Posted by Jeremy Boynes <je...@coredevelopers.net>.
Hit return too quickly :(
The log for this is "fix bug if both constructor arg and setter are
available, plus make diags clearer"
jboynes@apache.org wrote:
> jboynes 2004/01/16 11:59:44
>
> Modified: modules/kernel/src/java/org/apache/geronimo/gbean/jmx
> GBeanMBeanAttribute.java
> Log:
>
>
> Revision Changes Path
> 1.2 +6 -6 incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/GBeanMBeanAttribute.java
>
> Index: GBeanMBeanAttribute.java
> ===================================================================
> RCS file: /home/cvs/incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/jmx/GBeanMBeanAttribute.java,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -r1.1 -r1.2
> --- GBeanMBeanAttribute.java 14 Jan 2004 22:16:38 -0000 1.1
> +++ GBeanMBeanAttribute.java 16 Jan 2004 19:59:44 -0000 1.2
> @@ -160,18 +160,18 @@
> constructorType != getterMethod.getReturnType()) {
> throw new InvalidConfigurationException("Constructor argument and getter method do not have the same type:" +
> " name=" + attributeInfo.getName() +
> - " constructorType=" + constructorType +
> - " geterMethod=" + getterMethod.getName() +
> + " constructorType=" + constructorType.getName() +
> + " getterMethod=" + getterMethod.getName() +
> " targetClass=" + gMBean.getType().getName());
> }
>
> // setter and constructor types are consistent
> if (constructorType != null && setterMethod != null &&
> - constructorType != setterMethod.getReturnType()) {
> + constructorType != setterMethod.getParameterTypes()[0]) {
> throw new InvalidConfigurationException("Constructor argument and setter method do not have the same type:" +
> " name=" + attributeInfo.getName() +
> - " constructorType=" + constructorType +
> - " seterMethod=" + setterMethod.getName() +
> + " constructorType=" + constructorType.getName() +
> + " setterMethod=" + setterMethod.getName() +
> " targetClass=" + gMBean.getType().getName());
> }
>
>
>