You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by "John D. Ament" <jo...@apache.org> on 2015/08/03 05:37:27 UTC
Initial release input
Hi all,
I asked another IPMC member to look over our proposed release contents to
help identify issues with the release before we get into the actual release
cycle. Better to do it early than late from my experience.
Most of it is simple clean up that needs to happen, but there's a few
questionable things I'd like you guys to look at and fix as appropriate.
1. RAT plugin wasn't running on the examples projects. The examples/
module was not included in the parent. But even then, the child modules
don't have the proper parent and version set. I'm changing it, but there
are RAT violations reported now. Should examples be in there by default,
or should we only include in the release profile?
2. The following files don't include headers, Should they? I believe if
we fix these, the RAT reports should be better.
- missing apache headers for:
./examples/1-minimal-example/src/test/java/org/tamaya/exampl
es/minimal/MinimalTests.java
./examples/1-minimal-example/src/test/java/org/tamaya/exampl
es/minimal/TestEnum.java
./examples/4-resolver-example/src/test/java/org/tamaya/examp
les/minimal/MinimalTests.java
./examples/4-resolver-example/src/test/java/org/tamaya/examp
les/minimal/TestEnum.java
./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
metamodel/simple/SimpleTest.java
3. any idea where the icons (in ./docs/images/icons) come from? We should
probably remove the Thumbs.db, but if we don't know where the icons came
from and the icons aren't properly licensed we'll need to remove them.
Does it break something to remove them?
Re: Initial release input
Posted by Anatole Tresch <at...@gmail.com>.
Yep, I can try it ;)
2015-08-04 2:28 GMT+02:00 John D. Ament <jo...@apache.org>:
> Sounds good to me. Do you want to execute the actual release and call for
> the vote here and on general@?
>
> John
>
> On Mon, Aug 3, 2015 at 8:18 PM Anatole Tresch <at...@gmail.com> wrote:
>
> > Hi all
> >
> > now the build on my machine is successful and everything is checked in. I
> > also updated descriptions for the examples in the asciidoc part and fixed
> > all findbugs, RAT ,checkstyle issues reported in the examples part added.
> >
> > Beforhand I already removed all the images/icons that may have license
> > issues and also fixed some other documentation issues.
> >
> > So basically if all goes well we should be able to go ahead for release
> > now...
> >
> > Best,
> > Anatole
> >
> >
> > 2015-08-03 21:54 GMT+02:00 Anatole Tresch <at...@gmail.com>:
> >
> > > Yep, I removed all images exception the one I have drawn myseld (part
> of
> > > the design documentation). So that part should be clean now. Will check
> > > later for missing licence headers and also have seen that the examples
> > part
> > > in asciidoc is only containing headers, so I will add some summary
> > > descriptions there as well tonight...
> > >
> > > Anatole
> > >
> > >
> > > 2015-08-03 15:08 GMT+02:00 John D. Ament <jo...@gmail.com>:
> > >
> > >> On Mon, Aug 3, 2015 at 8:14 AM Tresch, Anatole <
> > >> anatole.tresch@credit-suisse.com> wrote:
> > >>
> > >> > Hi John
> > >> >
> > >> > inline again (removed a few things to keep it brief)...
> > >> >
> > >> > Anatole
> > >> >
> > >> >
> > >> > -----Original Message-----
> > >> > From: John D. Ament [mailto:john.d.ament@gmail.com]
> > >> > Sent: Montag, 3. August 2015 13:54
> > >> > To: dev@tamaya.incubator.apache.org
> > >> > Subject: Re: Initial release input
> > >> >
> > >> > Hi Anatole
> > >> >
> > >> > On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com>
> > >> wrote:
> > >> >
> > >> > > > 1. RAT plugin wasn't running on the examples projects. The
> > >> examples/
> > >> > > > module was not included in the parent. But even then, the child
> > >> > modules
> > >> > > > don't have the proper parent and version set. I'm changing it,
> > but
> > >> > there
> > >> > > > are RAT violations reported now. Should examples be in there by
> > >> > default,
> > >> > > > or should we only include in the release profile?
> > >> > > >
> > >> > > -> I would add them, but then as a logical consequence enable RAT
> > on
> > >> > them
> > >> > > as well.
> > >> > >
> > >> > >
> > >> > I updated the build last night to include the examples.
> > >> >
> > >> >
> > >> > -> Thanks!
> > >> >
> > >> > > > 2. The following files don't include headers, Should they? I
> > >> believe
> > >> > if
> > >> > > > we fix these, the RAT reports should be better.
> > >> > > >
> > >> > > > - missing apache headers for:
> > >> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > >> > > > es/minimal/MinimalTests.java
> > >> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > >> > > > es/minimal/TestEnum.java
> > >> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > >> > > > les/minimal/MinimalTests.java
> > >> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > >> > > > les/minimal/TestEnum.java
> > >> > > > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> > >> > > > metamodel/simple/SimpleTest.java
> > >> > > >
> > >> > > -> see above. Yes add headers to the examples. The rest, where
> RAT
> > >> was
> > >> > > already active should be clean as of now.
> > >> > >
> > >> > Ok, I'd prefer that the person who added the files can add the
> > >> headers. If
> > >> > you're not going to be able to get to it, I'll add them.
> > >> >
> > >> > -> OK. That's my task ;) Created the example as preparation of the
> > >> > javaland conference in Germany in spring.
> > >> >
> > >> > > > 3. any idea where the icons (in ./docs/images/icons) come from?
> > We
> > >> > > should
> > >> > > > probably remove the Thumbs.db, but if we don't know where the
> > icons
> > >> > came
> > >> > > > from and the icons aren't properly licensed we'll need to remove
> > >> them.
> > >> > > > Does it break something to remove them?
> > >> > > >
> > >> > > -> they are related to asciidoctor. May be possible to remove
> them
> > or
> > >> > > check for the licence (as most Redhat stuff should be ALv2 as
> > well). I
> > >> > will
> > >> > > check that later today ;) Thanks for the pointer.
> > >> > >
> > >> >
> > >> >
> > >> > Sounds good to me. These were the extent of the issues found, and
> > >> really
> > >> > the only blocker one is the missing headers. Once you figure out
> the
> > >> > graphics let's prep the release and start a vote.
> > >> >
> > >> > Any objections?
> > >> >
> > >> > -> No fully agree. I will given an update, once I finished my tasks.
> > >> > Hopefully this evening/night, the latest tomorrow lunch time MET ;)
> > >> >
> > >>
> > >>
> > >> Yep, just so I'm clear we need to either remove the images, or
> attribute
> > >> them in the LICENSE/NOTICE.
> > >>
> > >
> > >
> > >
> > > --
> > > *Anatole Tresch*
> > > Java Engineer & Architect, JSR Spec Lead
> > > Glärnischweg 10
> > > CH - 8620 Wetzikon
> > >
> > > *Switzerland, Europe Zurich, GMT+1*
> > > *Twitter: @atsticks*
> > > *Blogs: **http://javaremarkables.blogspot.ch/
> > > <http://javaremarkables.blogspot.ch/>*
> > >
> > > *Google: atsticksMobile +41-76 344 62 79 <%2B41-76%20344%2062%2079>*
> > >
> >
> >
> >
> > --
> > *Anatole Tresch*
> > Java Engineer & Architect, JSR Spec Lead
> > Glärnischweg 10
> > CH - 8620 Wetzikon
> >
> > *Switzerland, Europe Zurich, GMT+1*
> > *Twitter: @atsticks*
> > *Blogs: **http://javaremarkables.blogspot.ch/
> > <http://javaremarkables.blogspot.ch/>*
> >
> > *Google: atsticksMobile +41-76 344 62 79*
> >
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79 <%2B41-76%20344%2062%2079>*
Re: Initial release input
Posted by "John D. Ament" <jo...@apache.org>.
Sounds good to me. Do you want to execute the actual release and call for
the vote here and on general@?
John
On Mon, Aug 3, 2015 at 8:18 PM Anatole Tresch <at...@gmail.com> wrote:
> Hi all
>
> now the build on my machine is successful and everything is checked in. I
> also updated descriptions for the examples in the asciidoc part and fixed
> all findbugs, RAT ,checkstyle issues reported in the examples part added.
>
> Beforhand I already removed all the images/icons that may have license
> issues and also fixed some other documentation issues.
>
> So basically if all goes well we should be able to go ahead for release
> now...
>
> Best,
> Anatole
>
>
> 2015-08-03 21:54 GMT+02:00 Anatole Tresch <at...@gmail.com>:
>
> > Yep, I removed all images exception the one I have drawn myseld (part of
> > the design documentation). So that part should be clean now. Will check
> > later for missing licence headers and also have seen that the examples
> part
> > in asciidoc is only containing headers, so I will add some summary
> > descriptions there as well tonight...
> >
> > Anatole
> >
> >
> > 2015-08-03 15:08 GMT+02:00 John D. Ament <jo...@gmail.com>:
> >
> >> On Mon, Aug 3, 2015 at 8:14 AM Tresch, Anatole <
> >> anatole.tresch@credit-suisse.com> wrote:
> >>
> >> > Hi John
> >> >
> >> > inline again (removed a few things to keep it brief)...
> >> >
> >> > Anatole
> >> >
> >> >
> >> > -----Original Message-----
> >> > From: John D. Ament [mailto:john.d.ament@gmail.com]
> >> > Sent: Montag, 3. August 2015 13:54
> >> > To: dev@tamaya.incubator.apache.org
> >> > Subject: Re: Initial release input
> >> >
> >> > Hi Anatole
> >> >
> >> > On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com>
> >> wrote:
> >> >
> >> > > > 1. RAT plugin wasn't running on the examples projects. The
> >> examples/
> >> > > > module was not included in the parent. But even then, the child
> >> > modules
> >> > > > don't have the proper parent and version set. I'm changing it,
> but
> >> > there
> >> > > > are RAT violations reported now. Should examples be in there by
> >> > default,
> >> > > > or should we only include in the release profile?
> >> > > >
> >> > > -> I would add them, but then as a logical consequence enable RAT
> on
> >> > them
> >> > > as well.
> >> > >
> >> > >
> >> > I updated the build last night to include the examples.
> >> >
> >> >
> >> > -> Thanks!
> >> >
> >> > > > 2. The following files don't include headers, Should they? I
> >> believe
> >> > if
> >> > > > we fix these, the RAT reports should be better.
> >> > > >
> >> > > > - missing apache headers for:
> >> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> >> > > > es/minimal/MinimalTests.java
> >> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> >> > > > es/minimal/TestEnum.java
> >> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> >> > > > les/minimal/MinimalTests.java
> >> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> >> > > > les/minimal/TestEnum.java
> >> > > > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> >> > > > metamodel/simple/SimpleTest.java
> >> > > >
> >> > > -> see above. Yes add headers to the examples. The rest, where RAT
> >> was
> >> > > already active should be clean as of now.
> >> > >
> >> > Ok, I'd prefer that the person who added the files can add the
> >> headers. If
> >> > you're not going to be able to get to it, I'll add them.
> >> >
> >> > -> OK. That's my task ;) Created the example as preparation of the
> >> > javaland conference in Germany in spring.
> >> >
> >> > > > 3. any idea where the icons (in ./docs/images/icons) come from?
> We
> >> > > should
> >> > > > probably remove the Thumbs.db, but if we don't know where the
> icons
> >> > came
> >> > > > from and the icons aren't properly licensed we'll need to remove
> >> them.
> >> > > > Does it break something to remove them?
> >> > > >
> >> > > -> they are related to asciidoctor. May be possible to remove them
> or
> >> > > check for the licence (as most Redhat stuff should be ALv2 as
> well). I
> >> > will
> >> > > check that later today ;) Thanks for the pointer.
> >> > >
> >> >
> >> >
> >> > Sounds good to me. These were the extent of the issues found, and
> >> really
> >> > the only blocker one is the missing headers. Once you figure out the
> >> > graphics let's prep the release and start a vote.
> >> >
> >> > Any objections?
> >> >
> >> > -> No fully agree. I will given an update, once I finished my tasks.
> >> > Hopefully this evening/night, the latest tomorrow lunch time MET ;)
> >> >
> >>
> >>
> >> Yep, just so I'm clear we need to either remove the images, or attribute
> >> them in the LICENSE/NOTICE.
> >>
> >
> >
> >
> > --
> > *Anatole Tresch*
> > Java Engineer & Architect, JSR Spec Lead
> > Glärnischweg 10
> > CH - 8620 Wetzikon
> >
> > *Switzerland, Europe Zurich, GMT+1*
> > *Twitter: @atsticks*
> > *Blogs: **http://javaremarkables.blogspot.ch/
> > <http://javaremarkables.blogspot.ch/>*
> >
> > *Google: atsticksMobile +41-76 344 62 79 <%2B41-76%20344%2062%2079>*
> >
>
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: Initial release input
Posted by Anatole Tresch <at...@gmail.com>.
Hi all
now the build on my machine is successful and everything is checked in. I
also updated descriptions for the examples in the asciidoc part and fixed
all findbugs, RAT ,checkstyle issues reported in the examples part added.
Beforhand I already removed all the images/icons that may have license
issues and also fixed some other documentation issues.
So basically if all goes well we should be able to go ahead for release
now...
Best,
Anatole
2015-08-03 21:54 GMT+02:00 Anatole Tresch <at...@gmail.com>:
> Yep, I removed all images exception the one I have drawn myseld (part of
> the design documentation). So that part should be clean now. Will check
> later for missing licence headers and also have seen that the examples part
> in asciidoc is only containing headers, so I will add some summary
> descriptions there as well tonight...
>
> Anatole
>
>
> 2015-08-03 15:08 GMT+02:00 John D. Ament <jo...@gmail.com>:
>
>> On Mon, Aug 3, 2015 at 8:14 AM Tresch, Anatole <
>> anatole.tresch@credit-suisse.com> wrote:
>>
>> > Hi John
>> >
>> > inline again (removed a few things to keep it brief)...
>> >
>> > Anatole
>> >
>> >
>> > -----Original Message-----
>> > From: John D. Ament [mailto:john.d.ament@gmail.com]
>> > Sent: Montag, 3. August 2015 13:54
>> > To: dev@tamaya.incubator.apache.org
>> > Subject: Re: Initial release input
>> >
>> > Hi Anatole
>> >
>> > On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com>
>> wrote:
>> >
>> > > > 1. RAT plugin wasn't running on the examples projects. The
>> examples/
>> > > > module was not included in the parent. But even then, the child
>> > modules
>> > > > don't have the proper parent and version set. I'm changing it, but
>> > there
>> > > > are RAT violations reported now. Should examples be in there by
>> > default,
>> > > > or should we only include in the release profile?
>> > > >
>> > > -> I would add them, but then as a logical consequence enable RAT on
>> > them
>> > > as well.
>> > >
>> > >
>> > I updated the build last night to include the examples.
>> >
>> >
>> > -> Thanks!
>> >
>> > > > 2. The following files don't include headers, Should they? I
>> believe
>> > if
>> > > > we fix these, the RAT reports should be better.
>> > > >
>> > > > - missing apache headers for:
>> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
>> > > > es/minimal/MinimalTests.java
>> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
>> > > > es/minimal/TestEnum.java
>> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
>> > > > les/minimal/MinimalTests.java
>> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
>> > > > les/minimal/TestEnum.java
>> > > > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
>> > > > metamodel/simple/SimpleTest.java
>> > > >
>> > > -> see above. Yes add headers to the examples. The rest, where RAT
>> was
>> > > already active should be clean as of now.
>> > >
>> > Ok, I'd prefer that the person who added the files can add the
>> headers. If
>> > you're not going to be able to get to it, I'll add them.
>> >
>> > -> OK. That's my task ;) Created the example as preparation of the
>> > javaland conference in Germany in spring.
>> >
>> > > > 3. any idea where the icons (in ./docs/images/icons) come from? We
>> > > should
>> > > > probably remove the Thumbs.db, but if we don't know where the icons
>> > came
>> > > > from and the icons aren't properly licensed we'll need to remove
>> them.
>> > > > Does it break something to remove them?
>> > > >
>> > > -> they are related to asciidoctor. May be possible to remove them or
>> > > check for the licence (as most Redhat stuff should be ALv2 as well). I
>> > will
>> > > check that later today ;) Thanks for the pointer.
>> > >
>> >
>> >
>> > Sounds good to me. These were the extent of the issues found, and
>> really
>> > the only blocker one is the missing headers. Once you figure out the
>> > graphics let's prep the release and start a vote.
>> >
>> > Any objections?
>> >
>> > -> No fully agree. I will given an update, once I finished my tasks.
>> > Hopefully this evening/night, the latest tomorrow lunch time MET ;)
>> >
>>
>>
>> Yep, just so I'm clear we need to either remove the images, or attribute
>> them in the LICENSE/NOTICE.
>>
>
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79 <%2B41-76%20344%2062%2079>*
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: Initial release input
Posted by Anatole Tresch <at...@gmail.com>.
Yep, I removed all images exception the one I have drawn myseld (part of
the design documentation). So that part should be clean now. Will check
later for missing licence headers and also have seen that the examples part
in asciidoc is only containing headers, so I will add some summary
descriptions there as well tonight...
Anatole
2015-08-03 15:08 GMT+02:00 John D. Ament <jo...@gmail.com>:
> On Mon, Aug 3, 2015 at 8:14 AM Tresch, Anatole <
> anatole.tresch@credit-suisse.com> wrote:
>
> > Hi John
> >
> > inline again (removed a few things to keep it brief)...
> >
> > Anatole
> >
> >
> > -----Original Message-----
> > From: John D. Ament [mailto:john.d.ament@gmail.com]
> > Sent: Montag, 3. August 2015 13:54
> > To: dev@tamaya.incubator.apache.org
> > Subject: Re: Initial release input
> >
> > Hi Anatole
> >
> > On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com>
> wrote:
> >
> > > > 1. RAT plugin wasn't running on the examples projects. The examples/
> > > > module was not included in the parent. But even then, the child
> > modules
> > > > don't have the proper parent and version set. I'm changing it, but
> > there
> > > > are RAT violations reported now. Should examples be in there by
> > default,
> > > > or should we only include in the release profile?
> > > >
> > > -> I would add them, but then as a logical consequence enable RAT on
> > them
> > > as well.
> > >
> > >
> > I updated the build last night to include the examples.
> >
> >
> > -> Thanks!
> >
> > > > 2. The following files don't include headers, Should they? I
> believe
> > if
> > > > we fix these, the RAT reports should be better.
> > > >
> > > > - missing apache headers for:
> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > > > es/minimal/MinimalTests.java
> > > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > > > es/minimal/TestEnum.java
> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > > > les/minimal/MinimalTests.java
> > > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > > > les/minimal/TestEnum.java
> > > > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> > > > metamodel/simple/SimpleTest.java
> > > >
> > > -> see above. Yes add headers to the examples. The rest, where RAT was
> > > already active should be clean as of now.
> > >
> > Ok, I'd prefer that the person who added the files can add the headers.
> If
> > you're not going to be able to get to it, I'll add them.
> >
> > -> OK. That's my task ;) Created the example as preparation of the
> > javaland conference in Germany in spring.
> >
> > > > 3. any idea where the icons (in ./docs/images/icons) come from? We
> > > should
> > > > probably remove the Thumbs.db, but if we don't know where the icons
> > came
> > > > from and the icons aren't properly licensed we'll need to remove
> them.
> > > > Does it break something to remove them?
> > > >
> > > -> they are related to asciidoctor. May be possible to remove them or
> > > check for the licence (as most Redhat stuff should be ALv2 as well). I
> > will
> > > check that later today ;) Thanks for the pointer.
> > >
> >
> >
> > Sounds good to me. These were the extent of the issues found, and really
> > the only blocker one is the missing headers. Once you figure out the
> > graphics let's prep the release and start a vote.
> >
> > Any objections?
> >
> > -> No fully agree. I will given an update, once I finished my tasks.
> > Hopefully this evening/night, the latest tomorrow lunch time MET ;)
> >
>
>
> Yep, just so I'm clear we need to either remove the images, or attribute
> them in the LICENSE/NOTICE.
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: Initial release input
Posted by "John D. Ament" <jo...@gmail.com>.
On Mon, Aug 3, 2015 at 8:14 AM Tresch, Anatole <
anatole.tresch@credit-suisse.com> wrote:
> Hi John
>
> inline again (removed a few things to keep it brief)...
>
> Anatole
>
>
> -----Original Message-----
> From: John D. Ament [mailto:john.d.ament@gmail.com]
> Sent: Montag, 3. August 2015 13:54
> To: dev@tamaya.incubator.apache.org
> Subject: Re: Initial release input
>
> Hi Anatole
>
> On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com> wrote:
>
> > > 1. RAT plugin wasn't running on the examples projects. The examples/
> > > module was not included in the parent. But even then, the child
> modules
> > > don't have the proper parent and version set. I'm changing it, but
> there
> > > are RAT violations reported now. Should examples be in there by
> default,
> > > or should we only include in the release profile?
> > >
> > -> I would add them, but then as a logical consequence enable RAT on
> them
> > as well.
> >
> >
> I updated the build last night to include the examples.
>
>
> -> Thanks!
>
> > > 2. The following files don't include headers, Should they? I believe
> if
> > > we fix these, the RAT reports should be better.
> > >
> > > - missing apache headers for:
> > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > > es/minimal/MinimalTests.java
> > > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > > es/minimal/TestEnum.java
> > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > > les/minimal/MinimalTests.java
> > > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > > les/minimal/TestEnum.java
> > > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> > > metamodel/simple/SimpleTest.java
> > >
> > -> see above. Yes add headers to the examples. The rest, where RAT was
> > already active should be clean as of now.
> >
> Ok, I'd prefer that the person who added the files can add the headers. If
> you're not going to be able to get to it, I'll add them.
>
> -> OK. That's my task ;) Created the example as preparation of the
> javaland conference in Germany in spring.
>
> > > 3. any idea where the icons (in ./docs/images/icons) come from? We
> > should
> > > probably remove the Thumbs.db, but if we don't know where the icons
> came
> > > from and the icons aren't properly licensed we'll need to remove them.
> > > Does it break something to remove them?
> > >
> > -> they are related to asciidoctor. May be possible to remove them or
> > check for the licence (as most Redhat stuff should be ALv2 as well). I
> will
> > check that later today ;) Thanks for the pointer.
> >
>
>
> Sounds good to me. These were the extent of the issues found, and really
> the only blocker one is the missing headers. Once you figure out the
> graphics let's prep the release and start a vote.
>
> Any objections?
>
> -> No fully agree. I will given an update, once I finished my tasks.
> Hopefully this evening/night, the latest tomorrow lunch time MET ;)
>
Yep, just so I'm clear we need to either remove the images, or attribute
them in the LICENSE/NOTICE.
RE: Initial release input
Posted by "Tresch, Anatole " <an...@credit-suisse.com>.
Hi John
inline again (removed a few things to keep it brief)...
Anatole
-----Original Message-----
From: John D. Ament [mailto:john.d.ament@gmail.com]
Sent: Montag, 3. August 2015 13:54
To: dev@tamaya.incubator.apache.org
Subject: Re: Initial release input
Hi Anatole
On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com> wrote:
> > 1. RAT plugin wasn't running on the examples projects. The examples/
> > module was not included in the parent. But even then, the child modules
> > don't have the proper parent and version set. I'm changing it, but there
> > are RAT violations reported now. Should examples be in there by default,
> > or should we only include in the release profile?
> >
> -> I would add them, but then as a logical consequence enable RAT on them
> as well.
>
>
I updated the build last night to include the examples.
-> Thanks!
> > 2. The following files don't include headers, Should they? I believe if
> > we fix these, the RAT reports should be better.
> >
> > - missing apache headers for:
> > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > es/minimal/MinimalTests.java
> > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > es/minimal/TestEnum.java
> > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > les/minimal/MinimalTests.java
> > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > les/minimal/TestEnum.java
> > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> > metamodel/simple/SimpleTest.java
> >
> -> see above. Yes add headers to the examples. The rest, where RAT was
> already active should be clean as of now.
>
Ok, I'd prefer that the person who added the files can add the headers. If
you're not going to be able to get to it, I'll add them.
-> OK. That's my task ;) Created the example as preparation of the javaland conference in Germany in spring.
> > 3. any idea where the icons (in ./docs/images/icons) come from? We
> should
> > probably remove the Thumbs.db, but if we don't know where the icons came
> > from and the icons aren't properly licensed we'll need to remove them.
> > Does it break something to remove them?
> >
> -> they are related to asciidoctor. May be possible to remove them or
> check for the licence (as most Redhat stuff should be ALv2 as well). I will
> check that later today ;) Thanks for the pointer.
>
Sounds good to me. These were the extent of the issues found, and really
the only blocker one is the missing headers. Once you figure out the
graphics let's prep the release and start a vote.
Any objections?
-> No fully agree. I will given an update, once I finished my tasks. Hopefully this evening/night, the latest tomorrow lunch time MET ;)
Re: Initial release input
Posted by "John D. Ament" <jo...@gmail.com>.
Hi Anatole
On Mon, Aug 3, 2015 at 2:06 AM Anatole Tresch <at...@gmail.com> wrote:
> Hi John/all
>
> great work! I can give you feedback I think on most points (inline).
>
> Anatole
>
>
> 2015-08-03 5:37 GMT+02:00 John D. Ament <jo...@apache.org>:
>
> > Hi all,
> >
> > I asked another IPMC member to look over our proposed release contents to
> > help identify issues with the release before we get into the actual
> release
> > cycle. Better to do it early than late from my experience.
> >
> > Most of it is simple clean up that needs to happen, but there's a few
> > questionable things I'd like you guys to look at and fix as appropriate.
> >
> > 1. RAT plugin wasn't running on the examples projects. The examples/
> > module was not included in the parent. But even then, the child modules
> > don't have the proper parent and version set. I'm changing it, but there
> > are RAT violations reported now. Should examples be in there by default,
> > or should we only include in the release profile?
> >
> -> I would add them, but then as a logical consequence enable RAT on them
> as well.
>
>
I updated the build last night to include the examples.
>
>
> > 2. The following files don't include headers, Should they? I believe if
> > we fix these, the RAT reports should be better.
> >
> > - missing apache headers for:
> > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > es/minimal/MinimalTests.java
> > ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> > es/minimal/TestEnum.java
> > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > les/minimal/MinimalTests.java
> > ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> > les/minimal/TestEnum.java
> > ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> > metamodel/simple/SimpleTest.java
> >
> -> see above. Yes add headers to the examples. The rest, where RAT was
> already active should be clean as of now.
>
>
Ok, I'd prefer that the person who added the files can add the headers. If
you're not going to be able to get to it, I'll add them.
>
>
> >
> > 3. any idea where the icons (in ./docs/images/icons) come from? We
> should
> > probably remove the Thumbs.db, but if we don't know where the icons came
> > from and the icons aren't properly licensed we'll need to remove them.
> > Does it break something to remove them?
> >
> -> they are related to asciidoctor. May be possible to remove them or
> check for the licence (as most Redhat stuff should be ALv2 as well). I will
> check that later today ;) Thanks for the pointer.
>
Sounds good to me. These were the extent of the issues found, and really
the only blocker one is the missing headers. Once you figure out the
graphics let's prep the release and start a vote.
Any objections?
John
>
> Best,
> Anatole
>
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: Initial release input
Posted by Anatole Tresch <at...@gmail.com>.
Hi John/all
great work! I can give you feedback I think on most points (inline).
Anatole
2015-08-03 5:37 GMT+02:00 John D. Ament <jo...@apache.org>:
> Hi all,
>
> I asked another IPMC member to look over our proposed release contents to
> help identify issues with the release before we get into the actual release
> cycle. Better to do it early than late from my experience.
>
> Most of it is simple clean up that needs to happen, but there's a few
> questionable things I'd like you guys to look at and fix as appropriate.
>
> 1. RAT plugin wasn't running on the examples projects. The examples/
> module was not included in the parent. But even then, the child modules
> don't have the proper parent and version set. I'm changing it, but there
> are RAT violations reported now. Should examples be in there by default,
> or should we only include in the release profile?
>
-> I would add them, but then as a logical consequence enable RAT on them
as well.
> 2. The following files don't include headers, Should they? I believe if
> we fix these, the RAT reports should be better.
>
> - missing apache headers for:
> ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> es/minimal/MinimalTests.java
> ./examples/1-minimal-example/src/test/java/org/tamaya/exampl
> es/minimal/TestEnum.java
> ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> les/minimal/MinimalTests.java
> ./examples/4-resolver-example/src/test/java/org/tamaya/examp
> les/minimal/TestEnum.java
> ./sandbox/metamodels/simple/src/test/java/org/apache/tamaya/
> metamodel/simple/SimpleTest.java
>
-> see above. Yes add headers to the examples. The rest, where RAT was
already active should be clean as of now.
>
> 3. any idea where the icons (in ./docs/images/icons) come from? We should
> probably remove the Thumbs.db, but if we don't know where the icons came
> from and the icons aren't properly licensed we'll need to remove them.
> Does it break something to remove them?
>
-> they are related to asciidoctor. May be possible to remove them or
check for the licence (as most Redhat stuff should be ALv2 as well). I will
check that later today ;) Thanks for the pointer.
Best,
Anatole
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*