You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/24 18:23:05 UTC
[jira] [Commented] (STORM-1068) Configure request.required.acks to
be 1 in KafkaUtilsTest for sync
[ https://issues.apache.org/jira/browse/STORM-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906585#comment-14906585 ]
ASF GitHub Bot commented on STORM-1068:
---------------------------------------
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/762
[STORM-1068], configure request.required.acks in KafkaUtilsTest
configure request.required.acks to be 1 in KafkaUtilsTest to make sure that the send() function gets synchronized to the broker for avoiding potential offset-out-of-range error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1068
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #762
----
commit d75e5fbed635a4c096c98d0abf25236c8616503d
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-09-24T16:20:37Z
STORM-1068, configure request.required.acks in KafkaUtilsTest
----
> Configure request.required.acks to be 1 in KafkaUtilsTest for sync
> ------------------------------------------------------------------
>
> Key: STORM-1068
> URL: https://issues.apache.org/jira/browse/STORM-1068
> Project: Apache Storm
> Issue Type: Test
> Components: storm-kafka
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Priority: Minor
>
> In KafkaProducer, request.required.acks is by default 0. In KafkaUtilsTest, if we don't set it to be 1, the send(xx).get() may not actually synchronize as expected, which can potentially cause offset out-of-range error when the consumer tries to read something. BTW, in KafkaBoltTest, we already have this set appropriately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)