You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by re...@apache.org on 2018/07/17 08:44:56 UTC
aurora git commit: TaskQuery struct needs to be optional
Repository: aurora
Updated Branches:
refs/heads/master a6d9288ce -> efe865651
TaskQuery struct needs to be optional
In languages like Go, types are not optionals by default.
The actual api.thift don't let create queries with just a
few fields in Go since all the fields are required
Bugs closed: https://issues.apache.org/jira/browse/AURORA-1991
Reviewed at https://reviews.apache.org/r/67757/
Project: http://git-wip-us.apache.org/repos/asf/aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/aurora/commit/efe86565
Tree: http://git-wip-us.apache.org/repos/asf/aurora/tree/efe86565
Diff: http://git-wip-us.apache.org/repos/asf/aurora/diff/efe86565
Branch: refs/heads/master
Commit: efe8656512373389771aff88c2141940f925ad58
Parents: a6d9288
Author: Ezequiel Torres <ez...@gmail.com>
Authored: Tue Jul 17 10:40:04 2018 +0200
Committer: Renan DelValle <re...@apache.org>
Committed: Tue Jul 17 10:40:04 2018 +0200
----------------------------------------------------------------------
.../thrift/org/apache/aurora/gen/api.thrift | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/aurora/blob/efe86565/api/src/main/thrift/org/apache/aurora/gen/api.thrift
----------------------------------------------------------------------
diff --git a/api/src/main/thrift/org/apache/aurora/gen/api.thrift b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
index 7265b11..653da94 100644
--- a/api/src/main/thrift/org/apache/aurora/gen/api.thrift
+++ b/api/src/main/thrift/org/apache/aurora/gen/api.thrift
@@ -577,16 +577,16 @@ struct GetJobsResult {
* (terms are AND'ed together).
*/
struct TaskQuery {
- 14: string role
- 9: string environment
- 2: string jobName
- 4: set<string> taskIds
- 5: set<ScheduleStatus> statuses
- 7: set<i32> instanceIds
- 10: set<string> slaveHosts
- 11: set<JobKey> jobKeys
- 12: i32 offset
- 13: i32 limit
+ 14: optional string role
+ 9: optional string environment
+ 2: optional string jobName
+ 4: optional set<string> taskIds
+ 5: optional set<ScheduleStatus> statuses
+ 7: optional set<i32> instanceIds
+ 10: optional set<string> slaveHosts
+ 11: optional set<JobKey> jobKeys
+ 12: optional i32 offset
+ 13: optional i32 limit
}
struct HostStatus {